From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 350044624E for ; Mon, 17 Feb 2025 18:07:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 232E7402BB; Mon, 17 Feb 2025 18:07:04 +0100 (CET) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id 101E3402E5 for ; Mon, 17 Feb 2025 18:07:02 +0100 (CET) Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-38f3ea6207cso1266318f8f.3 for ; Mon, 17 Feb 2025 09:07:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812022; x=1740416822; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=evxfXjy/9EiSWQx5LA5PDgzTvHgivcjYrvkduT/jlvQ=; b=dsooqfaAb2en9EbwFrrNwY/zhQS+SLpdMAcewum8i9KnAkgqreGqED2um9+pTaGdhs SM6MLDwjJ5pelxIdgOJfaalfOWRJbL2bmldT3d/RTMvXfj4lIxNeXCDkWu4FvRnIDrCx 2k5ezS3soEfD4Hj+r4GyXwdqTjLEelxLIWpdHDfjf6DmfvLM1W786sBnjzM2dWEqVBxp JDj/2dwjmLZ2ZHcU1x6AQPZcRJxG1PwTpAPRt+owiZ2bR95k/lxQP/17qYdDQecleM3R S6AS84WRtksWRLkBpO3MYOOiReuGIKC9SaCd7xA9S4v5i4fbui5lULyR9J7Tg++SWGFR Y6dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812022; x=1740416822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=evxfXjy/9EiSWQx5LA5PDgzTvHgivcjYrvkduT/jlvQ=; b=OwYPxNjvHgRltEzvo9Jf1DY4rOV7ZyeOnkBp9wOmIq/YAP7tDSL5vV3SmW1HbDCvgM 3WU3Ud0VxQ0rso35O3BFDHDBFgIQsDhtabflHZIGnOJv1hX4Rn9jgrKraVTdJNJAiBg6 8uxJ7buEH8JbIVKBAmJKnk0wZATy7k4c+LvkNGY4K6Klom7Li7T39cfOmMKVDRFKZMff ixVHzYy+6+NJHCf2YoAKf85UTmAI5BxxlCPA5ueR/haDe5aefPL5FL3tcnqM0O0vMA+k jGrkR4uDz/LmAuhnmJtvyvPpbTeUFGcbIYKui9Jos8w/wpud11FvXYLXdNEYzFOw/mvy /nyg== X-Forwarded-Encrypted: i=1; AJvYcCV8XxQZdrfe7hRq8Bhjjnre7ylYXRbyYaamFEb9dIFuxwwYDAdMkF/K/PQ9pD0p45YM2vLF4B0=@dpdk.org X-Gm-Message-State: AOJu0YyGUbt5ZaDWlCD1thnZV3VRUUSi6I9co4+hEwFzshHilWCDKYKe yM/EbjXG276xt0lqIBESzdz/UNVrOU2ScjG9Bye/5jT2LxEJlNu5+jRH0GNijCTFvw== X-Gm-Gg: ASbGncv6+yYTgrH9f3lv4gJHSDVFHn3vumWsSyKXpue4bW8rJj1f/8xBe2ADzhhZDJd +wTAwFfb9JjPR2R2zr/Uk4c/TE7tDDQ8rm8V/s9eJGpCkCkUZVZ7jFm6JcfCtlg7q2s+nGEUF6w R8QQUMihFSbehNBXER7Vreg4LMRsKjdjOyjJOwM/3tASLXuNcfJg/XyMd58bG3Zqg4aiQpOLXCq DjgHUWqq+Z/QRhm5uvVwCI7/d8PG1kNwHAmoL59gnwMeNWa23N4Gwjprs17lbOFt0CzA5hbxRtw R5wW2wEXGGFO/AR7Urq2sw== X-Google-Smtp-Source: AGHT+IFfY/y9VEOawb+UTeTgfZLZSgNMnc200cYu/5u4JwmknuM0/vyF3/wPVrnRYEq2GSFR17h8NA== X-Received: by 2002:a5d:6d8c:0:b0:38f:394f:d81 with SMTP id ffacd0b85a97d-38f394f9c67mr6697324f8f.2.1739812021372; Mon, 17 Feb 2025 09:07:01 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-38f259d5f4fsm12791360f8f.78.2025.02.17.09.07.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:07:00 -0800 (PST) From: luca.boccassi@gmail.com To: Dima Ruinskiy Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/igc/base: fix typo in LTR calculation' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:04:13 +0000 Message-ID: <20250217170456.1068278-40-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ec6a60f0806121520ffd06c87eb3e00f488d76dc Thanks. Luca Boccassi --- >From ec6a60f0806121520ffd06c87eb3e00f488d76dc Mon Sep 17 00:00:00 2001 From: Dima Ruinskiy Date: Thu, 6 Feb 2025 16:08:30 +0000 Subject: [PATCH] net/igc/base: fix typo in LTR calculation [ upstream commit ce11274c5c7188322cc141cdce8cd0680e76f79f ] The LTR maximum value was incorrectly written using the scale from the LTR minimum value. This would cause incorrect values to be sent, in cases where the initial calculation leads to different min/max scales. Fix the typo to correctly calculate the LTR maximum value. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Dima Ruinskiy Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_i225.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index a6f0ac0612..e627bdd6b5 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -1083,7 +1083,7 @@ static s32 igc_set_ltr_i225(struct igc_hw *hw, bool link) ltrv = IGC_READ_REG(hw, IGC_LTRMAXV); if (ltr_max != (ltrv & IGC_LTRMAXV_LTRV_MASK)) { ltrv = IGC_LTRMAXV_LSNP_REQ | ltr_max | - (scale_min << IGC_LTRMAXV_SCALE_SHIFT); + (scale_max << IGC_LTRMAXV_SCALE_SHIFT); IGC_WRITE_REG(hw, IGC_LTRMAXV, ltrv); } } -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:18.280077131 +0000 +++ 0040-net-igc-base-fix-typo-in-LTR-calculation.patch 2025-02-17 16:13:16.838441592 +0000 @@ -1 +1 @@ -From ce11274c5c7188322cc141cdce8cd0680e76f79f Mon Sep 17 00:00:00 2001 +From ec6a60f0806121520ffd06c87eb3e00f488d76dc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ce11274c5c7188322cc141cdce8cd0680e76f79f ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ - drivers/net/intel/igc/base/igc_i225.c | 2 +- + drivers/net/igc/base/igc_i225.c | 2 +- @@ -21,5 +22,5 @@ -diff --git a/drivers/net/intel/igc/base/igc_i225.c b/drivers/net/intel/igc/base/igc_i225.c -index e701d00f80..c7c2ec8ffe 100644 ---- a/drivers/net/intel/igc/base/igc_i225.c -+++ b/drivers/net/intel/igc/base/igc_i225.c -@@ -1086,7 +1086,7 @@ static s32 igc_set_ltr_i225(struct igc_hw *hw, bool link) +diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c +index a6f0ac0612..e627bdd6b5 100644 +--- a/drivers/net/igc/base/igc_i225.c ++++ b/drivers/net/igc/base/igc_i225.c +@@ -1083,7 +1083,7 @@ static s32 igc_set_ltr_i225(struct igc_hw *hw, bool link)