From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 632794624E for ; Mon, 17 Feb 2025 18:07:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55F2B402AB; Mon, 17 Feb 2025 18:07:14 +0100 (CET) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id 14AA2400D6 for ; Mon, 17 Feb 2025 18:07:13 +0100 (CET) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-38f2c4382d1so1825561f8f.0 for ; Mon, 17 Feb 2025 09:07:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812033; x=1740416833; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WYmaDKaXyatG4lO5N8WaMJFC1SnZNfU/zurw9C1AdjI=; b=PytzCeDKH3Euk0uDuxz3d1PjTGt09TlDWzPJqJPDTIP5MXB0RaAcYASfbVgwjCjVJ0 5Nf3YgmouPRMsoQhRNl8iVLpB4Ylfm+3prqo4BTsCp8Tj514sdGpdFgucp79PAn1U6m6 0RQn/wtcLByzjilUKuNdrbFlqZ16phybht4jiSE5JLSKLNJJFSV0f42Ldmo97Vub3x7c WGvpbvMtbnDL/ok6ulmAje1vicRx1UUUUpE62Cj75+I6v5V0UHuVrW7EqUNaBNVxwBw9 1Lj5oMY8EHW8nUPnAo/A/90v3+Ya6GJeyEg/RPy+9CzcBmPcpRf/N1Cl3/rvjqnjTUYz S0fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812033; x=1740416833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WYmaDKaXyatG4lO5N8WaMJFC1SnZNfU/zurw9C1AdjI=; b=r3JZ6cuaGXSOYwlmTeYDDpX2K7UIFV4b/ZJR6AEMAiXbDDWc9DrU0w5MaC9kHzhupa 3vw+IIdsrogvaNJXjyWsAptlNC8ov02wjM0K17jKukEEx4Q+iopUF1pcr9bD9nEUFxPk FqCI5ZGB/hdCTmbk4RVuHF3tIi0OtM7ie8HeUa9UsJ+Uv++3Ey3ryYUxWOkAEhPLsv8l ETXYVpeWZpCsasxLHvo0q0v/B9qOckvUKaxDf/AoWC3ej0cuiRbrQIJOm8f1CxEN73+w Cq9mw+TgpgANUk7P55L9eWqjDUFg0xyDnTXW0PsD7lENiWzzUfD+3KbGqwHlaWHApxjI VXiQ== X-Forwarded-Encrypted: i=1; AJvYcCV+I7bglRdJwH37zIC1i4LyCeMy9dgINBr2HHu7NeNh5R1CIPZZqzAjtAU8VMFQbao3/kUkqYM=@dpdk.org X-Gm-Message-State: AOJu0YwJ0tqZBrT0ZUGZRdB9uD+I1IevYDNOdhVMrsgR7XgSkcO8w7/R clp2QxgWx2iRwYWa8O7yeaRcxmkmnxEktd2g0lJgHJ9zOZf0W1AvKgLzmE3V0d2FiA== X-Gm-Gg: ASbGnctR9xqo1uyMr7uFe/SS6sSLq6cIe29Mc2/2qUwKVwlj+xERYgibhJBCAXJxeYA ZEl7JmItk10QAiwcXO/4sBcncVzCH6MoXzy93QA5kq/2oV0QRV4Hp60lqJoYBqxs9nfl+V/lOlG aLuvjT7RoIN8OJbuw3PzmWRu5UCA8k18yY/5Fag0Oww2pZYdLFwRbt7pjXn0f++WlOfLG74zsrd ThOaGNnqEcLvuyWdS3YZ1Fat2KOCmmODeTZk/qaVbr0/p9AYTC/n+mg5lJSFb2GFrKC+dwdFVin LBos/QLrhZJG1kL4w2KJ/w== X-Google-Smtp-Source: AGHT+IFEfNX+5E5KNRG/e/0QpXxaKgTvoSWLkmGktsezClhlG3cLSnkBKNBFoHVlgMSar3ZVBV9MAw== X-Received: by 2002:a05:6000:186d:b0:38a:4184:14ec with SMTP id ffacd0b85a97d-38f339d8a19mr11134870f8f.1.1739812032471; Mon, 17 Feb 2025 09:07:12 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-38f259d65dfsm12970172f8f.64.2025.02.17.09.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:07:12 -0800 (PST) From: luca.boccassi@gmail.com To: Dima Ruinskiy Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/igc/base: fix unused value' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:04:14 +0000 Message-ID: <20250217170456.1068278-41-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/1dad8b6c976b8ab91509785f40fbfb94035d3115 Thanks. Luca Boccassi --- >From 1dad8b6c976b8ab91509785f40fbfb94035d3115 Mon Sep 17 00:00:00 2001 From: Dima Ruinskiy Date: Thu, 6 Feb 2025 16:08:31 +0000 Subject: [PATCH] net/igc/base: fix unused value [ upstream commit c506cc8305b4ca17bae903a54daaeaf5b7005038 ] Static analysis has reported that when there is no get link status callback function, the value set in the if condition is not used and gets overwritten in the "out" section of the code. Fix by not setting the variable. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Dima Ruinskiy Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_i225.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index e627bdd6b5..6c45fa5427 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -1111,10 +1111,8 @@ s32 igc_check_for_link_i225(struct igc_hw *hw) * changed. The get_link_status flag is set upon receiving * a Link Status Change or Rx Sequence Error interrupt. */ - if (!mac->get_link_status) { - ret_val = IGC_SUCCESS; + if (!mac->get_link_status) goto out; - } /* First we want to see if the MII Status Register reports * link. If so, then we want to get the current speed/duplex -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:18.312318711 +0000 +++ 0041-net-igc-base-fix-unused-value.patch 2025-02-17 16:13:16.838441592 +0000 @@ -1 +1 @@ -From c506cc8305b4ca17bae903a54daaeaf5b7005038 Mon Sep 17 00:00:00 2001 +From 1dad8b6c976b8ab91509785f40fbfb94035d3115 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c506cc8305b4ca17bae903a54daaeaf5b7005038 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ - drivers/net/intel/igc/base/igc_i225.c | 4 +--- + drivers/net/igc/base/igc_i225.c | 4 +--- @@ -21,5 +22,5 @@ -diff --git a/drivers/net/intel/igc/base/igc_i225.c b/drivers/net/intel/igc/base/igc_i225.c -index c7c2ec8ffe..23c68a3948 100644 ---- a/drivers/net/intel/igc/base/igc_i225.c -+++ b/drivers/net/intel/igc/base/igc_i225.c -@@ -1114,10 +1114,8 @@ s32 igc_check_for_link_i225(struct igc_hw *hw) +diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c +index e627bdd6b5..6c45fa5427 100644 +--- a/drivers/net/igc/base/igc_i225.c ++++ b/drivers/net/igc/base/igc_i225.c +@@ -1111,10 +1111,8 @@ s32 igc_check_for_link_i225(struct igc_hw *hw)