From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B61244624E for ; Mon, 17 Feb 2025 18:07:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADAF4400EF; Mon, 17 Feb 2025 18:07:30 +0100 (CET) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mails.dpdk.org (Postfix) with ESMTP id 98C80400EF for ; Mon, 17 Feb 2025 18:07:29 +0100 (CET) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43948f77f1aso29976445e9.0 for ; Mon, 17 Feb 2025 09:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812049; x=1740416849; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F3GvtHL/QWhSRAGGQg/9Kfkzd9tTOL23cWxgQHqrbLU=; b=XrwZxT6F54xtmKN6sV2iGubxcQHkUGnWNPQsLQP37nUmzALZpDxe3xDSlFzLXNHDeK WVWlt2qlLhNNTRajC7p1L/8aTMuLVUY13AhRZMSMsUQu5oxC09WcWEy3sxNPzrx2t+Mh E8Gj2Fnx9ZcI1AxK8SbMQQV23NRo8ItvXEQZ8nHLlHSMmmUXnPZ8lBBgMt+nRX19Bhum sMYaRYyG0HUFh9THf2WgUrP9KxIQnYgbX4nzDqPzyO17ovM01HyF8eqfmMTNLGu5+abW M4m6A7o2WnXuKCvg8IDyWBSpoBXW6pxBxDFnHXK3u+plkcwSdaDtCDmPfD3uo2fRErvi TSFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812049; x=1740416849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F3GvtHL/QWhSRAGGQg/9Kfkzd9tTOL23cWxgQHqrbLU=; b=iqkaK9U2roVyGurOkl1b7llZiMWKU++yJTp+it/TMmoHK+lFqE0EAz8yq7AH3X1BvH u5B3HhRQFkwm1h1TOT+0LRNdc9IdTRvhYTYnc7aG4p0C+uha1W2VryEmGe7Y/hiHHhzT v3ZRPvZg5dngEhdn5Z4jgK8fGVr9RLbhgrNwEA/AP6q/Wp8nv/MTC6jiQfx1ZvNJC5S7 jeFW0l1A/u+W9ycEoGCVUCZrjLva7oP8SdRk7Lvm4EabcHgYmBEw4XH6KXRsFdehLmYB DEaExPumfGIn+0yWRdRyDO1IAtHS0ou/83ZUSlJEaweyXcjcgejFZs2fI5ZIPA1IaEVL 03pg== X-Forwarded-Encrypted: i=1; AJvYcCU0+m2WLmkwwVQmESxD7F/m6sBwKx/P/eMVSe325pvtKeT3VO/xxW8WB0sr1mQiDniGgmjCE6c=@dpdk.org X-Gm-Message-State: AOJu0YwctTr4dptIvrZdlZWWkNU/G9k5XJq5HEcC+4ULII/ZaY+LJhAB vKBlxOgkiyA5u6WQQfIpwYZqhSGBYvFD/wcEa/dr4sJNkcReDfZmUGK1f+VvD5qGvA== X-Gm-Gg: ASbGncuGENSXGketSzj6cA6flW/wkGUAUE5nTubUMpO9T7H7PoeVN5Hd0IeSI5+7AEv xmwkO1ku7BPQ+u+UiI0AFe3UwiJBYv/rPxmVBl+zzB8zPXH0aKqbXS0uYwPoDco7+TEYr+rMpOf pF8FCJJGqDL0LV9/mgl6fPH2DReg8UUbteoVcvcGah+TMHD9K0XEj1t33fuNvqdBKHQDW6G7xOQ NTx9x/xy3LeqarjntAnrKArv1cs2TIxSI0ujcY3BvT6os7xT7Musy7h1Fk+R91BiJXpikPVttT+ 4z2OBiljMGcZIFnUjJljbQ== X-Google-Smtp-Source: AGHT+IFOYDfOhIQmXm1QveDdh4wxd1fTBpG60IX+1jIn5yft/0hwPUHq2zvuiZf9Jogkl5FI30Fn8g== X-Received: by 2002:a05:600c:4ecd:b0:434:a468:4a57 with SMTP id 5b1f17b1804b1-4396e750885mr79136325e9.26.1739812049042; Mon, 17 Feb 2025 09:07:29 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4395a1b8443sm158574675e9.35.2025.02.17.09.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:07:28 -0800 (PST) From: luca.boccassi@gmail.com To: Przemyslaw Ciesielski Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/igc/base: fix NVM data type in bit shift' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:04:19 +0000 Message-ID: <20250217170456.1068278-46-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/62be1de4f74e1ca260d3035c80afddcb4f60c567 Thanks. Luca Boccassi --- >From 62be1de4f74e1ca260d3035c80afddcb4f60c567 Mon Sep 17 00:00:00 2001 From: Przemyslaw Ciesielski Date: Thu, 6 Feb 2025 16:08:36 +0000 Subject: [PATCH] net/igc/base: fix NVM data type in bit shift [ upstream commit d6ad4cdad361558bfb2c04112bd6650debbc9c7f ] There is a static analysis warning due to wrong data types being used for NVM read data shifts. Fix it via explicit type cast. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Przemyslaw Ciesielski Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_nvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/igc/base/igc_nvm.c b/drivers/net/igc/base/igc_nvm.c index a7c901ab56..d37a3ffb0e 100644 --- a/drivers/net/igc/base/igc_nvm.c +++ b/drivers/net/igc/base/igc_nvm.c @@ -926,14 +926,14 @@ s32 igc_read_pba_num_generic(struct igc_hw *hw, u32 *pba_num) DEBUGOUT("NVM Not Supported\n"); return -IGC_NOT_IMPLEMENTED; } - *pba_num = (u32)(nvm_data << 16); + *pba_num = ((u32)nvm_data << 16); ret_val = hw->nvm.ops.read(hw, NVM_PBA_OFFSET_1, 1, &nvm_data); if (ret_val) { DEBUGOUT("NVM Read Error\n"); return ret_val; } - *pba_num |= nvm_data; + *pba_num |= (u32)nvm_data; return IGC_SUCCESS; } -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:18.483757437 +0000 +++ 0046-net-igc-base-fix-NVM-data-type-in-bit-shift.patch 2025-02-17 16:13:16.842441592 +0000 @@ -1 +1 @@ -From d6ad4cdad361558bfb2c04112bd6650debbc9c7f Mon Sep 17 00:00:00 2001 +From 62be1de4f74e1ca260d3035c80afddcb4f60c567 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d6ad4cdad361558bfb2c04112bd6650debbc9c7f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/igc/base/igc_nvm.c | 4 ++-- + drivers/net/igc/base/igc_nvm.c | 4 ++-- @@ -19 +20 @@ -diff --git a/drivers/net/intel/igc/base/igc_nvm.c b/drivers/net/intel/igc/base/igc_nvm.c +diff --git a/drivers/net/igc/base/igc_nvm.c b/drivers/net/igc/base/igc_nvm.c @@ -21,2 +22,2 @@ ---- a/drivers/net/intel/igc/base/igc_nvm.c -+++ b/drivers/net/intel/igc/base/igc_nvm.c +--- a/drivers/net/igc/base/igc_nvm.c ++++ b/drivers/net/igc/base/igc_nvm.c