From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A56734624E
for <public@inbox.dpdk.org>; Mon, 17 Feb 2025 18:07:47 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9EA96402BB;
Mon, 17 Feb 2025 18:07:47 +0100 (CET)
Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com
[209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id 95A56400EF
for <stable@dpdk.org>; Mon, 17 Feb 2025 18:07:46 +0100 (CET)
Received: by mail-wr1-f41.google.com with SMTP id
ffacd0b85a97d-38f406e9f80so1239898f8f.2
for <stable@dpdk.org>; Mon, 17 Feb 2025 09:07:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739812066; x=1740416866; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=M+Toms6abfy5WVKwLEZW/FO2kLNA4EB+KKDeCC1jM84=;
b=Zt5UL5zT1mZwqyDlIPs3gkVvwC4w4b/yGQXHxKdiSIxYQKbaoPFjOgUym/9JVYJYS/
au44AtM7c5iwowUuRVslJutdSM5RngCLnDJzHTWaiP8KJGgLUGooLNdvYZUlvcvf4h9A
hQn95BUhBhclnxzn2Tjj3p2Ut+r5+TQMYIrvSsRvrq4JsOoNVRoBnJDTvbalu2eY7pNa
W891+9ppqgNde821Z2by3j3q8U8oW60tQo6RLQCV8TSle5DeMMymIKh+Z9IYrt58Cf2B
vgCVx+mpEZ35gmWhMd+upyR1Aj9fL3+ft/secxVQgXEcjdGltsmQ59N4ThRispHVS+xr
OiQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739812066; x=1740416866;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=M+Toms6abfy5WVKwLEZW/FO2kLNA4EB+KKDeCC1jM84=;
b=TEqoF8dnZkKSaa1IOQwJsWsiqkyK0npSFLessoo5nRi0AeLsSfXqdZYL7EMJBPXclA
YPJHYAUkXQQhPCd8hhQmGtg9UgL5C7ZytGBL9CjaFEAivbo0+1UWc5XYSq8oTxKHsqB0
ScQKI7RKAcXjbeRkD780eT003tk3faknnmA8Z4NcJPw06HpLIVgJZ+OURcDICUUCvg3Z
CRbWkTfArIW/IB+NR5dzkFUsZO6Tql/6EG+hNyJK1ZWp/OtR3sksmAQ7yr4gxoSUprv4
E8Q7f6u6euresNOPaK3HqRjPRhxQjj/Lr374SFngAcHEJ/minNqmW8VUpxBhZLtdYZuK
iIQg==
X-Forwarded-Encrypted: i=1;
AJvYcCXOxqqN/BgXiWLVNUqK6Rmn9oOdBJAqgANnr82aH+j9ipPA79C1HHxnnsuzkAnORXuRLtkko8g=@dpdk.org
X-Gm-Message-State: AOJu0YwvLeEXB0y21zPAC12ugPRiR5qhJZ+KN+06f1epw/vw1Vhk0yJ9
er7DG+398MaV2yJU6sk1Q14PdX2Q1MDNoaHX9HD8CdKsIBaat7dC0Yy8DAP2gILU4g==
X-Gm-Gg: ASbGnctvuw0srnOcaqT9Kn1XZvUmPMgoOceDYsLvt/GMx0ynqhSbG5K2vwOneTf3Z23
yYMEkQBA2+0e5iNvv/lrh6aSmXCPnCeO02uGkw3lLhaOCNGaS3tldmq8u8uqk4or8Uw8R5VK2Nf
kzkZwJSCSvMDwUdLSgQUvcVf2QWfYzuHpjM2MLQcXezZf2YGIZUNy2regYYxSVXT52xkwqJillV
Vp7i7JLBnv2ZoYlTxb8ndSFAUX9qCTUebCFrwIFyi9ifIQOtUvwQzZ56MAq/QXj7hjg8K6oG23u
U21V3Bzh+XTbThEucY0OlA==
X-Google-Smtp-Source: AGHT+IHno6Az+8U1GcdmcthAM2LZLZu1K5jJEeTG9iUSgQlJSEM8A9rqzSM/TcEFQIPi5RHFJKuSkQ==
X-Received: by 2002:adf:f20a:0:b0:38f:3009:e22a with SMTP id
ffacd0b85a97d-38f33f28769mr8206000f8f.15.1739812066061;
Mon, 17 Feb 2025 09:07:46 -0800 (PST)
Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997])
by smtp.gmail.com with UTF8SMTPSA id
ffacd0b85a97d-38f258ddbb2sm12525354f8f.40.2025.02.17.09.07.45
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 17 Feb 2025 09:07:45 -0800 (PST)
From: luca.boccassi@gmail.com
To: Jakub Buchocki <jakubx.buchocki@intel.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: patch 'net/e1000/base: fix uninitialized variable' has been queued to
stable release 22.11.8
Date: Mon, 17 Feb 2025 17:04:25 +0000
Message-ID: <20250217170456.1068278-52-luca.boccassi@gmail.com>
X-Mailer: git-send-email 2.47.2
In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com>
References: <20250217170456.1068278-1-luca.boccassi@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Hi,
FYI, your patch has been queued to stable release 22.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/f744d2974866a5ffb9b89075d8ec3adc503163f3
Thanks.
Luca Boccassi
---
>From f744d2974866a5ffb9b89075d8ec3adc503163f3 Mon Sep 17 00:00:00 2001
From: Jakub Buchocki <jakubx.buchocki@intel.com>
Date: Thu, 6 Feb 2025 16:08:42 +0000
Subject: [PATCH] net/e1000/base: fix uninitialized variable
[ upstream commit 4be9a7008efe063fbd326fea9965f946c8969039 ]
Static analysis has detected potential usage of uninitialized values
inside the array. Fix the warning by initializing array.
Fixes: af75078fece3 ("first public release")
Signed-off-by: Jakub Buchocki <jakubx.buchocki@intel.com>
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
.mailmap | 1 +
drivers/net/e1000/base/e1000_vf.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index 20a6cc4c1f..dc7a465822 100644
--- a/.mailmap
+++ b/.mailmap
@@ -564,6 +564,7 @@ Jacek Naczyk <jacek.naczyk@intel.com>
Jacek Piasecki <jacekx.piasecki@intel.com>
Jacek Siuda <jck@semihalf.com>
Jacob Keller <jacob.e.keller@intel.com>
+Jakub Buchocki <jakubx.buchocki@intel.com>
Jakub Chylkowski <jakubx.chylkowski@intel.com>
Jakub Grajciar <jgrajcia@cisco.com>
Jakub Neruda <neruda@netcope.com>
diff --git a/drivers/net/e1000/base/e1000_vf.c b/drivers/net/e1000/base/e1000_vf.c
index fc30357c17..472b921b6f 100644
--- a/drivers/net/e1000/base/e1000_vf.c
+++ b/drivers/net/e1000/base/e1000_vf.c
@@ -376,7 +376,7 @@ STATIC void e1000_write_msg_read_ack(struct e1000_hw *hw,
void e1000_update_mc_addr_list_vf(struct e1000_hw *hw,
u8 *mc_addr_list, u32 mc_addr_count)
{
- u32 msgbuf[E1000_VFMAILBOX_SIZE];
+ u32 msgbuf[E1000_VFMAILBOX_SIZE] = {0};
u16 *hash_list = (u16 *)&msgbuf[1];
u32 hash_value;
u32 i;
--
2.47.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-17 16:13:18.693138669 +0000
+++ 0052-net-e1000-base-fix-uninitialized-variable.patch 2025-02-17 16:13:16.850441592 +0000
@@ -1 +1 @@
-From 4be9a7008efe063fbd326fea9965f946c8969039 Mon Sep 17 00:00:00 2001
+From f744d2974866a5ffb9b89075d8ec3adc503163f3 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4be9a7008efe063fbd326fea9965f946c8969039 ]
+
@@ -10 +11,0 @@
-Cc: stable@dpdk.org
@@ -16,2 +17,2 @@
- .mailmap | 1 +
- drivers/net/intel/e1000/base/e1000_vf.c | 2 +-
+ .mailmap | 1 +
+ drivers/net/e1000/base/e1000_vf.c | 2 +-
@@ -21 +22 @@
-index ab03985acd..af83b4e129 100644
+index 20a6cc4c1f..dc7a465822 100644
@@ -24 +25,2 @@
-@@ -620,6 +620,7 @@ Jacek Piasecki <jacekx.piasecki@intel.com>
+@@ -564,6 +564,7 @@ Jacek Naczyk <jacek.naczyk@intel.com>
+ Jacek Piasecki <jacekx.piasecki@intel.com>
@@ -26 +27,0 @@
- Jack Bond-Preston <jack.bond-preston@foss.arm.com> <jack.bond-preston@arm.com>
@@ -32 +33 @@
-diff --git a/drivers/net/intel/e1000/base/e1000_vf.c b/drivers/net/intel/e1000/base/e1000_vf.c
+diff --git a/drivers/net/e1000/base/e1000_vf.c b/drivers/net/e1000/base/e1000_vf.c
@@ -34,2 +35,2 @@
---- a/drivers/net/intel/e1000/base/e1000_vf.c
-+++ b/drivers/net/intel/e1000/base/e1000_vf.c
+--- a/drivers/net/e1000/base/e1000_vf.c
++++ b/drivers/net/e1000/base/e1000_vf.c