From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21AC64624E for ; Mon, 17 Feb 2025 18:08:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CDF0400EF; Mon, 17 Feb 2025 18:08:03 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id 243D3400EF for ; Mon, 17 Feb 2025 18:08:02 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43932b9b09aso50485505e9.3 for ; Mon, 17 Feb 2025 09:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812082; x=1740416882; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tSGRs/OllQqezc8k/T9IyFdy8TOEwdBtJkPmGEpozNI=; b=SoYMCsgS++cQ2mNR+Y19rakQdZ7isH7KVx2+09AOjlh9O9Y8JpS0/IpcYa8qsXegcI 2Wq3UY9oaJ5HMpuiiENXregUjdv/tZ2dmAt/QHmGIM0uia2ODDkUpgW8TMDAKYc5aZXb ixzUPzZduav5VvMO2j6q6Ck5vrXNiE8EGeCw9VQuHyzsdtzavu5ViiMHpyYw5I4vV18c zAUkeL2wADtblj87TczLoRu2fEZ79nkrIwqqTMVKzha6zjGOZ4ntjyYvpRN30w/XBc5S g48JrzoaOkriFtsupWuMnBJDrvGrpYfitIcAkQ2v6UkmNplgx14XzfY/mdw2TGQCLn5N teXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812082; x=1740416882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tSGRs/OllQqezc8k/T9IyFdy8TOEwdBtJkPmGEpozNI=; b=teycEMb8wr16ChsWUEGUHOh8BNHk0H+znLGQsy5M8n8A7eidMtgOmXkd45YLnwtBTK qElxrUmlw1NvTHvrGsp6xx58PYD8EGyRnJ9W/WD1TvQLbKrY4tFNS101vSk3+gheFxpt JzTDuo6OyraaZJ3o89LflC0cwHAK2QnXUB7ZIm2MRz5tkZZ2/tkH/3yR3BXpSlZty1B+ WqE0bsd+ykQt5rl/d5hRT5QmZqud6j/ctRu0spNOf32/r7BAlFCM1J7nWH6ZzyqTvZa+ n8Gl3pQbEC+TAI4DvTOvU9yTeK3/hZ4mgCpqhFa2bRvJcmKLJpSS91//K4KA7O0TWbae v4Mw== X-Forwarded-Encrypted: i=1; AJvYcCVzwckam1SpbKn/JUZxKxEw4sDwdrQt09jbEbB9oeOVIJFzZMfWZGkc3Kl2bT+Pc+FOwnwpqEA=@dpdk.org X-Gm-Message-State: AOJu0YzVStfxHNB+aSYtTFwmVNt8gggSm+E/m/F2V2LV22Zk2bMWfR7s Z8K8rvooZTAtcVa74VErc0oPmPHH2bNEIPdHZCThnmUAZENe9FtYH7VgjFWTnE3OUw== X-Gm-Gg: ASbGncszkLbChIg60bKbV+wU2Xe9w6eVX6NGSochuDch4CEDR0v/YQflBsJWbfUproX zBphjxqQUoCRJpMucpSVRyVlUP+miToMJ14oBZuzi1DgTCfBFjb+fL4Wmx49nd1fOA8IIF5YDOC cL41/ifs0pAtXNHCK9rEFTHqFeiFV2WLElo5xDjCUeCp+xgX018sHTMibo/eEmMKXIrw9j58N7M p5PJ2/BrwJNQDm9HrZo/58AuE6AiQUTPRcL7hSXqTiI+VoR3Le6EHfOQonpraLCSSCGYZ6Tj97t +dEmhPdtoVKAahcVEpnaSA== X-Google-Smtp-Source: AGHT+IEJZmdlw3RsA6NkRb5wSXbr8FQ+GyCIZdslg7ggXhLKOT1OkKYUqp4Mh9ziN1jAK0MS1XowYQ== X-Received: by 2002:a05:600c:154c:b0:439:89d1:30dc with SMTP id 5b1f17b1804b1-43989d1328bmr33137835e9.10.1739812081452; Mon, 17 Feb 2025 09:08:01 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4398872fa85sm24750985e9.28.2025.02.17.09.08.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:08:00 -0800 (PST) From: luca.boccassi@gmail.com To: Dima Ruinskiy Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/e1000/base: fix unchecked return' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:04:29 +0000 Message-ID: <20250217170456.1068278-56-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/756391b7b282849f2b6fef7887399209f5391df9 Thanks. Luca Boccassi --- >From 756391b7b282849f2b6fef7887399209f5391df9 Mon Sep 17 00:00:00 2001 From: Dima Ruinskiy Date: Thu, 6 Feb 2025 16:08:46 +0000 Subject: [PATCH] net/e1000/base: fix unchecked return [ upstream commit b0b6b50c20b03170c83985194fd9acef9467ded6 ] Static analysis has detected a write that is not checked for errors, leading to ignored error return value. Add a check. Fixes: edcdb3c5f71b ("e1000/base: fix link flap on 82579") Signed-off-by: Dima Ruinskiy Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/e1000/base/e1000_ich8lan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c index 14f86b7bdc..f5f91a148c 100644 --- a/drivers/net/e1000/base/e1000_ich8lan.c +++ b/drivers/net/e1000/base/e1000_ich8lan.c @@ -962,6 +962,8 @@ s32 e1000_set_eee_pchlan(struct e1000_hw *hw) data &= ~I82579_LPI_100_PLL_SHUT; ret_val = e1000_write_emi_reg_locked(hw, I82579_LPI_PLL_SHUT, data); + if (ret_val) + goto release; } /* R/Clr IEEE MMD 3.1 bits 11:10 - Tx/Rx LPI Received */ -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:18.825721386 +0000 +++ 0056-net-e1000-base-fix-unchecked-return.patch 2025-02-17 16:13:16.854441592 +0000 @@ -1 +1 @@ -From b0b6b50c20b03170c83985194fd9acef9467ded6 Mon Sep 17 00:00:00 2001 +From 756391b7b282849f2b6fef7887399209f5391df9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b0b6b50c20b03170c83985194fd9acef9467ded6 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/e1000/base/e1000_ich8lan.c | 2 ++ + drivers/net/e1000/base/e1000_ich8lan.c | 2 ++ @@ -19 +20 @@ -diff --git a/drivers/net/intel/e1000/base/e1000_ich8lan.c b/drivers/net/intel/e1000/base/e1000_ich8lan.c +diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c @@ -21,2 +22,2 @@ ---- a/drivers/net/intel/e1000/base/e1000_ich8lan.c -+++ b/drivers/net/intel/e1000/base/e1000_ich8lan.c +--- a/drivers/net/e1000/base/e1000_ich8lan.c ++++ b/drivers/net/e1000/base/e1000_ich8lan.c