From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D619B4624E
for <public@inbox.dpdk.org>; Mon, 17 Feb 2025 18:08:35 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D0548400EF;
Mon, 17 Feb 2025 18:08:35 +0100 (CET)
Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com
[209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id 810D2400EF
for <stable@dpdk.org>; Mon, 17 Feb 2025 18:08:34 +0100 (CET)
Received: by mail-wm1-f49.google.com with SMTP id
5b1f17b1804b1-4395a06cf43so28543635e9.2
for <stable@dpdk.org>; Mon, 17 Feb 2025 09:08:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739812114; x=1740416914; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=JoUL0l0nwDdRdWU+d/KCTvEIVJbjgIcehhyvnuR0BSk=;
b=PR9D+ze7rYxaaa9rAEhFb4DyIoEY+gHR7bahxAMnoR0RxCGO92S1qfla77D+CrlqET
Ov1Ua5GvdJx3X9k/ZoJzymCMYAJwp45RDv36pCKBn/LMsHQh/N6Kq3aOrcufXRcenrmB
qwD4iuXxAsFgUMiPcDc7WkbWRPDze73eulY5JXPyD1XeX0m+iXyEy5s4jvpnivRTY0rF
DqVbW8JoAmkxCVZTI6ZD/Vklp5S5kT5D/ULEp5wpArIHYWesqFj8pQSDDohoLhefBRi7
lT4V4HZomUjy0lyP+cCg3t48/BAEsbbCiozDMEs8FL41TLNG8mln/7NoQRRB48WJTGF6
A4Vw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739812114; x=1740416914;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=JoUL0l0nwDdRdWU+d/KCTvEIVJbjgIcehhyvnuR0BSk=;
b=f7abXsuXftPovctRMza6DC4HrTAdoLc3Co5WSQsYFv6Hfe9ENZcJvHYLlp6Amp9Zw7
rgEiQi38RGqmihjgn+t4bg1Tkg77kyHfpE2M5FSwNfZdJFuMrtFfqgF5PdtX24rI/opR
TftiR9ZchHT/pmCL340+HgE1drAzwiGtpz5H3rGxHYwpUMnZwVaj+PTr2E11+lkkjVid
zGP8UtQDIGShQHomTFsypIxP+rMveNGK93H0/zvsc6CC44wvT8YNiOWWJxAJaRjY6aqI
frcE7Eh8sfI8tCPGTkq8r/cvbcIN9eqI3zMNdde0lWHlIyMGSarIODrY+KC3GMtVm+Rn
tcXQ==
X-Gm-Message-State: AOJu0Yx1bkiHe929Inzrnw1seTMrS4i3y6tUztjtfhLqR5lfVQ7i02jx
5TPRcYWpZPiPqxZRunY+J8r8f5ZRj3BMhDYffLa7Ly9dGc6u0fvtpS1keOtbVFbGJA==
X-Gm-Gg: ASbGnctDQnyFxoZstQ35ip34eclj2SUSiGSanbRZIuxblJuVxSRZYoh6xK6+S4vj5yo
aexFI/iT15cB/5Hg+k9fQ+BevwtfFDz+e9CzGmdPSW/HH/qdulMBRDUpe6CGGjoHWZvuJFGUdZZ
EQim8OA5MlaO1I8+VcU+tB1MmjKGBFOPHsut6snU6YnSjAZrng1Ea0CMHDiWMkN2LEsyRMPaUSW
tuvT+lv/Jy67xlqYLo9gGCRvHbsUSfKXVx/AVbmgCGFdnVxwgMeDbSO7R6GeFByb8nJ+BQTzHvA
Aqc/7wi012CDqmoeWLH1pg==
X-Google-Smtp-Source: AGHT+IGeSSe8BcEfMRpPrHr+U4EwHBfQz95q7s6IFRthUDzKF8B2ZHcXco6EQfNhhSx7k1tC7NgBrA==
X-Received: by 2002:a05:600c:3596:b0:439:4376:cc0 with SMTP id
5b1f17b1804b1-4396e765256mr69577825e9.25.1739812113961;
Mon, 17 Feb 2025 09:08:33 -0800 (PST)
Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997])
by smtp.gmail.com with UTF8SMTPSA id
5b1f17b1804b1-4395a1b84bcsm163541565e9.40.2025.02.17.09.08.33
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 17 Feb 2025 09:08:33 -0800 (PST)
From: luca.boccassi@gmail.com
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dpdk stable <stable@dpdk.org>
Subject: patch 'net/qede: fix debug messages array' has been queued to stable
release 22.11.8
Date: Mon, 17 Feb 2025 17:04:39 +0000
Message-ID: <20250217170456.1068278-66-luca.boccassi@gmail.com>
X-Mailer: git-send-email 2.47.2
In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com>
References: <20250217170456.1068278-1-luca.boccassi@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Hi,
FYI, your patch has been queued to stable release 22.11.8
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/595e23bf8b00621e8a5195b5b78f26be0d3d8128
Thanks.
Luca Boccassi
---
>From 595e23bf8b00621e8a5195b5b78f26be0d3d8128 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 5 Feb 2025 08:23:08 -0800
Subject: [PATCH] net/qede: fix debug messages array
[ upstream commit 60c68da0392e31ea4c163e0be8f1236a00cd350c ]
The array of debug status strings did not match possible enum
values. Add the missing element and a static assert to make sure
the table has all possible values.
For more complete description see.
Link: https://pvs-studio.com/en/blog/posts/cpp/1176/
Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/qede/qede_debug.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c
index 18f2d988fb..1d3147b724 100644
--- a/drivers/net/qede/qede_debug.c
+++ b/drivers/net/qede/qede_debug.c
@@ -4,6 +4,7 @@
* www.marvell.com
*/
+#include <assert.h>
#include <rte_common.h>
#include "base/bcm_osal.h"
#include "base/ecore.h"
@@ -82,6 +83,7 @@ static const char * const s_mem_group_names[] = {
"TM_MEM",
"TASK_CFC_MEM",
};
+static_assert(RTE_DIM(s_mem_group_names) == MEM_GROUPS_NUM, "memory group string mismatch");
/* Idle check conditions */
@@ -5614,6 +5616,8 @@ static const char * const s_status_str[] = {
/* DBG_STATUS_INVALID_FILTER_TRIGGER_DWORDS */
"The filter/trigger constraint dword offsets are not enabled for recording",
+ /* DBG_STATUS_NO_MATCHING_FRAMING_MODE */
+ "No matching frame mode",
/* DBG_STATUS_VFC_READ_ERROR */
"Error reading from VFC",
@@ -5759,6 +5763,7 @@ static const char * const s_status_str[] = {
/* DBG_STATUS_MISSING_TRIGGER_STATE_STORM */
"When triggering on Storm data, the Storm to trigger on must be specified"
};
+static_assert(RTE_DIM(s_status_str) == MAX_DBG_STATUS, "status string table mismatch");
/* Idle check severity names array */
static const char * const s_idle_chk_severity_str[] = {
--
2.47.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-02-17 16:13:19.161023377 +0000
+++ 0066-net-qede-fix-debug-messages-array.patch 2025-02-17 16:13:16.862441592 +0000
@@ -1 +1 @@
-From 60c68da0392e31ea4c163e0be8f1236a00cd350c Mon Sep 17 00:00:00 2001
+From 595e23bf8b00621e8a5195b5b78f26be0d3d8128 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 60c68da0392e31ea4c163e0be8f1236a00cd350c ]
+
@@ -14 +15,0 @@
-Cc: stable@dpdk.org