From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69FDC4624E for ; Mon, 17 Feb 2025 18:08:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60023402D5; Mon, 17 Feb 2025 18:08:57 +0100 (CET) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id A6D34402BC for ; Mon, 17 Feb 2025 18:08:55 +0100 (CET) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-439714a799aso20783335e9.2 for ; Mon, 17 Feb 2025 09:08:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812135; x=1740416935; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bsmMiUq2AChXr0le8wKolyLtdKIvRB5piS/q7WCR+r0=; b=iyClqCxBMXKShVbmaEIDHtyAQHAYzQ7KRCMPY4+c3ykS1koBe0xfQhfTsndaV58T/w 7YTOYWkG9q+HVW6LEymYOilQUTqlADqgz46eoNegEUQroDpaZikX8CgiKcG91dkkscI7 xlD2d5Abr3sDaq+iUh7QdgVxYQFQ4UAACw59um3jwX7R0dBKjqv4JiGqOEVOeM1GQ9t8 Lp6POZJM0OSdg8UlhhALDE9TONXkxTwoWskxPnLc4Ye72ATYSC4+hNS+cZi+iHdsN0x8 lkqC8vVnyp63Lka+TKcabAAcKRPoOW88yrceBGNr9Ydrmm04I9rHrD3z+xLOWf6gFf0Z WLfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812135; x=1740416935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bsmMiUq2AChXr0le8wKolyLtdKIvRB5piS/q7WCR+r0=; b=XjytYewN18XDSVoSUg9rulHblHpRtJAolBhAPtVUzrj67MXu8u6FvBCK+ACniRFrVD 1R7LGhuftLT0u1+xKnFTXUZPQYoc2EvIWkwvk7HiL1+LZxj94OQRv6i/jALraTOcNPM7 gKHFVc81+Z3QJ4M7aCnBF5VbI/Fo+ZUrXaVGVNe7iAZA4MQ/eFtjQQs+1TboCQCeE90l OiJf9q+ed87iHyuu9k+3B0T9AzzZkVQPS5dYY/3oYKfWWBUZkgnA7hiMI1QXL2OCZ4Ce 7cwFmDudWHFGFv+MwNRJ+MJF+PxuP7sM+UfQdCpEKueuu/JFiT2jo4U7HAGvQldJ/fOw A9mA== X-Gm-Message-State: AOJu0YyWbiCv5DaVLYN5uMZtAdB7s6irLrFzWnJMrfe7j80kiG5AQ5yv 0J/EVUCwfTYzMWR12ahXwT1CeRPaL15CLBSp4PkI3dlBWi7F0TCl X-Gm-Gg: ASbGncuEelX+e5SqTw3yV9tGtyU52AAYaNmpT5CA2gaD0dnIriAy9Hde9ULDJfsrBjo 487sh/0r18yihxYaFUThFsWdqroefk/FnaT8dp8MUtQqaVmO9BQ9R51yN1N8yf/X0xp9yaTtbca yRIzzU4oe05M2l0yC5us1pgMnrZVDpsSlBBq6W8marI7nkXUmjyKvICxzFnAN7g/LJJcJ7d39pD 3L/UiXv+BQMq4+glt3JaR1HkAHeHGcps00/XFOLNRKVhewmjUFKWFiNN7B+0oxXPmlw01oCA+0t ixqVNWOEGa6D2RBMCQKorQ== X-Google-Smtp-Source: AGHT+IGeKOjjDjpAkS14tqiFuGpXC5JLBvJ2APVNIqyKHQtO/9OrghxL6JOwOZb7NfgBOSRFuMtitw== X-Received: by 2002:a05:600c:4f0d:b0:439:9206:86d6 with SMTP id 5b1f17b1804b1-43992068903mr4785385e9.7.1739812135111; Mon, 17 Feb 2025 09:08:55 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4395a1aa779sm157416535e9.30.2025.02.17.09.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:08:54 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: dpdk stable Subject: patch 'net/qede: fix nested loops' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:04:47 +0000 Message-ID: <20250217170456.1068278-74-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/107c0c15493f52e529a139f0f7d0806fb7f439a6 Thanks. Luca Boccassi --- >From 107c0c15493f52e529a139f0f7d0806fb7f439a6 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 5 Feb 2025 08:23:18 -0800 Subject: [PATCH] net/qede: fix nested loops [ upstream commit c8b3833965dc84914e94776cadfc8fb48c34459b ] Using variable in outer loop, and inner loop is obvious bug. This bug is in base code, so likely on other platforms as well. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 81dba2b2ff61 ("net/qede/base: add LLDP support") Signed-off-by: Stephen Hemminger --- drivers/net/qede/base/ecore_dcbx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c index 31234f18cf..72bbedd65a 100644 --- a/drivers/net/qede/base/ecore_dcbx.c +++ b/drivers/net/qede/base/ecore_dcbx.c @@ -1363,7 +1363,7 @@ ecore_lldp_mib_update_event(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) struct ecore_dcbx_mib_meta_data data; enum _ecore_status_t rc = ECORE_SUCCESS; struct lldp_received_tlvs_s tlvs; - int i; + int i, j; for (i = 0; i < LLDP_MAX_LLDP_AGENTS; i++) { OSAL_MEM_ZERO(&data, sizeof(data)); @@ -1381,9 +1381,9 @@ ecore_lldp_mib_update_event(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) if (!tlvs.length) continue; - for (i = 0; i < MAX_TLV_BUFFER; i++) - tlvs.tlvs_buffer[i] = - OSAL_CPU_TO_BE32(tlvs.tlvs_buffer[i]); + for (j = 0; j < MAX_TLV_BUFFER; j++) + tlvs.tlvs_buffer[j] = + OSAL_CPU_TO_BE32(tlvs.tlvs_buffer[j]); OSAL_LLDP_RX_TLVS(p_hwfn, tlvs.tlvs_buffer, tlvs.length); } -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:19.433583861 +0000 +++ 0074-net-qede-fix-nested-loops.patch 2025-02-17 16:13:16.870441592 +0000 @@ -1 +1 @@ -From c8b3833965dc84914e94776cadfc8fb48c34459b Mon Sep 17 00:00:00 2001 +From 107c0c15493f52e529a139f0f7d0806fb7f439a6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c8b3833965dc84914e94776cadfc8fb48c34459b ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org