From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD29B4624E for ; Mon, 17 Feb 2025 18:09:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D911E402C6; Mon, 17 Feb 2025 18:09:10 +0100 (CET) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mails.dpdk.org (Postfix) with ESMTP id 9E600400EF for ; Mon, 17 Feb 2025 18:09:09 +0100 (CET) Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43690d4605dso28682385e9.0 for ; Mon, 17 Feb 2025 09:09:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812149; x=1740416949; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6eKnXu+CKR/gxhCY7Zb/61Lhoe5eq9vzBaizF3LAIQA=; b=AWpLiYNFDCAr7dgSqSI7i94oMZ4rKG30gbG1iS+a4G2Wp0oYPce3O0yol6C4mO4S/V vNtz/q0F8u1DVnPxsK1H8oHUaNjRpZbrnvOVr+Yz5D8WlFIYhDYoFOxx+Mk9ZFWKloj9 oaX7F13zO9Ev8cBMyd8kz7hcAzwsQT50CHSvojd32i/p04flvrbFHJLz+wGwh2CaRhvq OfojWQF9dKJVGWGOqg/jWiQvYt8ePVHWKYK8a+q040y59yD80NP1p/a7Wmxx0FjMXxC0 NPX/Gfu3hloMRWbxMmKECyFueJOYsu1KxYb35ex/aCdZB6FAqMyIXXYb2Z/k4j3q4LiG Srgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812149; x=1740416949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6eKnXu+CKR/gxhCY7Zb/61Lhoe5eq9vzBaizF3LAIQA=; b=o/xLXC+oewTC9LaJzqt3EUQZeiMSsNEMQD8Jo8IL4H2vsoqXcVh/k1RVLdcOT9u09S 2yDO9CS7SpaKN/VX1A3Uvq5K+WrRD2GdT8U+OJtBANvSwBCmLXLH7FaLa4k4nxzZAIPc fMlltnMTQo7zW7HGeD716vNVbVgnFJaiP/aeKFAcY3T/pN1Y6NXBXg5SFjaye2a/mYgA 1XKSOVnhQspESeQmzkNJusa2acIgojidHtIPLj6/L9deamQ6DrgCAE0VPpYcsGzR/gNk X3tpsDrzxbAHvQbknAFyb2jZxG5tc3bZ0rpg/KX9yD45WSzIh1Zx5VLqYRJQJFWDcbGW v2Yw== X-Gm-Message-State: AOJu0YyImmAZUGCi/u0tOyjghLMDZeEkV4iddO0YRgMtrlXTBYqp+/Tw TticDkYDv8q55bo8mlcugWF6//5TPHhixj0CpdgjjGjC5nxcnaY5ax+0cf+QuXuhqw== X-Gm-Gg: ASbGncsxVrMp7Le6iHNT2+xv4vZiuOvBY1HZcpudN41EvksrmmwZ7q8EGScln0D9ai1 nz2B8mB60BSlFbGVBlpq9irdE59LTuSIHf5OMIsRRlhj+C065XwGHbXzo+WdVHsJ/7JreFXp1oR K0Pf9ya+Hwqw9d4YLcWq4kRDN11Ba5R5G2V+FukJ7aZv199KZDHwGeRsf62wL6GrsK++JZzfptP rHtAxrxSxvzoZ5iTUjRDxyYAYNGN7bsrE0xTXc+GcgCRqKi39yMYcWW8EsPQ2G1vyC5FEngFWIv 8mw74ofjSk7XCVTCCgQAvA== X-Google-Smtp-Source: AGHT+IHFfmMtQ/w5eUSQloOSTJ7pLNpJXit7eambzd6TgERFtb+KkWqoUIfytevVjQjbOMokyhuNig== X-Received: by 2002:a05:600c:1c01:b0:439:5b36:b4e7 with SMTP id 5b1f17b1804b1-4396e6ead58mr81054835e9.9.1739812149170; Mon, 17 Feb 2025 09:09:09 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43984924201sm35135465e9.6.2025.02.17.09.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:09:08 -0800 (PST) From: luca.boccassi@gmail.com To: Ariel Otilibili Cc: dpdk stable Subject: patch 'eal/linux: remove useless assignments' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:04:50 +0000 Message-ID: <20250217170456.1068278-77-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/c4af10c4c2fd16b7a4f4347e31ea72d70028adfa Thanks. Luca Boccassi --- >From c4af10c4c2fd16b7a4f4347e31ea72d70028adfa Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Mon, 13 Jan 2025 18:19:20 +0100 Subject: [PATCH] eal/linux: remove useless assignments [ upstream commit 36128ec5d93591700b72f3fc01bfe6216eaee905 ] Found by static analysis: In dev_uev_socket_fd_create(), fd is assigned before a return, and not used. The same for the variables buf and i in dev_uev_parse(). Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle") Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Signed-off-by: Ariel Otilibili --- lib/eal/linux/eal_dev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c index c0ba98852b..0d9053b409 100644 --- a/lib/eal/linux/eal_dev.c +++ b/lib/eal/linux/eal_dev.c @@ -129,7 +129,6 @@ dev_uev_socket_fd_create(void) return 0; err: close(fd); - fd = -1; return ret; } @@ -165,8 +164,6 @@ dev_uev_parse(const char *buf, struct rte_dev_event *event, int length) * uevent from udev. */ if (!strncmp(buf, "libudev", 7)) { - buf += 7; - i += 7; return -1; } if (!strncmp(buf, "ACTION=", 7)) { -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:19.527436646 +0000 +++ 0077-eal-linux-remove-useless-assignments.patch 2025-02-17 16:13:16.874441592 +0000 @@ -1 +1 @@ -From 36128ec5d93591700b72f3fc01bfe6216eaee905 Mon Sep 17 00:00:00 2001 +From c4af10c4c2fd16b7a4f4347e31ea72d70028adfa Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 36128ec5d93591700b72f3fc01bfe6216eaee905 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index e63f24d108..be97f56424 100644 +index c0ba98852b..0d9053b409 100644