From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08CA74624E for ; Mon, 17 Feb 2025 18:09:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0414E402BB; Mon, 17 Feb 2025 18:09:12 +0100 (CET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id CC7E4402BB for ; Mon, 17 Feb 2025 18:09:10 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43932b9b09aso50501355e9.3 for ; Mon, 17 Feb 2025 09:09:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739812150; x=1740416950; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A9aS0QmU9Fe4LrD8R00HTZLMAT17UbNo2xTuww2BXLc=; b=EjqRIDzdpN5tnKssCTlKbrJaAhzmq+tuFF2MjMaQi2hz3E0LrhAPqXB0GWuUueSsjX pkOpHNJOajPDNLY3JvhuUMt76eDmDHmFCyM9BJ4z6N80+9VmycClok3ZXfPeo7I6FHmT 5WCNZWxm94jlt6ItFb53CDktghgZ9041e0WQo27AQ8gEsgv78CmyCC9hF0ENps5vJkgL BPVjXDyfQhFOchFTLhqFfGCRdwqn4/GJ63OybCJQ2xXW/KPi+PB19rRTLs77SrjBd/Z9 HK4Mim19+QQugCZzVeqx5jz27T0ADQUiAfwxKv9fTuXrhI9p16UZTqub66xWt357XgnB /SeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812150; x=1740416950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A9aS0QmU9Fe4LrD8R00HTZLMAT17UbNo2xTuww2BXLc=; b=lzQG9Yulv2JxPVhUw1wVE/L5w8iVKrW55O5iL6rMxKB+bpKwUg/oLxAS1xgITL/32s HT4GE6t1T741fdtpB5tacUuFkE1lzBd4gI+Pf+TvQNLdrGOTQJmhE3+WauYHPuRIxNWU SG53NuyqaYP/ZxvjCUzZnj4HGJrkXxKLfPwfoVip3cm4OqJ1budSYJHqSuiKAy7RSIy7 19F7mo9tBbj6khy/FXFb5DjDWhPC9LlFCYCuSJb2u3cqPUKvgO6L98zOA48TW+ET7XJa rxkF277/q7aZLJgIaBJZ2GP7aMbuFyqsAdlTevb7Z3wbW7aP2fwKTGPbIMwXXqRuAwn9 CrDw== X-Forwarded-Encrypted: i=1; AJvYcCXKy8nAmJUfWTrKRi2u54WhokXkRjJFOokFyc+HH0NNwjjZ44vBTnPw8/1/GmwiYY4yJosvnnU=@dpdk.org X-Gm-Message-State: AOJu0YyWN5F17+IJ459yj1tCqN6cwr3K9odFhpriP9zVClFgemmJiGI7 x7YnbENcc9Zffq3fEqjKt6db1thIxdBbzE/dZyf7kQ1fDi9kz2/B X-Gm-Gg: ASbGnctx4/KY0s4T+DofR/rZevw3fa38kwkoOpSOOxvLjWLW6T2jad5ZIROzPbGqSHm Wj+Lmpkgnz9XNC18/Qq4vp2HEwGLMuWasId1iQ3di1sYfXHnToiFLCaErv6PASFpk0feGrNn3aV Xy8hqSphqtERo5+LqrggNe4s5BIvv/VfPT2uoDV9Zo5IlcaQ3oiqnYZUJbTL+bn6GWOg0aJzl5b W7SHCJghI87RXaIn8vCotQqA/6s34IQ0GyUi8cA8hkvgetNHwIrAvjdd5YOGUL0YoD6r8My/vYn PYxfl4acfJMIRGSTXoMs0w== X-Google-Smtp-Source: AGHT+IElhcwFwA+mvaLXj3GYXZuytSkWLaFJNt74bHl7JEMlyoOa3kV8x1pdODAjyop6CCF5mfT8fA== X-Received: by 2002:a05:600d:8:b0:439:86c4:a8ec with SMTP id 5b1f17b1804b1-43986c4ac03mr41017935e9.15.1739812150372; Mon, 17 Feb 2025 09:09:10 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:f83c:95e7:29fd:a997]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4398ba53406sm17290715e9.14.2025.02.17.09.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 09:09:09 -0800 (PST) From: luca.boccassi@gmail.com To: Ariel Otilibili Cc: Chengwen Feng , Konstantin Ananyev , dpdk stable Subject: patch 'mempool: fix errno in empty create' has been queued to stable release 22.11.8 Date: Mon, 17 Feb 2025 17:04:51 +0000 Message-ID: <20250217170456.1068278-78-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217170456.1068278-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/5ed49f4417a6080b711a60ef5209bc5f4b3d9666 Thanks. Luca Boccassi --- >From 5ed49f4417a6080b711a60ef5209bc5f4b3d9666 Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Mon, 20 Jan 2025 13:21:55 +0100 Subject: [PATCH] mempool: fix errno in empty create [ upstream commit a81d8ceff4e961995c78df6dbc9353dbbfbd8c32 ] When returning from rte_mempool_set_ops_byname(), rte_errno is not set for error exits. The API requires rte_errno to be set in that case. Bugzilla ID: 1559 Fixes: c2c6b2f41305 ("mempool: fix default ops for an empty mempool") Signed-off-by: Ariel Otilibili Acked-by: Chengwen Feng Acked-by: Konstantin Ananyev --- lib/mempool/rte_mempool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index 258754cf67..9d9c91be2a 100644 --- a/lib/mempool/rte_mempool.c +++ b/lib/mempool/rte_mempool.c @@ -928,8 +928,10 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size, else ret = rte_mempool_set_ops_byname(mp, "ring_mp_mc", NULL); - if (ret) + if (ret) { + rte_errno = -ret; goto exit_unlock; + } /* * local_cache pointer is set even if cache_size is zero. -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-17 16:13:19.561126997 +0000 +++ 0078-mempool-fix-errno-in-empty-create.patch 2025-02-17 16:13:16.874441592 +0000 @@ -1 +1 @@ -From a81d8ceff4e961995c78df6dbc9353dbbfbd8c32 Mon Sep 17 00:00:00 2001 +From 5ed49f4417a6080b711a60ef5209bc5f4b3d9666 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a81d8ceff4e961995c78df6dbc9353dbbfbd8c32 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index d8e39e5c20..1e4f24783c 100644 +index 258754cf67..9d9c91be2a 100644