From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A61C04625C for ; Tue, 18 Feb 2025 13:39:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 926BA402A0; Tue, 18 Feb 2025 13:39:38 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2047.outbound.protection.outlook.com [40.107.244.47]) by mails.dpdk.org (Postfix) with ESMTP id 0787B402DF for ; Tue, 18 Feb 2025 13:39:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qRnhq0KQMIWIfoS3h/mHJouHkduWP+gw8jnEd5odjXdbLs9QJHYaCQNhXZHVJtL+LLz1LNGJNHkZ20Rc4kC7ojyAMAFOQRBPDq2Z4TZ87+7VDIMh5yUv8aTwZDXN1VIS1tT2UmIxwySHkS6hdJPSQ8CobYL5UE/n1dWe/JtFGQn+qd0abRMkNDG/WXKpbIONgZjaMQnL0bWbSJJEneoE7YVcsVPhgKSMTPND+txzQWKm8Ud9FPzXsyP2qQ6HAS5a47ANuRovP1e0iaCglg8j8kBnd97QDoancaHjx7bjzt0JMYHoHQoIX7Ef2GXde9oWDzTe4Sa3lP4FOmkvC/nMiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FpbyLuT3E/6Ws0yXg2+z4g3XdzgqjzwmytnTYNdrjKE=; b=VWKjH59xYLO0Q7EVawPABRI9TI2RXeDkD96b3rOtwhjJ74fctWakUFVXqb7uHpGH7x6jbZSKheLpV2hFr9wxp9FWp7JWmhs5oL2JBDj2ItwsEHYzSaZJl6XzzFTflecXENUt+ZpkrncC5Dj1t1EIndxqxcrLLJOJDntNpS8p+pZHR71p+doKNP6RgDUrUBf3mkxHB0zztVI5CSmcuPH/JT6i7bNaoOjp+NkVh/lwLEfyJfuvPG/HLym418mgQmtKQvy01eH+fi19WhNaXBu+YMNR7ORrUvI3eXfFvq7aY+T7A5ZEdFDk4pMei1u8TTO1rxoO0LtrP9F7ON/ExI57EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FpbyLuT3E/6Ws0yXg2+z4g3XdzgqjzwmytnTYNdrjKE=; b=tycj2aBJt/8VhXt+KdAvB1Q82QOr3YN4Fjg5Hei4Bb2gAkbejnToA5obyITscNDt6YBXec6CGhRuRP4nOuGLUKC9r8Z5fkX6q8TQT//rLj+IhXATxYYKtTFA+cLbPCzqh+pVZ94s1yUxi6SaO3dqTdM52RJMgPp3g+/TsZ8aeuRoWRT0GctosvlM3YoKAJDJUtKDqd5ZRTug0B4oh1GdT/oM1Zs02/HeyF7b+zr9fnmle6cfoyeTBIQYrzhf5YzJuHVl8etuP3YYSHTUa930TWg4hwPDko3Oq8pOreq2sCu0T4w5s2S6H6aXSsYuAmsJ7LVG7o9UC4v4aNwdTx1VYg== Received: from BL1PR13CA0074.namprd13.prod.outlook.com (2603:10b6:208:2b8::19) by IA0PR12MB8713.namprd12.prod.outlook.com (2603:10b6:208:48e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.14; Tue, 18 Feb 2025 12:39:34 +0000 Received: from BN3PEPF0000B06A.namprd21.prod.outlook.com (2603:10b6:208:2b8:cafe::9d) by BL1PR13CA0074.outlook.office365.com (2603:10b6:208:2b8::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:39:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN3PEPF0000B06A.mail.protection.outlook.com (10.167.243.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.2 via Frontend Transport; Tue, 18 Feb 2025 12:39:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:39:22 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:39:20 -0800 From: Xueming Li To: Stephen Hemminger CC: , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , dpdk stable Subject: patch 'build: force GCC 15 to initialize padding bits' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:34:33 +0800 Message-ID: <20250218123523.36836-39-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B06A:EE_|IA0PR12MB8713:EE_ X-MS-Office365-Filtering-Correlation-Id: ad5c4c0c-4da6-4da3-774e-08dd50194c33 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|36860700013|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WFhmZmtvTzdJRkZ3a0wwWThWdjltdEhMa3A0V3VuSGt0c1ZZTlBnVWQ2Q3RS?= =?utf-8?B?b09QeGpOcGtqOHdwSHE4V3JxTG5ObUJ0dUVDdmhudkVZbEpidEJtQXZDNGRy?= =?utf-8?B?dmRXaUVHUUh4Y242TWpSNkc5NFZBVGJwVTVxbFRHaElmL0dkRFpsbktCYlVs?= =?utf-8?B?dVlzVndLSlRqZWpNcG1uek5hZmVyUDMzQkovQitjZ3JsUjMyeGE3RWw5aGpY?= =?utf-8?B?bkI4RlFjU2pPbjV5MlV1a1dhTFB3V1RvNUZoVkxMU1J1c3c4Z0I1d25CcWpE?= =?utf-8?B?RnlZYjhzTmFrMmV4QkpYd294L3ZuRkZlTExiVmpLYmNSVDFocVdMMTJzWldw?= =?utf-8?B?SGhUQUxKZldacGpyMjJldytIZFpLRmJYSktrTGhLUlVraFlPTHhMNFFIS0kx?= =?utf-8?B?MGpFQUdSYmVNVVRiT1ZqM2FxejNwcTh0T2FBV0dtVTVhZWFyN01CT1pZNnB4?= =?utf-8?B?WFdma3BMRzJXb290U3Nja1dUN1BKSU0weHlHWE4wcnc2RXFyRGdGZEJWYnJZ?= =?utf-8?B?MThORzZCT3VFNnFabjVtUmFNNzlTam83ZDNtbkxORVNKM2tMdXgxblBnakt5?= =?utf-8?B?VU9jd0YyYStuRDBrMXQ4blBuNm94NWNkeDdMUVZtZ0VUTXNYSGh3eTJiaGVl?= =?utf-8?B?N2hrMm5uMjdQOStyTHJubjJjWWRNS0xMU3QvdGRQMjJMWVl2bmNJK0RXVUV2?= =?utf-8?B?WFZrdllhMElYVHZUWGFBMEV6cnNlUURxclQwQnJ1Uk13b2RSWlY3NlppWFcr?= =?utf-8?B?eXE2SFoxcjBVbXdWOUJoQ21qTWY3cGI0SHE3cWxQU1RRd21QazhqVXhFVGFE?= =?utf-8?B?ZWVNSStoUnNrRDJ1MmpHQjhQT2F0ODhZQm8rNXE5L1Vhdm9GVE1HaTVIVHI0?= =?utf-8?B?QjhrbC9WTkZZVy9qWC9CNHhXeWQ1OFBpRDFlbkk3TlplY3VQS3ZQanZCTDZK?= =?utf-8?B?MVFRTlRUZlZxcEQ5TDkveDdOVmMxeDNmdmFDREptMGx3MDgxdHZaTlNIUFlM?= =?utf-8?B?aVZZUkc1Z2FsWHlKTzJNK1ZrYXZDRkp5QWUxczAwNjZITjVjYjJ5djljREJz?= =?utf-8?B?Y1dZWXdvM3BKdTh0ZEdYVG1ndit5V2NIQnljMHovSkVGWmVIZHc1cUJhM09Y?= =?utf-8?B?cXY3VEg2UndPVEF2eUxaUUVNSkp4UFgwY3JsYS9haFBIc0pMQ0NndEpsemFK?= =?utf-8?B?Nm9VcXpBMlBOanVLcGQ0dnd4YjlSWlFFNVprSjgrbGErTUVGWm9JZlV3SjNY?= =?utf-8?B?aTRHV3JGTHcrQ1pjZEw5ZlNEc1NHZzNZN0RMaEw2K3pQYmdWZ1hmRG13ZnN3?= =?utf-8?B?OHN1NEZiUUpic2ZWZ01iVXZvZU5iYXN4VVI5TUVFSC9jR3djN0pUb3Z2QWxT?= =?utf-8?B?R2gwbkMwanpqWHJPM1E4UFBKMlJBZVJ5dnBkS0R2a1VFV21ic3J5TWRvMHMr?= =?utf-8?B?UVk3VkdXcUlHMXlEdThCTjRxQlM0ZysvdjNNT292dkJZdDZHY0Jxb3N6dVFy?= =?utf-8?B?K1NEU2NubjlZc2duaEVEVmJEL0loY2tKOC90NVl6dVp2VVd2K3V6ZlUrNVoy?= =?utf-8?B?RHBFTVgwQlhUWnVuRHg5dzNlUnVEalVxamhaVEUzejh2Um1EU2dIRWR1cTg0?= =?utf-8?B?cnoxUm1sVXZhTzFEaEgwZmNpVEI0R2ZSYVFsdCtPWGlEVUFkdlVmZG4vT3M5?= =?utf-8?B?RmFIVCtHWEdBaG9wQkhFRGxnZjNoMkVFK0IxZ0ZpZUVqWUtuaGZ3VGhaRGJF?= =?utf-8?B?WU85dkZpalpOL3MxVlNUaGZ1Vmc1dmJnZm1lTnVHK2NENU52RjZxSnhXc1FM?= =?utf-8?B?VndLU3hiUjcxdmp2QThyK0piNG1tcHgxaENlZ05MVzFEL2JsT1J2SGhkTlE4?= =?utf-8?B?S0hzYUp0cHBQZ043L1ZsdWp5bmdCSGd6TWxsM1Z4WlBrWWRPSCtZcW12bFFn?= =?utf-8?B?eVhRQmVtLzZCZUcvVitEY09NUE8rQm4wZU9seS81anZxZHlONVVXbEsxcGpF?= =?utf-8?Q?va85MoLW8qbqoFaWTUsP1RiDwh5Jfo=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:39:33.7292 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad5c4c0c-4da6-4da3-774e-08dd50194c33 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B06A.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8713 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=9fa42e1aec84ff057805160f38ee1537e74608b0 Thanks. Xueming Li --- >From 9fa42e1aec84ff057805160f38ee1537e74608b0 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 24 Jan 2025 10:26:48 -0800 Subject: [PATCH] build: force GCC 15 to initialize padding bits MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 3c015da37afecbeaa7c9ebf8cf2adcb20ab0e54d ] With GCC 15, the compiler has changed the default behavior when initialization is used for aggregate variables. The new default is to follow the standard (C23) and not initialize everything by default. This breaks assumptions in some drivers and can be lead to other bugs. Use the new zero initialization flag to force of all fields to zero. Note: other compilers always initialize to zero in these cases. Only GCC seems to have decided to start initializing less as a silly attempt at optimization. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- config/meson.build | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/config/meson.build b/config/meson.build index 898b719929..394d612924 100644 --- a/config/meson.build +++ b/config/meson.build @@ -303,7 +303,7 @@ endif # enable extra warnings and disable any unwanted warnings # -Wall is added by default at warning level 1, and -Wextra # at warning level 2 (DPDK default) -warning_flags = [ +global_cflags = [ # additional warnings in alphabetical order '-Wcast-qual', '-Wdeprecated', @@ -324,22 +324,25 @@ warning_flags = [ '-Wno-address-of-packed-member', '-Wno-packed-not-aligned', '-Wno-missing-field-initializers', + + # guarantee that all non-initialized parts of structure/union are zero + '-fzero-init-padding-bits=all', ] if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') # FIXME: Bugzilla 396 - warning_flags += '-Wno-zero-length-bounds' + global_cflags += '-Wno-zero-length-bounds' endif if not dpdk_conf.get('RTE_ARCH_64') # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!! - warning_flags += '-Wno-pointer-to-int-cast' + global_cflags += '-Wno-pointer-to-int-cast' endif if cc.get_id() == 'intel' warning_ids = [181, 188, 2203, 2279, 2557, 3179, 3656] foreach i:warning_ids - warning_flags += '-diag-disable=@0@'.format(i) + global_cflags += '-diag-disable=@0@'.format(i) endforeach endif -foreach arg: warning_flags +foreach arg: global_cflags if cc.has_argument(arg) add_project_arguments(arg, language: 'c') endif -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:02.089365896 +0800 +++ 0038-build-force-GCC-15-to-initialize-padding-bits.patch 2025-02-18 19:39:00.548244061 +0800 @@ -1 +1 @@ -From 3c015da37afecbeaa7c9ebf8cf2adcb20ab0e54d Mon Sep 17 00:00:00 2001 +From 9fa42e1aec84ff057805160f38ee1537e74608b0 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 3c015da37afecbeaa7c9ebf8cf2adcb20ab0e54d ] @@ -20,2 +22,0 @@ -Cc: stable@dpdk.org - @@ -26,2 +27,2 @@ - config/meson.build | 11 +++++++---- - 1 file changed, 7 insertions(+), 4 deletions(-) + config/meson.build | 13 ++++++++----- + 1 file changed, 8 insertions(+), 5 deletions(-) @@ -30 +31 @@ -index 710206095b..f31fef216c 100644 +index 898b719929..394d612924 100644 @@ -33 +34 @@ -@@ -310,7 +310,7 @@ endif +@@ -303,7 +303,7 @@ endif @@ -42,2 +43,2 @@ -@@ -330,16 +330,19 @@ warning_flags = [ - # globally disabled warnings +@@ -324,22 +324,25 @@ warning_flags = [ + '-Wno-address-of-packed-member', @@ -50 +51,5 @@ - + if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') + # FIXME: Bugzilla 396 +- warning_flags += '-Wno-zero-length-bounds' ++ global_cflags += '-Wno-zero-length-bounds' + endif @@ -63,5 +67,0 @@ - -@@ -351,7 +354,7 @@ if cc.has_argument('-Wvla') - endif - endif -