From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38C5F4625C for ; Tue, 18 Feb 2025 13:36:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32E15402E1; Tue, 18 Feb 2025 13:36:18 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2078.outbound.protection.outlook.com [40.107.94.78]) by mails.dpdk.org (Postfix) with ESMTP id C5FDA402A0 for ; Tue, 18 Feb 2025 13:36:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KMOPGyH/VmBKfvNxJqj7zfhEkCgUfxncCnWjKHZNAxPccXo0Q2hzT4zF7u5uJzbId5rYXB69tZ31bMjiWaW/fp//g9AH539qxYaG6zQTu73043dn9ZFgXuEhubOACLI4p6qwEvJXR8UvfZEmkA0tCRPPHZDCmPGMfYdU3AyZ0merAh6sZfAkoaMQU7+IPiMYWujk85W9NyT50HB3C1vgf/L41GtxGEZ1eKeyYzTq53Lr+CcR1wBRQv55AnpX4Y/+Z8g3Cu1jjUGPgtYp1zwhg6pTZ+uGMv5Tlqdwkj71RqSSIwicvCazN3ygK8/6oo6Q2jPlljUH/JDlTIpmDxCIhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X4PZJrxcTByw6DlBVdnRnOfhXZ7mFsy4IEz+a0v6xwM=; b=qcugbTGZJRJy59nxY60X/NoS4lhvAo+zLMroTFhnOMKO7gF9JgeldvyHorxQUgy94NwSL5PypRqEJPwHitFyVnbx29AeWQchU0KIAFYIamC/GCbQyvnWHu4jmD+s3HuGFK2qBWvF/h5wheuUp1sUye0j2jP84TFTwail589m05j88OFj7F7nliVMVsvRLp2jiVbZEIJtEm8abH8xTGZphuY8rWmjS6O1vkAKGkiRQa8Wa8EoW5ma8kt7DCqoZXcYFvNjKvryv86O66t/B/ynhrTexIFpmIjeTE6pwiUAcaUlNQ2+Th0dWz5ZKybwLHcDzv9GZkVrqzrmsoEdiNrp6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X4PZJrxcTByw6DlBVdnRnOfhXZ7mFsy4IEz+a0v6xwM=; b=TJtdD+FQ/RISFshp8HUR/8zsjnLXLOJJ3dHEpIbCeJogBID6KM5WV9p+zIEXoGV6+iahLbYeAAwOgdPCySXDQLbMB0Q/I8xhz+HBx2PUD1kiJeH/ZDBKe699Jlw99VmbbXxlUVkL3me+T91HyJlkK9KLS38sXrIbKGYUMPUeeqfbTHsdFtNAtynKOvhk7fq29uM6dlIhP9s5VzWapITP6ZKV2dZfOj2oehiSwpXYJp7gasi1xRjYAEmoSl8SfGbd9qoc+Qi5QjXoYZd8H6XU0sHQgc0gKiu9DcNeShGVOhzX4vcbAUjcEwQjOoF3Et0oRqR5FFHY5xBaW12/PhKIhQ== Received: from BN9PR03CA0248.namprd03.prod.outlook.com (2603:10b6:408:ff::13) by MW4PR12MB5626.namprd12.prod.outlook.com (2603:10b6:303:169::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.16; Tue, 18 Feb 2025 12:36:13 +0000 Received: from BN3PEPF0000B069.namprd21.prod.outlook.com (2603:10b6:408:ff:cafe::7e) by BN9PR03CA0248.outlook.office365.com (2603:10b6:408:ff::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.19 via Frontend Transport; Tue, 18 Feb 2025 12:36:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN3PEPF0000B069.mail.protection.outlook.com (10.167.243.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.2 via Frontend Transport; Tue, 18 Feb 2025 12:36:12 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:35:57 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:35:55 -0800 From: Xueming Li To: Yunjian Wang CC: , Maxime Coquelin , "dpdk stable" Subject: patch 'vhost: check GSO size validity' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:33:58 +0800 Message-ID: <20250218123523.36836-4-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B069:EE_|MW4PR12MB5626:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f2d1efa-9817-43ee-bd1d-08dd5018d469 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|376014|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VANMdxJ7MxrhCGKJlJ3RBC5hNonfjFl6zMTh4k8OAXTOyB5aeC6sVZqCZWpe?= =?us-ascii?Q?cIrBzSbl1sxmw4Lg8HNspKaSfAeucXgmJtEhONhAFw0TY6n/FxSdyVmk9CDt?= =?us-ascii?Q?EoPcmlkuNbDhEcXezBghNMAmtmz0C3WYneigFE3z7N6DwelPNfn5v00hTG30?= =?us-ascii?Q?1kINqHw56Opw/eQiEkVHRO7oe0yyM0/R7346rniBlmrDjvcJlLfrNWAvpEeA?= =?us-ascii?Q?77a1FaycP71WCX6ZL2du0p+BHtiscugf0QkEC2nAvSU2+BG79ovUK3JkAkZ1?= =?us-ascii?Q?GgpeSEb9+IaM64bdttzd6tw/2m/vzYU0J4vEroSRJR6SUZg4ZHTla27SzIs3?= =?us-ascii?Q?SrJyUH1mTTVWEzVF561lFfZCGlbSGuVZsBvPJsg/RgXrVR4KtP3Gnj5evEy1?= =?us-ascii?Q?BUkYr39oYpfzLoAOstN7z2P9YXMSYXumz24uzqIti/ZYenKhsq2WVe7VdJ5A?= =?us-ascii?Q?J+0VHph1KzGooWsaDCzDbXeeBUHYOmvKHOIe9OADLtmsJ+fuLKkkCNK0mMX/?= =?us-ascii?Q?KzvezGaJO9lK0Hf3U8WFZZwjuHX1h8u4CgWQjDgoRXYcHyCnUoYlRLyJ0+dv?= =?us-ascii?Q?TbII9mhmIZ/tp9cqztyH+9ZET55+z4y2dDXqELTDngzX0yJGLN0A6d9tkF10?= =?us-ascii?Q?TvIRA51J8UBqOjBHz/zouk3BP3kBI91Jx9IrbLKWw2palDJe3VF0tWSEkknr?= =?us-ascii?Q?68Hug9M3lEy80heOVPxNtFyIKWaFif3UWDyUMkIzz+/eSOkcu2IMEEtjCam/?= =?us-ascii?Q?ZMqSKPxdiYITzMhOvpj60KlN55DrAoHcHZALXSjiic4XSMHXBv0D8UwA3+00?= =?us-ascii?Q?9bp8Kfho0O8ZMbyyRofvfmSeoPqk8TnAAq8NSyv9/zUAhLpJ4GxQCu0N9+2w?= =?us-ascii?Q?LhdoTNYGvHKR+tiD7Qcgk7asris0HWUJNRQ/K22YOMyQeZbQj/Msxr/fWDY0?= =?us-ascii?Q?23XH1pjI4Q/5M1grc6Xw9dLSsHZsPJejnwPqHFjS1mg29+qp9xfFqnYNxeNx?= =?us-ascii?Q?6R6sQFrc4dAkJFKgLF4lQByyVQ8tx1auV2WF3sanB9JO35zz+ELB4PKy9356?= =?us-ascii?Q?PNvpCHikSTLvTXtp4v/uhPCHcvJqXaaAeYKB5xTwplCj9rlZZKrxyp3s7VSi?= =?us-ascii?Q?rAxWX+K+2jAefseiWTUKfwoOvAI69g8JIxgB7Y0poOlPRw1Q9dXfHITUjbnf?= =?us-ascii?Q?30FWvigsC/zCzPVyNuag7NcTn1LtXBJ1ATovZrtYT6YA9B67XACeU9IymNhh?= =?us-ascii?Q?qtdb19Do7kN1CCnfvNZWnu3EUDzxIcDnoCT7VWUX0lxcjDHM2hEuihLFqUCI?= =?us-ascii?Q?F7nQD8Jo8YGNbvTPDUFXIfUx9ritJ+sc3j+AZ+cTN1Nwe67UN9HqdGFRZpuY?= =?us-ascii?Q?pqEzJfPZefJlI6u+a0pBZ9RZFQ5SSK+4DD400vIKVPZkfWaK/NxMzO6aCmZW?= =?us-ascii?Q?1MWTH3+kXgXMkXpLY8/u2b7iEXuEkQf5TP+kHK1Onuenz7mj3wnRvi4zdP/u?= =?us-ascii?Q?mUxDCjuQVUENqIU=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:36:12.7583 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f2d1efa-9817-43ee-bd1d-08dd5018d469 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B069.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5626 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=6bce3ec356d70103851656c31ed61244fc3cc346 Thanks. Xueming Li --- >From 6bce3ec356d70103851656c31ed61244fc3cc346 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 20 Dec 2024 11:45:09 +0800 Subject: [PATCH] vhost: check GSO size validity Cc: Xueming Li [ upstream commit 7023f3e532787eec7be674efb7a4aa54f1626b6c ] The value of tso_segsz cannot be 0, instead check that value of gso_size was set. Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities") Signed-off-by: Yunjian Wang Reviewed-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 49c2052eba..25adf94ffa 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -2741,6 +2741,9 @@ vhost_dequeue_offload_legacy(struct virtio_net *dev, struct virtio_net_hdr *hdr, } if (hdr->gso_type != VIRTIO_NET_HDR_GSO_NONE) { + if (hdr->gso_size == 0) + goto error; + switch (hdr->gso_type & ~VIRTIO_NET_HDR_GSO_ECN) { case VIRTIO_NET_HDR_GSO_TCPV4: case VIRTIO_NET_HDR_GSO_TCPV6: -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:00.869052706 +0800 +++ 0003-vhost-check-GSO-size-validity.patch 2025-02-18 19:39:00.398244087 +0800 @@ -1 +1 @@ -From 7023f3e532787eec7be674efb7a4aa54f1626b6c Mon Sep 17 00:00:00 2001 +From 6bce3ec356d70103851656c31ed61244fc3cc346 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 7023f3e532787eec7be674efb7a4aa54f1626b6c ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 69901ab3b5..2ac5bc29a3 100644 +index 49c2052eba..25adf94ffa 100644 @@ -22 +24 @@ -@@ -2733,6 +2733,9 @@ vhost_dequeue_offload_legacy(struct virtio_net *dev, struct virtio_net_hdr *hdr, +@@ -2741,6 +2741,9 @@ vhost_dequeue_offload_legacy(struct virtio_net *dev, struct virtio_net_hdr *hdr,