From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B91DD4625C for ; Tue, 18 Feb 2025 13:40:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B070A402A0; Tue, 18 Feb 2025 13:40:31 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2056.outbound.protection.outlook.com [40.107.93.56]) by mails.dpdk.org (Postfix) with ESMTP id 3B5E8402A0 for ; Tue, 18 Feb 2025 13:40:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MHsu8wCQHhpsOY2IzbdZwbGnH7iXdzFm1QJqA5ehAsL8hxpyBM/0i1CY6aEYLpV7q+rdeKOkUIXfrXbuRnZEyipznI25M/iJ/0eJnebktHZeWCZT9tIeiQG5raFDQPEukENlw6haGUsEEMbs7ntbGz/oydofpSFPJeFHXCqppJ3/ZSanmjzgyhZ8UfMeW4uvHpOpFPjCphUiDIzcW77E8wcY2T236lyOmlmGKbCWKCyY0iZ55vLJQmHzL85vQmFTQaksEELAO69zCkEE9oAiP79iyALhDlqSRGDfxqZeuTQo6H/9zMxcFJKG3zlDBxgvI1PgKRL2x5uoy3xG+fBsjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E39nmefUbW4T52izMprGnLeLJgwolffcvQ6UqL3hxFs=; b=sEdXVEzcNPAwdagsgCz33ngzHK0AH+k8HSp45EaNsBuplVRp0npLYODuxuOhkMjJwrU7jICwGd9S7j3PUQ5NZz2LawZzmqn+ZOOrl//p4Jl/CLwH1RgGc5ZjG8w06HETcxEqOp6K6/YJINLmSCEAjw14mL92PHPIcjQNv4hfN6sJBI9xxdyK+V/q/Q8vtM3vlQiUxjn81j9CnEVqqtrwa6Wl5rL0MKc6+8vbKRNa73V+PdyI+/xBssBjkI8RGibGESV9AKz9cRwsKMgNL99IqEUp2TvK9gXTbIuSjxHbnYpOwhpWf22YLV2+cxcQHsPVoIoauJ0YtQ6usUJMh1ePvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E39nmefUbW4T52izMprGnLeLJgwolffcvQ6UqL3hxFs=; b=swjl3uXoAri6vOW6Zu1iwLypbCitdCOhQgoAG4GiWl3i1+/xwVoeevPoMnP+Lxd7plrph+RVVgXnMxpmA4Urv5+m/bfuI4YEvuPOwc444TAgvX0J83up+q7TNLgV5DeJ7q98qI+7jWdjBTmP0e2r+ORph0T2pZJ9lsTlejz6V/diyE6AglJdETPw5Ai9PCWqP4t3CL0uH30l7Wiw6z0f4+Az17AVSTQIAnyckGLxHbPyPM2xazaIMaqFfsMZeEw+D8MeE/oenCrDsZjnv27KEMne/uIWh+bAUcxy3phhua8N3UCgxlpEyjmyhNuHTqaGovKP+KcujivyR5M1htbd0g== Received: from BYAPR08CA0042.namprd08.prod.outlook.com (2603:10b6:a03:117::19) by PH7PR12MB7842.namprd12.prod.outlook.com (2603:10b6:510:27a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.18; Tue, 18 Feb 2025 12:40:26 +0000 Received: from SJ1PEPF00002327.namprd03.prod.outlook.com (2603:10b6:a03:117:cafe::5) by BYAPR08CA0042.outlook.office365.com (2603:10b6:a03:117::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.16 via Frontend Transport; Tue, 18 Feb 2025 12:40:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00002327.mail.protection.outlook.com (10.167.242.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:40:26 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:40:15 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:40:13 -0800 From: Xueming Li To: Dima Ruinskiy CC: , Anatoly Burakov , "Bruce Richardson" , dpdk stable Subject: patch 'net/igc/base: fix infinite loop' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:34:41 +0800 Message-ID: <20250218123523.36836-47-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002327:EE_|PH7PR12MB7842:EE_ X-MS-Office365-Filtering-Correlation-Id: 1124fab1-2e5b-45f6-0b36-08dd50196b65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?3WC8LS/URaWsfVPEhYgXeS306kUl865/Wbf8wGPZth4QehOXb+2urgC3bYbh?= =?us-ascii?Q?nDPrCOL2clA3C6oxfrUsrMV9DSVLsd6u3CN1tZgW57n9S8Z4abUNzpiHOB47?= =?us-ascii?Q?urm+leTUJLrsNyVswkPZnEyaLzPaa4Zlgw+MWaP6nIHVlLd/yTg8t9C+BNr4?= =?us-ascii?Q?YQ/8C3Du+z+1xhpBXz8DMfHBCX9Axcn5MbzjdARmc7Nfy3nqoRodcdEC5N2K?= =?us-ascii?Q?I//UnYh/4oi3JGjIgBmnzLZUlSE2QZUPeA1/jo+IR8STl5nX7lH3vHi4KWLS?= =?us-ascii?Q?bGEKk7zJfYXUAwjcX6NoKj/orcReMDdt+4ngO2FC1Ltgr2blKCo7AcYM79Iz?= =?us-ascii?Q?kd0D1lI2DzeDLyBiW24E5YvMPspsv0xpr4h3OmOAgzRiXxF/vU/4YR7rKWEy?= =?us-ascii?Q?umduM/gEEHqPPm6He8HfMR31v1F1P6r6F3lmEg9EkdR9zjXKqZ1rESUvgOQS?= =?us-ascii?Q?RrG3XS5N7oiExoh8/ORKg0+ibOCypYWBnBoQb1DsAWCipJieFDJvdDIiL9CY?= =?us-ascii?Q?M/TGhKYdEOEQpBY1sfGDuTYQU7WzkD31sXpGfAGBD9JRJ4W3M6AL9ZCmepr7?= =?us-ascii?Q?qqWzJfmLjQNJscOnnmCOD2p6tJnEHkgtbVYI3DBRywhH0Ozzhzr37+ttohzx?= =?us-ascii?Q?5+dWalq1P3iNb4BawpHar22CzNSJHxfJnL2IkvKuGYniZkNehK7R15/Nh5nT?= =?us-ascii?Q?RCfV2TdmzQkbmrMWXVAV2z6Uf21U5Ft4V79QADe3GZrvzzKzEHvlzuf4GwhT?= =?us-ascii?Q?H2jSGcIjnWnHg0bgo3A58EFofwFu/GqpGDsSa8U03XiVTSeRvKSbcUoRiC3X?= =?us-ascii?Q?MR3wCLwSFFunuCbfwXwcZ7VpN3LmE1dEdJHF3OZaSGF5SkZgDBzwWzXCME9f?= =?us-ascii?Q?+qQbNpxEtscDzU9iWt069YLA+ZwmIyKmDEbOQPVE6cALFAcZc1c4ywIsA/vy?= =?us-ascii?Q?T2jljEp0J6NHw9xkbV96TvRJRDiVw7vklec5k6GEnjBUfCzQTHJvkOLHJN9c?= =?us-ascii?Q?ohl/EsrRT21d+uZ7KULqVm1deIGrAE/BKpinLB19mwYfHlNICgaSXZIAjkN/?= =?us-ascii?Q?uQgEZQ7AtlOPQiafpybG1MT1D8cP8e2KILcQ6vsaXbT2UR2kC43r/XTWBn+o?= =?us-ascii?Q?15/h9kwD7sHvnnaoCrGedBtoVL5owJBfNAaVi8j/jOuRkTxdJDRuJMJGJiX4?= =?us-ascii?Q?r8TTkSIWsem2mNpAaLue5HOC7EoYQym1Ku+HB+VAsnhg0ak7xCmRbYwmFG1W?= =?us-ascii?Q?LKfn5E6cqrgDoj04CkIQDSkn2nG+ajm0JF/aCUJN1YoOH4JwZAg3/c9yf0HI?= =?us-ascii?Q?U4NVwGdy8Fv5GUEIvEyx7N8WWX4hlyxegPkI2kd65sUEipvyFSpRpXiW7No/?= =?us-ascii?Q?W+FV541MwKdVtOhIMAptxb4UiinzBeHnmLcc1hcarUNpsc4pznyaewJUy9lq?= =?us-ascii?Q?qa8ohO5OhtfNDediktOID7pgBN4N3K7majci80wOu96/5HWp5pYDz+aecVNz?= =?us-ascii?Q?jrLl70tytXgi2vo=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:40:26.2510 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1124fab1-2e5b-45f6-0b36-08dd50196b65 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002327.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7842 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=5509313e7a3a1f7649f9ea6e4b0f03023c221e02 Thanks. Xueming Li --- >From 5509313e7a3a1f7649f9ea6e4b0f03023c221e02 Mon Sep 17 00:00:00 2001 From: Dima Ruinskiy Date: Thu, 6 Feb 2025 16:08:25 +0000 Subject: [PATCH] net/igc/base: fix infinite loop Cc: Xueming Li [ upstream commit 532e495e4a20cf09e1f42d01bcbe782f7e2bb03f ] When the driver fails to acquire HW semaphore, there is nothing that can be done to address it, so just leave to avoid an infinite loop. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Dima Ruinskiy Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_i225.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index 17a1573064..8f01f8d918 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -333,8 +333,15 @@ void igc_release_swfw_sync_i225(struct igc_hw *hw, u16 mask) DEBUGFUNC("igc_release_swfw_sync_i225"); - while (igc_get_hw_semaphore_i225(hw) != IGC_SUCCESS) - ; /* Empty */ + /* Releasing the resource requires first getting the HW semaphore. + * If we fail to get the semaphore, there is nothing we can do, + * except log an error and quit. We are not allowed to hang here + * indefinitely, as it may cause denial of service or system crash. + */ + if (igc_get_hw_semaphore_i225(hw) != IGC_SUCCESS) { + DEBUGOUT("Failed to release SW_FW_SYNC.\n"); + return; + } swfw_sync = IGC_READ_REG(hw, IGC_SW_FW_SYNC); swfw_sync &= ~mask; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:02.385297545 +0800 +++ 0046-net-igc-base-fix-infinite-loop.patch 2025-02-18 19:39:00.628244048 +0800 @@ -1 +1 @@ -From 532e495e4a20cf09e1f42d01bcbe782f7e2bb03f Mon Sep 17 00:00:00 2001 +From 5509313e7a3a1f7649f9ea6e4b0f03023c221e02 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 532e495e4a20cf09e1f42d01bcbe782f7e2bb03f ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - drivers/net/intel/igc/base/igc_i225.c | 11 +++++++++-- + drivers/net/igc/base/igc_i225.c | 11 +++++++++-- @@ -19 +21 @@ -diff --git a/drivers/net/intel/igc/base/igc_i225.c b/drivers/net/intel/igc/base/igc_i225.c +diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c @@ -21,2 +23,2 @@ ---- a/drivers/net/intel/igc/base/igc_i225.c -+++ b/drivers/net/intel/igc/base/igc_i225.c +--- a/drivers/net/igc/base/igc_i225.c ++++ b/drivers/net/igc/base/igc_i225.c