From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DE3C4625C for ; Tue, 18 Feb 2025 13:40:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28BC7402A0; Tue, 18 Feb 2025 13:40:43 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2088.outbound.protection.outlook.com [40.107.220.88]) by mails.dpdk.org (Postfix) with ESMTP id 7721A402E9 for ; Tue, 18 Feb 2025 13:40:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=phx+gGIkleQNsr/lI5X8ixm99/xnIgxNxyuX2TgoErAFZVQiAPl3998v0u2tITQIDT478Zcrmwu6epti2UnuatUTBEl8kB0X99cF0ssK5Vw1krDeNg+XoCR67vPetMtNTYJnwdVijpkvgXTeaOiE/EGG6XZ76w2L1vsidw7Tf/N03ZCn4qrEjrukLGSofyUi/WqmGaChtA+kMOKmPvndChjGhW2M5UyMlYHDHpsclIuKpTsps6RTyUpl4btzU5RIbIAyCZ0SyG5x+TQTjIMvcrnBVYK4jY42HDzDDcLX0FaWcorq6IC+3q7fyr+sMMdZW8TMyedDtS2WrVO66X6lnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8jIw2ci0VLVTiSPobcwrWdrG3FIeGEJrRDgWxqwsI48=; b=W2sfQGiQtYL3L69v+JBp+BRbPnGitI50WhAKRQfw4w7sjAmUB7m+BmZ/DoAhgySjmOgOE2Ph7kxJN8fJEB+FHSDiTJ+JvCyOMoZ5vFaRb3AlBB0+f1UlMPucuDIxy6vGJ0/hjLEArvlTt1GAvvSIbW20FVNIRB6ApK94+R32cxiosMgMYpYlWQbEzMdjhJIDqWB3D1hevQ0FJsoHGYfwQHTX+81AYgJOpcHVPRtVBxF9HbaGOq3yvNWZ4ctashiUM3D9St091572bGTpVi7fPl+Af3rUSRtyAQl84RvcDkYVw5JiPPxGTeJtvRQMATFBKF3AKsEhfDM/NYUF7MXtZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8jIw2ci0VLVTiSPobcwrWdrG3FIeGEJrRDgWxqwsI48=; b=g0spMNqYAGIMzZIJcFLGzlt5yBkKcilKB4lizlsXm1tK7omtG5/avP5hnZLh0WRcrDIK8F1IPLCLYmcyE6tF0zVriHcNxx71t7MBNEW5a4xenwB0feQSuNiEcgfikF3EbMgjcTPXBgXFppSqMd/OgZGqyjTvSkdFP0Q5QBX7z/jXuAsf2NhMLXRsTCjG+Z2m3tq5NDuCu0gtrk6Le2lHI/Fk+Op6Ya3XqrOwQ8tQnXFm6uP1ERqksyVUQShBArK/wPj2VMr0yW0fLO+TalsOV7xTZfGMVIa4g405abvzgVZU2E+Fot1xg2w/tFvAq0CrgH94haB12oo4ZpIn9/UjcQ== Received: from PH7PR17CA0025.namprd17.prod.outlook.com (2603:10b6:510:323::27) by MW6PR12MB8868.namprd12.prod.outlook.com (2603:10b6:303:242::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Tue, 18 Feb 2025 12:40:37 +0000 Received: from SA2PEPF000015CB.namprd03.prod.outlook.com (2603:10b6:510:323:cafe::52) by PH7PR17CA0025.outlook.office365.com (2603:10b6:510:323::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.19 via Frontend Transport; Tue, 18 Feb 2025 12:40:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF000015CB.mail.protection.outlook.com (10.167.241.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:40:37 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:40:22 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:40:20 -0800 From: Xueming Li To: Sasha Neftin CC: , Anatoly Burakov , "Bruce Richardson" , dpdk stable Subject: patch 'net/igc/base: reset loop variable' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:34:44 +0800 Message-ID: <20250218123523.36836-50-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CB:EE_|MW6PR12MB8868:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d0ff28e-dcae-4084-1014-08dd5019720d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|82310400026|1800799024|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+g8QEe7ix2yL2KcHkulqEuj6jRBHqwldPsbEAijLoUsBbLA2vGYtWP3jAgVO?= =?us-ascii?Q?VBsPSefaXO902+IeydxqYYi4PRMEkqVs0Idq+q4kzqkx6C/rn54JMDNPsnr0?= =?us-ascii?Q?VWvVX2a2m/ivwSYDgJc1ysxqq11kMk/sViaNpeW/VmlpYeL/JSuXQbJw3ztU?= =?us-ascii?Q?P+f2yWspyXla1gHQ14Y0TP927XGghRxjTa6eXgVWoqydPoFd5xFLf7re/55H?= =?us-ascii?Q?R/YDQ6FxFmdHNu5kuudeDZYn5g39AgZSMTjmdb55wqMDv+ebriTYc2b2cZFt?= =?us-ascii?Q?YKCiQBry9v5MU/iJuFIGi0IALFf0Nn+OFHT3/oZpQQUhOH1y9krXOaVf0n+B?= =?us-ascii?Q?WctAC5BDPGcUmbLZNVIl4kaW5m++NmWnVp/VjX7QxjAZPzJG/biy9JaaB+Lc?= =?us-ascii?Q?s1l+E1SyKYZGCJHk93zcR0G8zCPiEG+HJfqZLiR14oVll6igG6HASh3l2pMI?= =?us-ascii?Q?yLkjzeo+CC9UDNsIvO7zfvylfpCsWHdrDytMsMgDCC/5P4KbmT32nZStfiZ8?= =?us-ascii?Q?7WssYVhTyO8lVioQkxwwdLVApudCgvITs6JmTR1sx3ne9lgVfxjiGSefm8Ky?= =?us-ascii?Q?0kt/us++nzkWx97f/VnCWRmbAGZLM+boPxaiVcaLXiTKoSKYgD9lM/tsDyTW?= =?us-ascii?Q?hzUjOyVCYRkCkPXQBZ4crUlMVgwVXZ9TyANhIbhKsumQOHd2Jip6loum7qQn?= =?us-ascii?Q?lNI9pEPJ9Z/9y7zhBFwlgx+Mx9NHwrO6fGFh5vudbBRxCC8P7dddTNMi3uz4?= =?us-ascii?Q?hII7d8BSWEDmQj53EpC8ixPVBQwZWObmBjvNy53vjcgdixZg/xrTBrreaLfe?= =?us-ascii?Q?K3ei0FRUX5Y+MnKDgQ8XMmvBVBLfLL+LSZOD/PnfHHVUpQt639F5tInK6xEO?= =?us-ascii?Q?HWO3kMP8f1CRgO/bhokKLrdX9VomxbN4/suHkG1DhiWcnLlKLw3WrVOWk8Ai?= =?us-ascii?Q?SSNi8tzn2I2cOjhcnU8fyR4cloewn2yArKOusMNvUNiF6PXwiZPY8zufyNka?= =?us-ascii?Q?d/2RnwnkfPwaIFxLevQkK+MnoBpIQAW5RUaCwJNBHavs+qhzHYMjiWg3IeOS?= =?us-ascii?Q?E4ZN5uIbWq8DUTw+R9/WeV6v8Dsrgo7DgCHRXj8y68vA7qGGVEHmQcfkxi++?= =?us-ascii?Q?S6Xd/4T25iS4m/nhRcjW0c0m+6B6Xa45yDVFjvufcoEdmkyT+XkB72isyHyz?= =?us-ascii?Q?86AxYaqHrM3/p2veRo+t1lR1xv44PFTTE5jb5Q7USk5X3VS0kbjQFA+sFAWE?= =?us-ascii?Q?V+y2kstiS/uBdnpY/NjXM+pA28MhuNr4K6XXUEFDaX82kTdHW6awzHrEMgRA?= =?us-ascii?Q?9aUQyYJf52mszFY4LyJfl0VRi/ZvzuzOM78bsyc6dHQJ86LZ/OmcemL1SxFG?= =?us-ascii?Q?0NYzIR8sej/Da1FBsn07MQIdChUWsJbVBf+SDMBOfK+I9yfqUS5udRNS5AO3?= =?us-ascii?Q?wkz1ljPZ5ayHpBFXdwDah8s36hwEoeQbUcfBGt4xcuKRu8/fMMyAzykLjbRJ?= =?us-ascii?Q?ol0/vyTa1vxBAu0=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:40:37.3091 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d0ff28e-dcae-4084-1014-08dd5019720d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8868 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=d50c5a9ace9d836d20e57b1ed41c87a54bbdeb01 Thanks. Xueming Li --- >From d50c5a9ace9d836d20e57b1ed41c87a54bbdeb01 Mon Sep 17 00:00:00 2001 From: Sasha Neftin Date: Thu, 6 Feb 2025 16:08:28 +0000 Subject: [PATCH] net/igc/base: reset loop variable Cc: Xueming Li [ upstream commit 60dca8e0f6b2d8526dc9dc8b54e59b5d68964e8e ] When writing to Shadow RAM, we set rev_val on success, but since the value is already set to success initially, it is possible for none of the writes to be successful, yet ret_val will still be set to success. Fix it by resetting the ret_val to failure before every loop iteration. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Sasha Neftin Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_i225.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index 1277f59885..003c060215 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -565,6 +565,7 @@ static s32 __igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words, } for (i = 0; i < words; i++) { + ret_val = -IGC_ERR_NVM; eewr = ((offset + i) << IGC_NVM_RW_ADDR_SHIFT) | (data[i] << IGC_NVM_RW_REG_DATA) | IGC_NVM_RW_REG_START; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:02.481714328 +0800 +++ 0049-net-igc-base-reset-loop-variable.patch 2025-02-18 19:39:00.628244048 +0800 @@ -1 +1 @@ -From 60dca8e0f6b2d8526dc9dc8b54e59b5d68964e8e Mon Sep 17 00:00:00 2001 +From d50c5a9ace9d836d20e57b1ed41c87a54bbdeb01 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 60dca8e0f6b2d8526dc9dc8b54e59b5d68964e8e ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -18 +20 @@ - drivers/net/intel/igc/base/igc_i225.c | 1 + + drivers/net/igc/base/igc_i225.c | 1 + @@ -21 +23 @@ -diff --git a/drivers/net/intel/igc/base/igc_i225.c b/drivers/net/intel/igc/base/igc_i225.c +diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c @@ -23,2 +25,2 @@ ---- a/drivers/net/intel/igc/base/igc_i225.c -+++ b/drivers/net/intel/igc/base/igc_i225.c +--- a/drivers/net/igc/base/igc_i225.c ++++ b/drivers/net/igc/base/igc_i225.c