From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D5F94625C for ; Tue, 18 Feb 2025 13:41:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93E8D402A0; Tue, 18 Feb 2025 13:41:11 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2065.outbound.protection.outlook.com [40.107.236.65]) by mails.dpdk.org (Postfix) with ESMTP id 79FA0402E9 for ; Tue, 18 Feb 2025 13:41:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=knqlbeAcPekdlu7m1MorTIpIV3vRLzs9JOvXnsqMxqKSaQ4+Qtc4jj1G3ywpzOh+KLGOlTlQcHDe8U/bYGH6VrCUiVrsjSX60og8bPIhoLL7F4gokVhevfgqH3Ezj5TcDCCVtKGWeXPCtxO8MVOo/K8ORH9KyiQunYkz8LXnjlTZddzENnMYbwmTzZZ5ugCs0cnmGUTuFi9DmbmvH1F7PSfu6hZbuRnLohv2ncZaEQGLHsXcpB/lzfCju8BaAVLwOT1Zx/JbZ62nXs5sRXPv2Rj5Nc/pBjw9wFO+R+eSYCyRdlGrUtJlztTjWIEU5mJ2RGKKgiSpr3lD2+K0ntb6aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fol0QP2I0EEQGUB68/9N9AkLlrEj9KgfWzbWgST4CQM=; b=ASPI1Ie5NtfV7fEEexuYq2Ts9FzXho/riweixQC3u9ecmIK00U4NJuPmk8clQ5EBs9KmvyL9d0DaqjkPFSz3J05WGDVFNY2qNyCNlQdafvbRDkV0jidERRQKZqQvsJxMgTCmYf6HO0FNf9QpmvPBvBKpPFF6GgybEnxVCz+xGS0GltIkZWVC2FBf7abDZQdPo0rrqRkRkZ/ZveMlTmCPlhw1+EfDgt7nFUCsFk0iz0lAqV3+NTsvGklcjsqol9t0c5aRn0lfvcQ8pI3ZlAjvdt2b9z370QPCMsJQvYd1DrPEyKtWX4fjjmc0FpS1MBrc6J9/XEXRAdUlcVt1y49ZZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fol0QP2I0EEQGUB68/9N9AkLlrEj9KgfWzbWgST4CQM=; b=M8sBcMof+9N93vQv3lWIsodIAN7MH0srr2ZirwXAf4Xl3A/y+5fbe/xywSS9rQKD+I7gPv5PBVU/P92b/j0wtLG6ld8wRSn0j38J10B7kUJFuGJnzl6/6m2zerDA4fnyL8kKTSBIocaxfJ3K1nIVqw32lyaBOOxoOtjiBxRcythhB0Ue7ZOLjC//JcIo5cf8f/I7KLOyakGNyfPuTWNuQ9yIR1jnh1UsEGOv17D7eFuDJYCcFb3MNG4+u4k64iiLSUhZPTuwmdn9DgphnhxR5cMsdwnj5gg3Pyoib/O5ug420oHYyFZPP9XZ0nLCnfR7iV4wXcWkKH4BiLX+6/Yalg== Received: from MW4PR03CA0128.namprd03.prod.outlook.com (2603:10b6:303:8c::13) by SN7PR12MB7105.namprd12.prod.outlook.com (2603:10b6:806:2a0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Tue, 18 Feb 2025 12:41:05 +0000 Received: from SJ1PEPF00002327.namprd03.prod.outlook.com (2603:10b6:303:8c:cafe::f) by MW4PR03CA0128.outlook.office365.com (2603:10b6:303:8c::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.19 via Frontend Transport; Tue, 18 Feb 2025 12:41:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00002327.mail.protection.outlook.com (10.167.242.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:41:04 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:40:52 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:40:50 -0800 From: Xueming Li To: Dima Ruinskiy CC: , Anatoly Burakov , "Bruce Richardson" , dpdk stable Subject: patch 'net/igc/base: fix unused value' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:34:47 +0800 Message-ID: <20250218123523.36836-53-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002327:EE_|SN7PR12MB7105:EE_ X-MS-Office365-Filtering-Correlation-Id: 3540f7cc-c894-45cc-a1f5-08dd50198225 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|376014|1800799024|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?t0FxoGsS+Ux/lsf4YD/yXKC0P8eYmwPFmoQAzDpEUfYObhPcr9Lj70kQDVMl?= =?us-ascii?Q?R9fwEBJRTL44Tt3v/JTNd/YxwBt41NONJ38UzQ/suLEw2zjoOyjgKUBrK1PL?= =?us-ascii?Q?FHRFDXvfNvmYvEuuxit1Gw0rKv2ehm48A3JWkc7OpBJd1BzYcd0Oa+Jcbb1k?= =?us-ascii?Q?0iLPR+FQ8Z7tLoeBAJLSVwZDJAxgT79hpzwqoSLjmxhe7jEGsQFj+xrEhz2I?= =?us-ascii?Q?PmAfgICmVRqE5iPLtzkNh44crWwmOUyGQ5QEoX5wHAMWGSVRxXcyiDjqW5QQ?= =?us-ascii?Q?cXM2E+VknLMaloUDXNAyKVLbOWVtQfk6jiqByDzk8tjZcIvwxcV4jfERKcsZ?= =?us-ascii?Q?2BuPFp7AaH/N3kEPTHJc9w9kTLg+ilDUxdVIwnpL+sqD1qQvYLr6QCHN7PAx?= =?us-ascii?Q?bTlprRdSRdX31pIccm1mbjBKzameLhtYcoVvpd5fI2HXddvDqykhErmtNU4b?= =?us-ascii?Q?PyZB/hF9f/uUcW+ewAa9kU9abUq4qktewwH6tzJrqWiE9DFHbDSqEVSfzK/L?= =?us-ascii?Q?pdxML8VzzUpA2Z29i7sYhSvllTqzUQjopy2BAezNZD6TlTFFKUyAhp5gxux6?= =?us-ascii?Q?WXZO4ugtWQut+Qa1RgAU0zQjyXIunD2lfnpYkbJ/AoChoQf7jklwgXM9dcFT?= =?us-ascii?Q?0oQwHsJupkcPNiEpORETvJteGx1HrDh9SL0hhHEtekquIfTFnD6IltzrQ4sI?= =?us-ascii?Q?En4oYp6XZZrNheVAvlypUt+MFT68SNSc+MNH0K7GcUwqulcfLsDieIFAX/aj?= =?us-ascii?Q?YCzYKvisTCsBeVpEED4+0d8YiOdFC97UYvn+IB42cPKFKq0xoTaZ327nWJZR?= =?us-ascii?Q?NxzVUu1wT4rv7QP0Xdfw2Q51sXNk7uIVde0znkM8JlsVqXC+qm4PlqpoxKG7?= =?us-ascii?Q?G/iPBsurnSDN4kiHoIVujfnp+dd4ac4IBBC+gK1W7kIy4pRsNkutAX/BVVhb?= =?us-ascii?Q?scTA7xTu27Rr3WE5PxgYO/vhp+kdvLltKkQ6S7n6rFqZpkJCXT0h3CMawq8N?= =?us-ascii?Q?nLYb36lCrUn4YbtyCW/rZ8vTbw1UhoXxM0yBi0LIiYr7t0gejyjnE0oBWyrq?= =?us-ascii?Q?fIVkCddi//z158zD1y/OOINdYX24LfHAAY7bk9jcsWaZerkbyFc7X0F2vZdf?= =?us-ascii?Q?QwVABW+uW60FdePbTnxk0GlnrALhbjbYrPcOEgxrQJJ5H/HiV8klXyquMYxv?= =?us-ascii?Q?qNBWM4In9+Ee+1DGGsxoXJM25PnwJ9h47BchzuKm65MQbrIhCnHk9RSaXeG5?= =?us-ascii?Q?PlbYxp8UcRA5vdxAE4W81dhddh3KTVZVg1GKeq7sd9R65+Vk6m+QsEpgk37+?= =?us-ascii?Q?xkueWZnyet/XMG3ziHnfMISPbqzFhwJsAorkUW0yXI4XHvYRRPSgICeC+oYe?= =?us-ascii?Q?5Nmm4QjRNnQgANYKj08K4oTNYFGhzTKkBMWvaK16StW2tnzd9HcFBZjYH6N/?= =?us-ascii?Q?pVYmZlNdp3Y4dZ0it7fS66gg3jo1BT8H3uRzFGnjghTBHfhUAn93oLpugNF7?= =?us-ascii?Q?4pVh5pp6XFN7PxY=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:41:04.3762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3540f7cc-c894-45cc-a1f5-08dd50198225 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002327.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7105 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=ef2e66caed01481bea22fcb5f75a2dc2fa4ef12c Thanks. Xueming Li --- >From ef2e66caed01481bea22fcb5f75a2dc2fa4ef12c Mon Sep 17 00:00:00 2001 From: Dima Ruinskiy Date: Thu, 6 Feb 2025 16:08:31 +0000 Subject: [PATCH] net/igc/base: fix unused value Cc: Xueming Li [ upstream commit c506cc8305b4ca17bae903a54daaeaf5b7005038 ] Static analysis has reported that when there is no get link status callback function, the value set in the if condition is not used and gets overwritten in the "out" section of the code. Fix by not setting the variable. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Dima Ruinskiy Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_i225.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index c7c2ec8ffe..23c68a3948 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -1114,10 +1114,8 @@ s32 igc_check_for_link_i225(struct igc_hw *hw) * changed. The get_link_status flag is set upon receiving * a Link Status Change or Rx Sequence Error interrupt. */ - if (!mac->get_link_status) { - ret_val = IGC_SUCCESS; + if (!mac->get_link_status) goto out; - } /* First we want to see if the MII Status Register reports * link. If so, then we want to get the current speed/duplex -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:02.574924312 +0800 +++ 0052-net-igc-base-fix-unused-value.patch 2025-02-18 19:39:00.638244046 +0800 @@ -1 +1 @@ -From c506cc8305b4ca17bae903a54daaeaf5b7005038 Mon Sep 17 00:00:00 2001 +From ef2e66caed01481bea22fcb5f75a2dc2fa4ef12c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit c506cc8305b4ca17bae903a54daaeaf5b7005038 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -18 +20 @@ - drivers/net/intel/igc/base/igc_i225.c | 4 +--- + drivers/net/igc/base/igc_i225.c | 4 +--- @@ -21 +23 @@ -diff --git a/drivers/net/intel/igc/base/igc_i225.c b/drivers/net/intel/igc/base/igc_i225.c +diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c @@ -23,2 +25,2 @@ ---- a/drivers/net/intel/igc/base/igc_i225.c -+++ b/drivers/net/intel/igc/base/igc_i225.c +--- a/drivers/net/igc/base/igc_i225.c ++++ b/drivers/net/igc/base/igc_i225.c