From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FEAA4625C for ; Tue, 18 Feb 2025 13:41:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AE90402A0; Tue, 18 Feb 2025 13:41:38 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2051.outbound.protection.outlook.com [40.107.95.51]) by mails.dpdk.org (Postfix) with ESMTP id E1D12402E1 for ; Tue, 18 Feb 2025 13:41:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SB0GXf4EegqUVbzS9qCLInwCCmiXtgWNPLmfSSIz/iGXa+SOMwCrEPuMGu/N06BnzUMO100b8qRKbLcmm8amgC9Xsx0YsfweRX2pSF6H4qvKw+2av5qSKjHFTZ/gOSBwUEeKAodCH8P7e3vA3+C7tX67FyIxxidXl8PauDJM8TxM5TfF7URZkx5oUXJh2uHpLUr+s3PUgJ2GXwbWZpGTnUs7NS5fnIMxENN4XSYwBlBLF4enRLXqoondQwaUCFaFUJmi6riH9w4EqR2nTvS0vDPxT1v8/B+bk/jD+KwVb1/46/aqAKjbBA54I6GHai4CJ2Ey0HU5uaFfFEkf27gN8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dsGmKiMrrj31RvGl1k7QHABCym8gsdVVgWAsvFdQRzg=; b=iLqKW4rdvWnbZEgQrKI6wc5h2dqZy5NPevUY3AnNcUlY4jLdaVWBWEBE7kcFPTi9Ht3yfg8HROC3SD42h/OvUms9KpbCrntHkNMWSAvyXQQTrb9HxdcOJHBJ6HoS0gqCEo/LTerTFoBBCYn3GII/zZuojRNPVbjWvMKUzQ5KYLEz2+KXM+PUPGXSsTPRj6dzH2z3541ctc7lsG+VmRYv1DFBuDYq2ZiW4lohH1feAXvnpytk3FiDYhZDqVFk77nRy4y8FQA61mTjiERFx7uGJDTk//HEylbzJXfYrV3oAfv+leCRjfewLeJTlDM4WAkks6M8xqIsjnaT907LYIH4Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dsGmKiMrrj31RvGl1k7QHABCym8gsdVVgWAsvFdQRzg=; b=mi3yMF1Iz7njcW8ZmUdA8c2GdOcy4mopHJfSV67FMNcDYdFboRlcAObhgnjSKTTznVvYR0rYMEqMJsJTWFmsO0TM+M2WJT4jDGgSJpk+pr2GCPCEcs7LmfHPwve8uUPpLiIVDmA+hCpugS7VvKbEcNbAtmoK/rv2wAXg45Nfko37JWvqbXprAoAvp7cMYhyKxErRcHllA9M5FZkLpRiqT40XgoXsweDD5h4TKLq7zMSv6tY/qgDZ3Y8lJvHYSSf4TnaOL2TiCmxFAhTg+vLXpyhm7Dv87TQMHMSh1T6jJkRE1lhTiBKcH9KE+KrHh9iTqA3b4e7Q4skDJz9de6fQYQ== Received: from PH0PR07CA0110.namprd07.prod.outlook.com (2603:10b6:510:4::25) by MW4PR12MB7432.namprd12.prod.outlook.com (2603:10b6:303:22d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.16; Tue, 18 Feb 2025 12:41:33 +0000 Received: from SA2PEPF000015C6.namprd03.prod.outlook.com (2603:10b6:510:4:cafe::5f) by PH0PR07CA0110.outlook.office365.com (2603:10b6:510:4::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.17 via Frontend Transport; Tue, 18 Feb 2025 12:41:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF000015C6.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:41:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:41:19 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:41:17 -0800 From: Xueming Li To: Barbara Skobiej CC: , Anatoly Burakov , "Bruce Richardson" , dpdk stable Subject: patch 'net/igc/base: fix data type in MAC hash' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:34:51 +0800 Message-ID: <20250218123523.36836-57-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C6:EE_|MW4PR12MB7432:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cb2364f-8a2f-4a86-24e4-08dd501992fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|36860700013|376014|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RbkTJTu/+rbTnW4YjNcan1joTRUXkWNn9baLva1biXBd47pjL8noYwH9PLm1?= =?us-ascii?Q?AwO3FL2I0dFXasVrVclKKKTWZigIZtrG0uEDILi5VuVmMIx/VGbnNOd3YRoA?= =?us-ascii?Q?ieP1okVPgrBTTssTR92qme2thJOljXQLEUMBHTgXnLQ7N02v+aViUlTCHvDk?= =?us-ascii?Q?mm/XCuy+wgESWZfHatLPJ3BoyrDIHosrMybTF8HKneNKhh4v6CpboZ6kMeoN?= =?us-ascii?Q?gt+pcA8yFkvt6AVuZA/gffS5fAfL1B/sKwq7k9r4hO/zIuRiraD8kdcNqgRK?= =?us-ascii?Q?Vtr3joSYwJMdShF/FeMw2IPliXDwxOLaooujKvwo2GKqenngHgDAkKrBPhZj?= =?us-ascii?Q?naXaQfNuT4KzehkVb4ZI9IlLjvu/pOqxJcVH9JHCF40wT3JM1dowY146lXS7?= =?us-ascii?Q?7lBKjTVgNHdksKSw14BTkEEprxlO6Ejv1+65IUAbsI6ydFxNQTX4y2/nbQNq?= =?us-ascii?Q?vYHE09PLwRr2Bjd0RgXCb55CcKvLcZRs1rONPUDhypqSoj9M89qzbMc2Yszp?= =?us-ascii?Q?ecGGzS913CPuHBNgqlzdX9vCN9jgNzHLdLb37qxIwUxhWixQpm1InuwUBYp0?= =?us-ascii?Q?QkmMQPpRH5iLXxRsqiB29qchl6AGOzWJcK+GJDXOby3a6+sqRpywz5NiTqQy?= =?us-ascii?Q?aLvQ+lCKg+7IxBClE6Mjgn7YF47KJU/zkjZXkC1zYjTCA7AHzRiZg4kCs4Vw?= =?us-ascii?Q?iiamJTZkFh0kan5PEYRSgx9wY6thtX390W7wOXN/pgx0plyqw2pc/ZvjvtzF?= =?us-ascii?Q?zV6bRM8Z/VJSrf7Ep5JmAD6ZVe41tN4mThcPJ64BaaDg1LmzY9DZprvy6luX?= =?us-ascii?Q?YVz2yseVsWyOXTWsr815uTIeF2n8jmEv7Ao3+mp0Op05w5qJFv7gLhI/SgNT?= =?us-ascii?Q?BID+hIWqWygqMEAmiiyUcYVynNx5J+myu2+jtEiXzY892DL72V5KJ3re/mXw?= =?us-ascii?Q?xGtW3iuuqoxFtG7y3v/RuWiBhuu+t8vwfUX3smKcJXy/MxIuhsZTGU4Jtl3h?= =?us-ascii?Q?ClWioi1iKFFktw79KgcSq0GwzgWWuIBQdCEQthzCsRdXxWPFhFZEqgutwfUN?= =?us-ascii?Q?Pot5FZFdVR2Qw0GIEeO6xNLtkUGTiwKcW0SDoLHXRIyVIAJq967ozAC+mUnj?= =?us-ascii?Q?h1W1KXHJVe54ZZgY1GpdI0d2Iip5u2T8BV5r93/uUB+JMZt7TPwQ0Hfqs/uV?= =?us-ascii?Q?zNGpmVvI7P88w1umCtkVnyO25NUwIFh20P5mxXg1EOODjHKzcTimAvAJDFUI?= =?us-ascii?Q?aIqWcH34ANlQF/JSIMFdOimx0V0v4blZ0slQYI0qV9qPSQ6oDKmbkVz2UHkP?= =?us-ascii?Q?L20IqBPJC9orWKGXVZB2OzRFGPBhY9q945frcC9a8O5HgaNE24mVGXY9h6/K?= =?us-ascii?Q?1NzSjAZGbHry43LhrFiFaPISQEQd/laoSHCa1keU2yanDCmPHPu5PcFP1wCY?= =?us-ascii?Q?ipS19PcxGPmxBf7bKg6WpS7IYG0S+kG1rKV1seyNi+jN862SPNAN4Wlhk8Wy?= =?us-ascii?Q?fj4dqgz7YOcILUA=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:41:32.5499 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4cb2364f-8a2f-4a86-24e4-08dd501992fa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7432 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=e5a7115f56331726dbfdc910e5b333ac8ff12c5a Thanks. Xueming Li --- >From e5a7115f56331726dbfdc910e5b333ac8ff12c5a Mon Sep 17 00:00:00 2001 From: Barbara Skobiej Date: Thu, 6 Feb 2025 16:08:35 +0000 Subject: [PATCH] net/igc/base: fix data type in MAC hash Cc: Xueming Li [ upstream commit cad5c51ec3a0e965d6d4bb98166890499597f23a ] One of the bit shifts in MAC hash calculation triggers a static analysis warning about a potential overflow. Fix the data type to avoid this. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Barbara Skobiej Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_mac.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/igc/base/igc_mac.c b/drivers/net/igc/base/igc_mac.c index c69f8ac73b..cfb74a6443 100644 --- a/drivers/net/igc/base/igc_mac.c +++ b/drivers/net/igc/base/igc_mac.c @@ -539,8 +539,10 @@ u32 igc_hash_mc_addr_generic(struct igc_hw *hw, u8 *mc_addr) break; } - hash_value = hash_mask & (((mc_addr[4] >> (8 - bit_shift)) | - (((u16)mc_addr[5]) << bit_shift))); + hash_value = (u32)mc_addr[4]; + hash_value = hash_value >> (8 - bit_shift); + hash_value |= (((u32)mc_addr[5]) << bit_shift); + hash_value &= hash_mask; return hash_value; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:02.705312790 +0800 +++ 0056-net-igc-base-fix-data-type-in-MAC-hash.patch 2025-02-18 19:39:00.648244044 +0800 @@ -1 +1 @@ -From cad5c51ec3a0e965d6d4bb98166890499597f23a Mon Sep 17 00:00:00 2001 +From e5a7115f56331726dbfdc910e5b333ac8ff12c5a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit cad5c51ec3a0e965d6d4bb98166890499597f23a ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - drivers/net/intel/igc/base/igc_mac.c | 6 ++++-- + drivers/net/igc/base/igc_mac.c | 6 ++++-- @@ -19 +21 @@ -diff --git a/drivers/net/intel/igc/base/igc_mac.c b/drivers/net/intel/igc/base/igc_mac.c +diff --git a/drivers/net/igc/base/igc_mac.c b/drivers/net/igc/base/igc_mac.c @@ -21,2 +23,2 @@ ---- a/drivers/net/intel/igc/base/igc_mac.c -+++ b/drivers/net/intel/igc/base/igc_mac.c +--- a/drivers/net/igc/base/igc_mac.c ++++ b/drivers/net/igc/base/igc_mac.c