From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DE4D4625C for ; Tue, 18 Feb 2025 13:41:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 586BF402E9; Tue, 18 Feb 2025 13:41:38 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73]) by mails.dpdk.org (Postfix) with ESMTP id 5A214402E1 for ; Tue, 18 Feb 2025 13:41:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qprpPdqD7rxL7+l77wZ/Pp/6c1uRwMQfN8yA57rh/EmnXXxaR+bEMYL9U3X0vS6pA8dQKadapDkVBRU8lcd6XgwIdUB6RAV+kKjmMHrz45c94dWgo8p/0A/4W8DHIcc2TlxJwwPNfppxJ/YO37i1Lkd7Jx/6shQ3WngKBMM/3cqQpW7QWM1Q5AdFoplsuPVN3Rxpa7tbHE8w+f1ZRW9sBT+uOPM/vty0z8e7DAVPxc00Pbr6a6Vb9ULuihK4pMgU2R3UgGzZSfXrFs3DnFdu3X4nXMI914KLFJLp5pA7LASqZo45NFmxRYgCtf+Jt17/j7FtGpqe7L1JlQ7v28TV/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7xa8ct8+8u4/Kn23VVxzlDHgOw9iQZNNNuQkO1bDyGE=; b=yMtBUJHVHm7as8GSL3JmNMB7tcjSHqC9M1VHPM63CHhmv7bCKNEu0aAYGZwgdIPMRPPoOnTemsKWDuR3D8gQ26nFg3IwRUeu0yiWhZBLwEryfE/Ohhr50VJ+L2yqtjiOb1uPkKoZjgyx+RQ6vCsZ2/umv7MG1YFKXmV7BbkWTegnyMsGH4aaCuO1G7sCrlftUUHraOnoUd2TmltDXrMhYSvgnm772madSfsqS4CruITFzLb2nBfiLhmbZfLa2jBmK2FxHFGMy5oYATmCQaH/tfHSudbn2MQPturuQsDNoQYGrTOMESMeQKwmWZW3ANdlPyBjtBl8VttWCG4s5rd5OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7xa8ct8+8u4/Kn23VVxzlDHgOw9iQZNNNuQkO1bDyGE=; b=S+/GqxG5jh914oViMsknidOuHHnLZ7MqCWF/89pBAoHclge0AiIB/f/XQ6omjYj+LqtdjedlBsvZJf1YOGY+LqFUryju7dHS7WVF0CkJCzFNn/0eae3OstpsrchTIoJfQEQhzZBBdw4S/5Pbwo5i3qe1gAC7+3FR6cbR+qMDiCI/20xHVHvz2iDzcwMQrgZ4JNFjKtgzawLFZVHUiNLJD+hUF0O3BK4gSjb9grjWdySrEENiq+kuiOin+0q6A6NnXyCdwsUbhSfhT1uW/OpfCHuL/fIdU+EvF+QJzlXJ745xK2t8+6KLLqj4sR/SlqH/WAlxrnSl88uypded25EBDQ== Received: from SJ0PR05CA0117.namprd05.prod.outlook.com (2603:10b6:a03:334::32) by IA1PR12MB8520.namprd12.prod.outlook.com (2603:10b6:208:44d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.21; Tue, 18 Feb 2025 12:41:34 +0000 Received: from SJ1PEPF00002326.namprd03.prod.outlook.com (2603:10b6:a03:334:cafe::f6) by SJ0PR05CA0117.outlook.office365.com (2603:10b6:a03:334::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.8 via Frontend Transport; Tue, 18 Feb 2025 12:41:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00002326.mail.protection.outlook.com (10.167.242.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:41:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:41:22 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:41:20 -0800 From: Xueming Li To: Przemyslaw Ciesielski CC: , Anatoly Burakov , "Bruce Richardson" , dpdk stable Subject: patch 'net/igc/base: fix NVM data type in bit shift' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:34:52 +0800 Message-ID: <20250218123523.36836-58-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002326:EE_|IA1PR12MB8520:EE_ X-MS-Office365-Filtering-Correlation-Id: 412114ed-18ca-4124-014e-08dd5019937d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nDP/zecWo3RgNWNE48n10D0jjkh/u2arOWenzXviZ5QPjOyFVkmiBRidSq6u?= =?us-ascii?Q?EPT3evYvgHhvso0plhxJt7FMeb6xOB6AbK1N6cA8yL45gQqO17AX5JhS+AJg?= =?us-ascii?Q?KtpXWEqoGMx8+xpUZr4xXAuuNBMe1GTPjo2I1aNWI+WppbmRImt6Es44Pp2N?= =?us-ascii?Q?WDs055mgn2mEJ7oCDh9YQeoi9b2Sr+W5F++LMqFWEdRIfOt15mEfRk18VziB?= =?us-ascii?Q?cb74ze7FA9pXlQM4ManeFbTnuo9+vfO5MbGJgtiVuz7Dacdy0GeaiGxZNK1d?= =?us-ascii?Q?8YAWvRAK6vCNgaf+o5uXSzoS5Z09slXLArhhDLYutSeukrJmR2mCCq+GReHH?= =?us-ascii?Q?7DLqXrI9G1mlRD5MxWIQreWsatsST8ApSNXid8VMiVqhJbNxnBg8Yy/BBm9u?= =?us-ascii?Q?xo01h8coEG8odRmoNNc2gNv1TknhTK/naRTKIbb7AGFJPUnpwKbIqLhEWEwo?= =?us-ascii?Q?k200/qHdMVlSODzfAo/hdhP6GDHBMsDerFbpptV+afnR/PI3cS1clo5wQfI6?= =?us-ascii?Q?d1jJzZtH1d7C2CGrUtQOS4IsM78fI0fkIU/9exymZpn9B9KgHR2VlsNEYKuh?= =?us-ascii?Q?cOBEdIagJ8Bu/IHfxgzWw3VSHyeAdv4w/z34Vl7I1te7bQt6mg4jM60n8nQS?= =?us-ascii?Q?TtR2mzBJibEe2RAz3s9LTdFm1EO/mnwGRLQgnjUa4GPbl12iLE241MnKqIpV?= =?us-ascii?Q?No7sXvTNrOzkukLLfeZGsXjlUBdb0chHCjgnY6ZDZXzcHBUkWW+E0WR/lc6P?= =?us-ascii?Q?pO62kdOCJhRiHOQEAlWXHQryT+QVmKEf1jbU6WnS5c5cWdV3yu9U8v5kYlUs?= =?us-ascii?Q?bXFEtqG3bSouMUqgfWhjHubx4qrmo0C5lGewGAFjpRdd6BbH0gxomcEroymf?= =?us-ascii?Q?z2vM2zOehsoSxcLL63N9j+EujW3izosUW0Kcl89Q3vzalN+N/BBnk3nTejjx?= =?us-ascii?Q?qQObxUCk6MX/mfzJm4fUg27tAts0M+1aOUQOzBjM2z0Lo86lIMaga6BS2ecU?= =?us-ascii?Q?Y52NizC36cKoleCFRM4si+dHKrM5iFSMOj5EAXmtAihYl3AIHMhMh8ZmG+2E?= =?us-ascii?Q?QJavUXtaqkVrpehLZdB/kIOaCo8Z/F8uKBDoc2X57fTnjqEZl4scQsfFV9+3?= =?us-ascii?Q?ppFy7JNT6bO3Vs+Ao+BFqvLB5WWmrqSBxlfHyzD35KJSD8l3dkQQXhfUiBUf?= =?us-ascii?Q?ze5cuXU3dNmHlats0vHSxvdyr30ypxA/Xmqwir01D0D5hKH5zKBIjdSn6m+6?= =?us-ascii?Q?41ODvGOfuVChaIisAhmYKb4Ig4b+xXdLpwGp8flt/M1nUzAEf0ZmbImT+jWi?= =?us-ascii?Q?GrCMkOBOUNE0UNke/Ax5OMQk7NoYwsDrh1Zhhiud7m+Kq1POf9ITSgHAWJ9c?= =?us-ascii?Q?yfTHts5nXstFrVXdgnu8C2NlljNuQeIp2KCexsn9xpOK4LYm44K4S3s56KOJ?= =?us-ascii?Q?5kHyFS8oIcBCbofPwmOcGSmOXrnsMBq2WQZQOmWLMarSJPJCEFQPFvSiEs7E?= =?us-ascii?Q?d5f+OOPmHgZYFpg=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:41:33.5013 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 412114ed-18ca-4124-014e-08dd5019937d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002326.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8520 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=fed480fbadeab2f9284a22535016d365f9530994 Thanks. Xueming Li --- >From fed480fbadeab2f9284a22535016d365f9530994 Mon Sep 17 00:00:00 2001 From: Przemyslaw Ciesielski Date: Thu, 6 Feb 2025 16:08:36 +0000 Subject: [PATCH] net/igc/base: fix NVM data type in bit shift Cc: Xueming Li [ upstream commit d6ad4cdad361558bfb2c04112bd6650debbc9c7f ] There is a static analysis warning due to wrong data types being used for NVM read data shifts. Fix it via explicit type cast. Fixes: 8cb7c57d9b3c ("net/igc: support device initialization") Signed-off-by: Przemyslaw Ciesielski Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/igc/base/igc_nvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/igc/base/igc_nvm.c b/drivers/net/igc/base/igc_nvm.c index a7c901ab56..d37a3ffb0e 100644 --- a/drivers/net/igc/base/igc_nvm.c +++ b/drivers/net/igc/base/igc_nvm.c @@ -926,14 +926,14 @@ s32 igc_read_pba_num_generic(struct igc_hw *hw, u32 *pba_num) DEBUGOUT("NVM Not Supported\n"); return -IGC_NOT_IMPLEMENTED; } - *pba_num = (u32)(nvm_data << 16); + *pba_num = ((u32)nvm_data << 16); ret_val = hw->nvm.ops.read(hw, NVM_PBA_OFFSET_1, 1, &nvm_data); if (ret_val) { DEBUGOUT("NVM Read Error\n"); return ret_val; } - *pba_num |= nvm_data; + *pba_num |= (u32)nvm_data; return IGC_SUCCESS; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:02.740686284 +0800 +++ 0057-net-igc-base-fix-NVM-data-type-in-bit-shift.patch 2025-02-18 19:39:00.648244044 +0800 @@ -1 +1 @@ -From d6ad4cdad361558bfb2c04112bd6650debbc9c7f Mon Sep 17 00:00:00 2001 +From fed480fbadeab2f9284a22535016d365f9530994 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit d6ad4cdad361558bfb2c04112bd6650debbc9c7f ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - drivers/net/intel/igc/base/igc_nvm.c | 4 ++-- + drivers/net/igc/base/igc_nvm.c | 4 ++-- @@ -19 +21 @@ -diff --git a/drivers/net/intel/igc/base/igc_nvm.c b/drivers/net/intel/igc/base/igc_nvm.c +diff --git a/drivers/net/igc/base/igc_nvm.c b/drivers/net/igc/base/igc_nvm.c @@ -21,2 +23,2 @@ ---- a/drivers/net/intel/igc/base/igc_nvm.c -+++ b/drivers/net/intel/igc/base/igc_nvm.c +--- a/drivers/net/igc/base/igc_nvm.c ++++ b/drivers/net/igc/base/igc_nvm.c