From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CD3F4625C for ; Tue, 18 Feb 2025 13:42:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07F1B402A0; Tue, 18 Feb 2025 13:42:46 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2084.outbound.protection.outlook.com [40.107.101.84]) by mails.dpdk.org (Postfix) with ESMTP id B8D3A402A0 for ; Tue, 18 Feb 2025 13:42:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aCN0JSLnaXLq/uAEWa/SZpNs/rR8Wd1d4J0jB+ePb9n5XuB6MjacOk8x/2w61wmPF8zI8mKBKrivdckn9elJuHyfLF9pevhF81sN39b3gMH7TVvQbfqm4RgOjBhxRwIL552bdHTlDKVSdNYw+R79A6OhqL0S1epfklaYDVKhyvCCVouNiRZTEb/Tk5OGToNuc4BTFy7M/St5x4tBdqsLbDiedQ14yMRI7K9B5OJJ6lWS7Wvgbzz0euieb06b8+3QZeETRuJltLV0zHPfLXd47omg4PMx1NuKDMRkukhgiMt3Qd8jzDlZN76DIEcUY0QomB0lADLwd1LIFCE/EL3rrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9QLlTmw8WazlBYN9ywikx1b/bY5nOoV4X7TMCuh74II=; b=XHLUFRIYyAuIiKe6uOOAwOfFPC0qRwdefcEdsx8k6mIOoVsG71caJQKiJMcnzAHO2Bgn/Hqf/6VqsCyMJXm0+UUj8HnKgt+wLx5LN+yMNCcUG+hhxD6GmH/cfXx+BguO/3sm95V3NadRC74zGMRJaY/EiMTTJ5Cpm7qLPHL3r32XL8GOiWBJKRcWjdspZDwNd6Mzug4FNqjzWWwSzrsdZEOilSzFDpa5eTtyavXw3YMd5F+6QB8yPza/Lrh+rMYZ00vFa0cvQb06J8mpv4XJJ+TDGvMWkpzneQMEYjovv1wSxN+vimYgqvOLEb3Zlc03q8omhq0M6Jpv6bv14cADNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9QLlTmw8WazlBYN9ywikx1b/bY5nOoV4X7TMCuh74II=; b=Il5+jqYtIjE3L5I9Jr6eR1DhznwJMoeNbRXQs4HE9xO9gXbVJFLS5ofIUrOrU7L+V7Hkz7XPUB834o1WQva8kvZkjYqMxkVP3eby9GAmPgsc0ZPBfVqE3u5lts9s232HBnb7RJdt32+4l2/WX3t7VQRgxpIHLR/lD/G/ezu1e7rgxceW2PVJy34at5EttIy2pzQN6efYgIWja8zguBrK4RMmzx3m9kcBuhYuk+5pihTerna/Om3MGe4yk72vkqzig4ig+zTb53Ba9c2dyJeprx2RGTZiJ2g4XZYfGhNU8YWbIIokOpWsW/1SGbq4cAxcipANE+j/vJMcOaiZOaiuRg== Received: from PH0PR07CA0106.namprd07.prod.outlook.com (2603:10b6:510:4::21) by PH0PR12MB7839.namprd12.prod.outlook.com (2603:10b6:510:286::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Tue, 18 Feb 2025 12:42:39 +0000 Received: from SA2PEPF000015C6.namprd03.prod.outlook.com (2603:10b6:510:4:cafe::e3) by PH0PR07CA0106.outlook.office365.com (2603:10b6:510:4::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.14 via Frontend Transport; Tue, 18 Feb 2025 12:42:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF000015C6.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:42:39 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:42:26 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:42:23 -0800 From: Xueming Li To: Dima Ruinskiy CC: , Anatoly Burakov , "Bruce Richardson" , dpdk stable Subject: patch 'net/e1000/base: fix unchecked return' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:35:02 +0800 Message-ID: <20250218123523.36836-68-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C6:EE_|PH0PR12MB7839:EE_ X-MS-Office365-Filtering-Correlation-Id: d2f40bcb-1d6a-4c24-c67f-08dd5019baf0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Y34sywTM2D12BaRYGh494fhnXtvTPrx1D09BcBzt+rqfrhxnH0PIsbNZX4YX?= =?us-ascii?Q?Dl2pT9Rqdgr//TgvIqfJnkdGhUIGDNR5DNSTAuPeBLAlLU7RKDpHoJM0xMjK?= =?us-ascii?Q?vZ6BUP+yQswLoCFcqufkod/viMN1x8Suvtrx0BTzeVwHGX1tglaRkUgnR67f?= =?us-ascii?Q?z5Dw+DpKMEbbwaSqftBM9HoyT4/Omo/t8RpQ/X39olu41HKbkJHbyLbnb8Pw?= =?us-ascii?Q?C5O3D57BsliX6f/lOQW8jYMoVfugl6gBAHZTurzxBqmRNixtXVPj3YDwpZ3F?= =?us-ascii?Q?VLgPpDp2n0M4+GGSh9BNxSdkFhnLXU+2uEW3uxZxGUUGQ2Pzkrypozt7x5ti?= =?us-ascii?Q?78Rb4pfsxSLcz9wNY9P9bnssOb9lj7j21E7O3d+Z0RbjUesoS0kVeIApaUQ6?= =?us-ascii?Q?oYTrKrLyDcl8xlvGoKF0USMozpUdwhiWIhJvuqyyxlp/3COnJoqhUZ5PhacF?= =?us-ascii?Q?ZKa8B7tpcN15D/FRiNFbHwhDeM95PHhWNs7fmj7MVtDbwTY9Un4xfagqPhlQ?= =?us-ascii?Q?KdIuCC5fq+RXAF9XjbKj1Pn2SotMp8zYm6YFJYThxS/krleeIKz36HlYMeCM?= =?us-ascii?Q?a0sIJQD3vGsc2erWCmSSGyZEidivfcA1WxISnuzuTxU4UK/mhsF1x3bzbQzx?= =?us-ascii?Q?TKYEghuSAGFjI7G+lKhMF1ey6KtUfQpAvMDjKYey9cBnPUAqyA+DqgnuOXZK?= =?us-ascii?Q?9WE4WMfmYWkB6XgXJz+MXL14BKbEIJNNJDCjFH3LGH+UTCxcrh9ZvuZlJAqv?= =?us-ascii?Q?Hd+V8McQqykHWRnqX9Bcvne8qUaOtJq4e0e2DlFI7TFXbPiBokTmF5igUNt1?= =?us-ascii?Q?b4UAdPK+QxO1g9rqgHDHi3QkK9+Fw2nTJrui/BHgYmpf5jYGDZTr3sEqwD67?= =?us-ascii?Q?dVxh497pQpuWKvTKsN+6TKwv2etwj8/tXIO9FOZi3mZp3PZ3r+90FunkpflF?= =?us-ascii?Q?lSGzdZltZ4kXf2NNIOGar5xnS0OVN6E+z80ybqhWanEkxPg5BbWhAlHvlTy0?= =?us-ascii?Q?xRtlGAp5+sjUfN6yzIIRyrX/Sp4wu4GWy3xJVFlF2Dzhu3LxZ2YP044K6lRI?= =?us-ascii?Q?SxmL818mYdLJBSLZ9zWvgHKwPSF6e8bEzNjAjMc/rcJHdd/4X7d2cyiLjIAD?= =?us-ascii?Q?bQF6rjiVtA7KxW8q93++/n0vdd3ftz1FNBQ1f2ecPtPGO3Nncp3usVMsl8xh?= =?us-ascii?Q?ePk7jN29l/KXrwpC5XzSBbCi4buq5G6s2lV56+QE2Ds5kX7CJLXThAoOKQgC?= =?us-ascii?Q?YUtlgr0CQunJwDCp/LQ+c00UHIf0XoASDj9GDNEpskr1y2pfEcO6rKJSC/Nt?= =?us-ascii?Q?8KQoceakq1mOcogTHymwDTo8Zq5MpE9SJloh1X+7rD7JpO/KFlyV1WRZEeA2?= =?us-ascii?Q?BXEYB6acJGfzkzNAUE5UmKhTalvN2Ek5t1qjkW1EUBqVucTXTPcwlTUQ4eBe?= =?us-ascii?Q?cxbZDLIf57LiV/vRXaFhNPHrOCwg8AJbYj/ClRAY+SevVNHl67tpsqHj9skG?= =?us-ascii?Q?rF4b3xJ1CJAuxRE=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:42:39.5974 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2f40bcb-1d6a-4c24-c67f-08dd5019baf0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7839 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=5e89940b48fea2192a3d213f9b67b43d3642a9ae Thanks. Xueming Li --- >From 5e89940b48fea2192a3d213f9b67b43d3642a9ae Mon Sep 17 00:00:00 2001 From: Dima Ruinskiy Date: Thu, 6 Feb 2025 16:08:46 +0000 Subject: [PATCH] net/e1000/base: fix unchecked return Cc: Xueming Li [ upstream commit b0b6b50c20b03170c83985194fd9acef9467ded6 ] Static analysis has detected a write that is not checked for errors, leading to ignored error return value. Add a check. Fixes: edcdb3c5f71b ("e1000/base: fix link flap on 82579") Signed-off-by: Dima Ruinskiy Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/e1000/base/e1000_ich8lan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c index 14f86b7bdc..f5f91a148c 100644 --- a/drivers/net/e1000/base/e1000_ich8lan.c +++ b/drivers/net/e1000/base/e1000_ich8lan.c @@ -962,6 +962,8 @@ s32 e1000_set_eee_pchlan(struct e1000_hw *hw) data &= ~I82579_LPI_100_PLL_SHUT; ret_val = e1000_write_emi_reg_locked(hw, I82579_LPI_PLL_SHUT, data); + if (ret_val) + goto release; } /* R/Clr IEEE MMD 3.1 bits 11:10 - Tx/Rx LPI Received */ -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:03.058190129 +0800 +++ 0067-net-e1000-base-fix-unchecked-return.patch 2025-02-18 19:39:00.678244039 +0800 @@ -1 +1 @@ -From b0b6b50c20b03170c83985194fd9acef9467ded6 Mon Sep 17 00:00:00 2001 +From 5e89940b48fea2192a3d213f9b67b43d3642a9ae Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit b0b6b50c20b03170c83985194fd9acef9467ded6 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - drivers/net/intel/e1000/base/e1000_ich8lan.c | 2 ++ + drivers/net/e1000/base/e1000_ich8lan.c | 2 ++ @@ -19 +21 @@ -diff --git a/drivers/net/intel/e1000/base/e1000_ich8lan.c b/drivers/net/intel/e1000/base/e1000_ich8lan.c +diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c @@ -21,2 +23,2 @@ ---- a/drivers/net/intel/e1000/base/e1000_ich8lan.c -+++ b/drivers/net/intel/e1000/base/e1000_ich8lan.c +--- a/drivers/net/e1000/base/e1000_ich8lan.c ++++ b/drivers/net/e1000/base/e1000_ich8lan.c