From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9007D4625C for ; Tue, 18 Feb 2025 13:43:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8849D402A0; Tue, 18 Feb 2025 13:43:13 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2048.outbound.protection.outlook.com [40.107.220.48]) by mails.dpdk.org (Postfix) with ESMTP id 8C626402A0 for ; Tue, 18 Feb 2025 13:43:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gdsR+lAciObG+ebi8g+5VTrfqw94Eyr1JumA7ouMUpIp74SdBgVK2E5u/C2EX5uoa3cpbjejLIKLJY1ieuSMmZDXSCReKGupBdm2sJNlbxqJn/ZbQpXZGASlTUYkdR0ndiXQj4ITvxW/dzEFo4KP4QROxfbdJKQPoOMZjTcWnpMgAQ44UxnbiqN8Q0EU/7acjBprdrYjrdlQpECHgVjx47/T129iAi/bpxWfA5t3W5A+GHhoEnTtv72zcyjHF1vlSM3OXFDY+lmPiDZT6KB+7O3n5FPjM1f3h+C05GXualO615W9wTEoMS5io7kYeq3nbntrqFmkSPcCAqJIsHKfYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GiW9SaLHMu2FqhdyM2UNhE0qL6y2X2iN1O6+Y/FvJpc=; b=hF1qVy/W1F6dZpRUq0ymVyjtmJLQqyE5NB2tzh66XE88CcieeBYqcSek8gAW2sFNLfAQlV5w2pN6aidZbY2ReXNG0GGvTODRNPFT5bRz8RP6YKQQlvEvoD2NU9HaYOKXt3e/eqjh6SH272wGFZs+P/j8+qTXrfxKjh2hFFEbPEY0EpRPY5SIunWLyja+1albCQSnWKXba1v0M90Kolnipr69mq3Tbu+lKKI3WNZ+IL40OxjuvT5CcwTYJOxUDVw6XRwnMUH1qCDZvB95WK6PaHocFw7mKI54jxGeeyY+hDcAa/LQ4lQus3frd5vXo500MQGK7omHrtNL7DLxdJcbEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GiW9SaLHMu2FqhdyM2UNhE0qL6y2X2iN1O6+Y/FvJpc=; b=MCf5bBansM8LKHttd8Op9LDUViyz0N0RtKdGzFKqa/aTxAA/D+ZkOUh6fMY1RYi0ST+ErDNW2Ac4eXqKotrV4inhE2P/Nq8cNoJqIRdK7pDGUeaBrvRujwY9vwZHIuL71/XApEAqjBvPCk+Yg8tp/NJ79lFhBQQkpGcUqOcAsICkZlt5/vZY/U6WPqKKVerc/JprZv3jseFQZNbxbpEPRfXKK1mz1SUqjiOXfWGFLgd42cxfwYjkE7RJw7PFPwEtwGDwrPqHvhPMUaqe9EwQgDHN0tIvfYUoL2kL1cgKxUxHzKzB/REYajGHvZwEGayL+t4Uq4EptJa0xvHC22Etdw== Received: from BY5PR17CA0066.namprd17.prod.outlook.com (2603:10b6:a03:167::43) by MW5PR12MB5622.namprd12.prod.outlook.com (2603:10b6:303:198::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.14; Tue, 18 Feb 2025 12:43:05 +0000 Received: from SJ1PEPF00002323.namprd03.prod.outlook.com (2603:10b6:a03:167:cafe::99) by BY5PR17CA0066.outlook.office365.com (2603:10b6:a03:167::43) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.14 via Frontend Transport; Tue, 18 Feb 2025 12:43:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00002323.mail.protection.outlook.com (10.167.242.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:43:05 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:42:58 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:42:56 -0800 From: Xueming Li To: Stephen Hemminger CC: , dpdk stable Subject: patch 'net/cpfl: fix representor parsing log' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:35:09 +0800 Message-ID: <20250218123523.36836-75-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002323:EE_|MW5PR12MB5622:EE_ X-MS-Office365-Filtering-Correlation-Id: bbcff8ac-6e01-4be7-9ff9-08dd5019ca56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CFlVgD1IEqVtMimf1vml9DbiN48fEoMOMVB8WtLJQ2p72bzQqu9YgnSbzMN/?= =?us-ascii?Q?WXilt9fWdUFRG9ulrTq4MQ4PUNJLtolOTEL6+0wxZggznBHx7r8JOIOBcGqG?= =?us-ascii?Q?d2xWbnHDtITLqbuyGv2lHfryvGdVxZ2mirFzj0QpbYp3WVHTuQ2i8pvgsH2G?= =?us-ascii?Q?6GsFBS9OColRVdju+HSIDVKpADp4nSJKki4XsBb+jVQktFrmJJWH4NXVikwU?= =?us-ascii?Q?ZRGzPc+FtBNRfb5WHbyZehlYNnXAFsOv+CYzFPNF3i4c8qNqM1whgUz6Vz3G?= =?us-ascii?Q?fy2umqOodT4kJqXIBpYvXD/sm5QLxVL6k0+aebrAFFK0dmPyTpdMsAAa5E5/?= =?us-ascii?Q?uJgyOInFHdPTWWnxuFfIpMoReUXwJawd6i6C6uTDkRcrwm8FhCsuzEyz4MaN?= =?us-ascii?Q?l1a0WfwGdOFwHMMH7FxeKKdu55lS64w2TQ9ehQiQ7EStCKs0URbIb5IiKdll?= =?us-ascii?Q?1AFLlcVR+pB1JEyIUijLv2ufX/f/7rCT4ygY3TvrrkNwAbk9wf1JHSq6Ba0u?= =?us-ascii?Q?L0yWuOGs8QZfHYpomFLfNlwXKH0/oRw6JSPdZU7RH90K3TnjuHKW33TckIMz?= =?us-ascii?Q?P+QNC1/OuVx6Pk3CsIkokuhlYJ3C866CBPLG7ZeeKV6ihoceu1eAbdViozsu?= =?us-ascii?Q?3Z/Sg1qZb09GfWWi/8OMukyNUrGdgBAq4zyrn3oi28zTpoxKYDpXDxkFhyfH?= =?us-ascii?Q?MXs+pX+hf4tJfT525EX1nodmcn0iiS2UKA+o1qYSfunREFhikD7pWFkEUx/1?= =?us-ascii?Q?Bz3zi4voB/98qgQkmlw0AQWzBPBDDNwhhZxuJZrogEN14MY9PgflteJtmmPQ?= =?us-ascii?Q?W+JBFJNSovKsVkZ0yLSS18r7/tqEePKpzTgCzDTI0xJqxXL+OQDV9YcNb+Kn?= =?us-ascii?Q?BBm4EjRxWfY4kFach5acx76rIV853+Z2iDHGv5tnwhpftpJj7GLcW9RPs182?= =?us-ascii?Q?Zv4oR38JF4XwwJKOzP3e7yw+gKTY2jfDbn2GxKcpf+PSVjbweJg5F3Qes9Aq?= =?us-ascii?Q?rbAPAZl4QtN4FUOBhYdRH8KNmd3P+hvlu97YK+St+drWCxaVrZlvcKee0EfL?= =?us-ascii?Q?jgVE3D22yV+wlvi8DUmPyBlw5pT0nx3jfDJ4uynm8psC8To+F87gsMAbmBAA?= =?us-ascii?Q?suvXUHcxBOt4K/ipqWjzlRCu9OKTg4SyuVs5yyC/wBPlBkDGQI75s6FWIjkK?= =?us-ascii?Q?vlNUsQTwQu7jPB+uCa7hTMjT3c4zJew6XNWp25NhdO7pxFaGGhamRMnvAnAR?= =?us-ascii?Q?BWnBHCV3tq0Ea/lWBzBcVcecOhNE7OAKBy7IqBjlvHFmHKQdaGeOzMtMzrZC?= =?us-ascii?Q?6Ggl88yEj9ebAwPScaPTYmpz0DumeS/8JwD8WaMADMQ6q0DKRYnc24N+r2Kb?= =?us-ascii?Q?0J2HhEfXhB8/Ep7ynvzN4y0xf15XZG6nFCP4wNHa2QFgR8vWUOUt0kgxngpl?= =?us-ascii?Q?MYF4evKr256dts2jQh14QHP+Yq02evwANlCb6N6jf+iJ3wr+CNQN70Cq8AWS?= =?us-ascii?Q?/iCBq065dRz32eY=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:43:05.4932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bbcff8ac-6e01-4be7-9ff9-08dd5019ca56 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002323.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5622 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=b72de1a305023ba4c040be69aff2d67593a8414b Thanks. Xueming Li --- >From b72de1a305023ba4c040be69aff2d67593a8414b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 5 Feb 2025 08:23:03 -0800 Subject: [PATCH] net/cpfl: fix representor parsing log Cc: Xueming Li [ upstream commit 7501478b95fc79b178fc525246482215a6018651 ] The log message would always refer to str variable which is NULL here. Looks like author intended to print original parameter. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 65899b9e6538 ("net/cpfl: parse representor devargs") Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 7697aea0ce..c24dfba575 100644 --- a/drivers/net/cpfl/cpfl_ethdev.c +++ b/drivers/net/cpfl/cpfl_ethdev.c @@ -1576,7 +1576,7 @@ parse_repr(const char *key __rte_unused, const char *value, void *args) RTE_DIM(eth_da->representor_ports)); done: if (str == NULL) { - RTE_LOG(ERR, EAL, "wrong representor format: %s\n", str); + PMD_DRV_LOG(ERR, "wrong representor format: %s", value); return -1; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:03.284908990 +0800 +++ 0074-net-cpfl-fix-representor-parsing-log.patch 2025-02-18 19:39:00.708244034 +0800 @@ -1 +1 @@ -From 7501478b95fc79b178fc525246482215a6018651 Mon Sep 17 00:00:00 2001 +From b72de1a305023ba4c040be69aff2d67593a8414b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 7501478b95fc79b178fc525246482215a6018651 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - drivers/net/intel/cpfl/cpfl_ethdev.c | 2 +- + drivers/net/cpfl/cpfl_ethdev.c | 2 +- @@ -19,5 +21,5 @@ -diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.c b/drivers/net/intel/cpfl/cpfl_ethdev.c -index 6f6707a0bd..1817221652 100644 ---- a/drivers/net/intel/cpfl/cpfl_ethdev.c -+++ b/drivers/net/intel/cpfl/cpfl_ethdev.c -@@ -1580,7 +1580,7 @@ parse_repr(const char *key __rte_unused, const char *value, void *args) +diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c +index 7697aea0ce..c24dfba575 100644 +--- a/drivers/net/cpfl/cpfl_ethdev.c ++++ b/drivers/net/cpfl/cpfl_ethdev.c +@@ -1576,7 +1576,7 @@ parse_repr(const char *key __rte_unused, const char *value, void *args) @@ -27 +29 @@ -- PMD_DRV_LOG(ERR, "wrong representor format: %s", str); +- RTE_LOG(ERR, EAL, "wrong representor format: %s\n", str);