From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D51094625C for ; Tue, 18 Feb 2025 13:43:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0221402A0; Tue, 18 Feb 2025 13:43:34 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52]) by mails.dpdk.org (Postfix) with ESMTP id 06C74402A0 for ; Tue, 18 Feb 2025 13:43:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yd3W0wEVLnJoKtW3SBtY9yCqyO2HeHVl8r05bLTOS53hgeUY7pXU+UEW01ddW6q7EtTPZEX3DfDotnz62bhLvic7ZcAwpr7DxONzrkFX4JSgZMvplcaL3vjU2rqElaXrimQ73WcMrxDaVitK2HOsO2QuXJzetjnOYd7630hnyxKa5EUNUclUoc2bafdESt4NlsbcmvkLstK2XVe7gpDU59px432R1IX7nogYPBjdXUJ/GGRyCV98HtXn6MogPzIpVKrV4WoCIyG8xoQJzhjQOJZqaEJNHiLp8EJO5MjXEWmGZdCGmG50L3OreKp6LSBjQltgLATbZL5FtHcsW1W4TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YAhPa6mZnKvcOP1qXPvzGyu+SWK4N2nlcnI4bkDmcKI=; b=ABBeRLf0yMbqwdIg1tJOWsb94U153Q/wniEZdUlLDaAGBg+cLOCKuqnOSkjy4AhHGl9cAT8Lr0Y52Bh59PPwAOJeRTrKnTnv/cw5S/F3BDXe/M/9N7ollN5i+oEivtRzSYVal9qjX0NxwJxZS1uB36qMmFolcqkvNeob/1x6rxadlDDGLE8zxRcpgINzko/lNtvbHHFH7x2kpJY6ndj3481FXKqkhRsy+gw4p0Ja5pRhtGwopLsb+h3KYVIBFYwaR5ddA+0yvZdoxBC2mZlds56SNCmKWQBNenMhz/Zdatn8waa0rlKipEQIZhrfek7OFvWd28E03WemOnnre/g54Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YAhPa6mZnKvcOP1qXPvzGyu+SWK4N2nlcnI4bkDmcKI=; b=KsspKoL09oHq11jHg7ORHo/ukKefvTcegtQq2rl9qMkvswi35qVDRWdXfGeqI8FSP/npR35DLSq25RxpBFauSF75liRxylfpMtQh9OcH2Z5B+zxAXWxY/K8eYIMUQfPTtKhjB3rXxMCNUoqF0sPR/0X3IpqlxM51wAfkQYwNit7v8QHtRUZHf6ncWYHQbTA4VxoY1NQiqZmeE0QuZEg42Zdbm1QpveT49NkidD4oRI2a+x87dTCnm21pRujDBdiKdgyZK0MPKFfLpNEm6Xlrh1vuHRr+h2cSUAaUeh1WFPy2jEOCF5vQ88qlT5DNX5VR7u328z2o0lKxxhjoCeMb7A== Received: from BY5PR17CA0068.namprd17.prod.outlook.com (2603:10b6:a03:167::45) by CH3PR12MB9454.namprd12.prod.outlook.com (2603:10b6:610:1c7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.13; Tue, 18 Feb 2025 12:43:29 +0000 Received: from SJ1PEPF00002323.namprd03.prod.outlook.com (2603:10b6:a03:167:cafe::6a) by BY5PR17CA0068.outlook.office365.com (2603:10b6:a03:167::45) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.20 via Frontend Transport; Tue, 18 Feb 2025 12:43:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00002323.mail.protection.outlook.com (10.167.242.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:43:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:43:20 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:43:18 -0800 From: Xueming Li To: Stephen Hemminger CC: , dpdk stable Subject: patch 'eal: fix devargs layers parsing out of bounds' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:35:11 +0800 Message-ID: <20250218123523.36836-77-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002323:EE_|CH3PR12MB9454:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a2ea68a-9392-492c-49cc-08dd5019d832 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?k1mJT9TwjoKGNQNLC7c9QGXYSfoIL1lK4DYpeI3Hf64TyV54fMuydXbYjcEl?= =?us-ascii?Q?eJbn3IyLZPZVsmXeRv8BcHDJrvS88TOGi73KfpUHgjozZ79iFpEPSrle9fPD?= =?us-ascii?Q?3N1R9gZRdLYhAwsm3Rw7Dh8p/3r4lWlwGhjBd/KVQJsFW9f7y32SyRId1Yew?= =?us-ascii?Q?GmN0wcIP8Tl1annTtqVrCJiPN1pBZnDWgn6DWQJdFcH1/l08V4GspXzxZv3Y?= =?us-ascii?Q?YCw94m2IbSImAmUZXh8unCgAk4DYfMhEo2RApNMo42+2IZaph6h9hsjBBUYa?= =?us-ascii?Q?8OeEAYgDWHiceQlCvwswEEHWOck+ulMMsqI3p+M6BEaPKpdVyyoUc/fkMaSx?= =?us-ascii?Q?LXDJuwN0O1kbcEKVciOJoejrcafuU76am53S4evrj98KijE4OkM/iyowhB3b?= =?us-ascii?Q?lUckdbI9ceH2ezUpUatGE7RvZnlmlvljkshaWXdhyw8wPpDdTakIrNU31McQ?= =?us-ascii?Q?L4Jlk8Lv0Si0oNcklSCpG5E2F8edY4QhH9yzS3ntENL9nv5oOQIa3mIhZKAP?= =?us-ascii?Q?A2pyZFTt8SBXGyh/hA0v2EuRBKRv0eyYcBiVGgS9c0G2AU4WUlIQk1LGyCp9?= =?us-ascii?Q?ES8yTrFqplSDUTqQ5H3EPj9eacfaH+tn7fnMacLGCoN0Zf6WyLgRIZ9iDZHm?= =?us-ascii?Q?QXQbX9bWtlk3NAs8hwLLxuh5fJFv+3/bwTQPvZKSjGWwTe06N++BSRken9P9?= =?us-ascii?Q?SqxwEO/X0eyESPUc97U/5jaKsJEqz+47qA9rzWQEuJA5wY6eAnJblTcHyZJQ?= =?us-ascii?Q?2921cpNgI2DFKWfidk5yuJzrgzw/6u3e/MYTpnl1zlATe2aMod4NqponQGqb?= =?us-ascii?Q?14arfjJsHpo96/F3iDWjpYNOOzyvWAga7oiZ0wTL5iCOihZioV2BeP3MCQJb?= =?us-ascii?Q?z9cEKVIJAJgGVl8XPc0pEws4yRU0SycQm95N8EhHNOtfwzxOZCZJCVM2SSyA?= =?us-ascii?Q?DfN0f8tWCsQ3m2QOPnpfr2nzBpTbnO5mPzL4Sj7XYqSwgEWKk7MYfQl5FI//?= =?us-ascii?Q?J8smYWEJN6E4F5/X4mbAZprKYHii6eh9IzszOdZ8xijhILXRoGGjjravcKrl?= =?us-ascii?Q?mmnW/MW9NOU2zIr/eifuC++Om0XQV60o1jTvLFDPlnMGhEpH5/ZkrbR39NF6?= =?us-ascii?Q?69aaJ291B4+fRI9Lz9aqtLc9yFP3WRWbum1PXPVVpZQNOhxNTDT3FRSBDyI0?= =?us-ascii?Q?JYO+4OhkIgplYevdETL7cBkEAlWrEQ6vAngSvD/+MXVnzsH1mN/G5I+Vl+mc?= =?us-ascii?Q?CrXCAQ6BDml5PmJM+WyGOJM7t8Eb4NollUO4ustjXVy106mGRKGv5nTyo1ed?= =?us-ascii?Q?+6lLNZba1fm6V69ktnSmRcit9JqGDvoGDdMZQJpc68qR//UdL4W2Wt3T2fuO?= =?us-ascii?Q?lXqb1XoFCWWhlqJNiJec19LcC360io4zTwwClptuZ+jm7GZ1FsLHXBvSQIJ9?= =?us-ascii?Q?l41gykWEDP7w6WYPDz09xljCXqlFBq3APsBNBesiy4BhnlWRdVCCsF2F2M42?= =?us-ascii?Q?ZAI0QyOSC1UF4wg=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:43:28.7744 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a2ea68a-9392-492c-49cc-08dd5019d832 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002323.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9454 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=248cf72eda718248d2f6dc7380e7b4d0cfcdbfa3 Thanks. Xueming Li --- >From 248cf72eda718248d2f6dc7380e7b4d0cfcdbfa3 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 5 Feb 2025 08:23:07 -0800 Subject: [PATCH] eal: fix devargs layers parsing out of bounds Cc: Xueming Li [ upstream commit 42f91490ebc97a816ea11ce9c995f455c169a77a ] The code for parsing layers in devargs could reference past the end of layers[] array on stack. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 9a1a9e4a2ddd ("devargs: support path value with global device syntax") Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_devargs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index fb5d0a293b..2f1515d7c9 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -88,7 +88,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs, s = devargs->data; while (s != NULL) { - if (nblayer > RTE_DIM(layers)) { + if (nblayer >= RTE_DIM(layers)) { ret = -E2BIG; goto get_out; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:03.349516179 +0800 +++ 0076-eal-fix-devargs-layers-parsing-out-of-bounds.patch 2025-02-18 19:39:00.708244034 +0800 @@ -1 +1 @@ -From 42f91490ebc97a816ea11ce9c995f455c169a77a Mon Sep 17 00:00:00 2001 +From 248cf72eda718248d2f6dc7380e7b4d0cfcdbfa3 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 42f91490ebc97a816ea11ce9c995f455c169a77a ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index a64805b268..dd857fc839 100644 +index fb5d0a293b..2f1515d7c9 100644