From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3CD04625C for ; Tue, 18 Feb 2025 13:44:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C2A94060B; Tue, 18 Feb 2025 13:44:11 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2057.outbound.protection.outlook.com [40.107.220.57]) by mails.dpdk.org (Postfix) with ESMTP id 90C85402E1 for ; Tue, 18 Feb 2025 13:44:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B+U9qUuCPBbyxS+VZjGDD8xeF4DkGDTzwynIhQ6utDExHEFI+RxZdUHNdf5Nq1baj2byiO6I6wnbqU771BW2ECcCZFWaQGuCrGvquhiY5NHjoiawx/3J+6zyQAlqaK7Dj9e7OCjvqF282GZQIV3rDKOAhrh8dzlW+wexsZNsjMTEFF73fcyBIIDbf+ULzcASGC3sqNmh5zm/4Cm8/X4BA2cBJCZd63DdSHmnhmtnWYM1nlxcApNQ079FZvsJkbPLsYdUXLi9rkaz9tMRJhemV9AsCHMcQJ+3R58r17E7lYF7JsFj8dVyoEmoY49LvMgHuSGHMhXZ+q1gAFddSeSZxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rWNwD62pwfibxMQEgIvtYfce6WtsPkRKqRtsrArR0yU=; b=Yu/7hfu3JfnUYhkrcUk6zalMQ4xuHYMQSg4NgqRxLekrvdnjx6WLidk9gx3sfOGdtRkNuLQmi+P1HUqGq49KJfcQ0GHd+ZLItvo1hMi2B38wrI2gescXxsEIw4vg81KA9sbPAa3ymmiZxlUpypjwN4r2D4fwZgbOYQZ1fALv0Yw2IXHSawEw1F5EUrJOGN8JmgTigywA0PCnLe3Syu3I0xsB77aZWKTZsyP+HKUC82QpaLVvlm7QV2fgL9BviY2pVcHJ3StXHV8upzsXn5jw/Cwu0drV2G7W2ZxDgAoS/KUu71zO+L4FN79AKjhxO2Ks+xdpEN4r22iq6ys2dEuDdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rWNwD62pwfibxMQEgIvtYfce6WtsPkRKqRtsrArR0yU=; b=Cqz2nO7SL05ePb/T9dblv40qUQGIubREVhdNUzyFK0gtO5KgscCO13wXQ6zAwvdkzFJccH8snDofiBQiv8dw7s9/UkL5OC/qFbpp+2VzsUNu6wkgBhkHCN35RhejfHGIaUKX7kdpPlgFar9IbSv2ZC6yGKUt/mbCPUXysDl2r+836L543XItWEScWtW3XIIxPjWbgR+4Pof5TugsojH4zFmdU4DWFa2dso+s2nOn4cXWNgWG/5zX6NSc26x05hfn/3pNzB7t/z4M7O4kR/U3MRIS1DTZvRFUhIKzjVglxswZ47rQlPopfRJZaSMOrLcMwOk6uzKF1+NKCfrd3MCzpA== Received: from SJ0PR03CA0091.namprd03.prod.outlook.com (2603:10b6:a03:333::6) by MW5PR12MB5622.namprd12.prod.outlook.com (2603:10b6:303:198::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.14; Tue, 18 Feb 2025 12:44:04 +0000 Received: from SJ1PEPF00002321.namprd03.prod.outlook.com (2603:10b6:a03:333:cafe::43) by SJ0PR03CA0091.outlook.office365.com (2603:10b6:a03:333::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.19 via Frontend Transport; Tue, 18 Feb 2025 12:44:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00002321.mail.protection.outlook.com (10.167.242.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:44:04 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:43:54 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:43:52 -0800 From: Xueming Li To: Stephen Hemminger CC: , dpdk stable Subject: patch 'net/qede: fix nested loops' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:35:19 +0800 Message-ID: <20250218123523.36836-85-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002321:EE_|MW5PR12MB5622:EE_ X-MS-Office365-Filtering-Correlation-Id: eed1d843-0858-43e5-2cff-08dd5019ed8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Ef+eEXpM1IcaOLaQwggE0dd2L+g+AC34otFBpDazxz3njqcc17ClKyvv7ckQ?= =?us-ascii?Q?gem3mwXzS49ZdUmIwvt9CumGb9Ef/z+Hwp0CZxeC4WG9pXnqqI9ROcyxQmvU?= =?us-ascii?Q?lEN1MNzytLL0/r3Zdmn9jHSGw5YL7uCM3k45nGdWAGPgU5IdX59ADV8ULY5A?= =?us-ascii?Q?Ic1DB88Y7c6jCWCCwVN/ZBLAT/tGNrtt6217IkplOA9+73JzEzpfYqxaO9QF?= =?us-ascii?Q?no6RqcWVDP+tA0LoYisw4kNFmq4eFVqsZUBFwjrUzKRtvcneD7XY/VZS6VRr?= =?us-ascii?Q?NIBCIuBy7A4ZqGrGrsCQXGcnX3VQovEHv3xBGgeRz1J2wtxR7JcXGRdALAed?= =?us-ascii?Q?qg22Az78HMzaH1LRMYEfyPeJtr2Mz6EuZ1c4OWLnjBzNRK2eJH3j0ZXgEwUI?= =?us-ascii?Q?0e38fyUdPlLqUT6cugrqpuZ2xhqw8lLFUy91FPuiGoVITPnkr4gArCiHgiDi?= =?us-ascii?Q?yUybrv7YIW6S9oQx5HS43W0nwyGJfa2ANLcs2ia9ypEOwXfDweqEKv2FV/d9?= =?us-ascii?Q?o5s0YbaHj3wBWa49p6IiKii95wgqMLKJxcKIOaadkCiixU1Bk8U0iMPz/v8E?= =?us-ascii?Q?laN1giJH2ERT8eU7syXoSwWGO4MAKim8urQrG/sqhNdLi4RMy5Vg7zRSxdCB?= =?us-ascii?Q?FOkiZxEqx5Ex5Ebs2weeRPDTAYtjs9B7ZqI+ejJ6POjJgnTQtBkDrp2r3Nhv?= =?us-ascii?Q?oTV54oO//o3/FuwG+t4jshIv5IDUauveEanrhkM++eHUXT4BDBNOYFdQSfzf?= =?us-ascii?Q?YMkA4iqrI9nDyrvzSbDNzm9bqp1VRSeoIK/D+ZtuJ7NzVpLEfJq4LgO1cQdD?= =?us-ascii?Q?rrbjiDv3VUD63r/Qm/3J9DZkT9np/anZ00+HazkwQrxgZUe40w8UvqjiztMd?= =?us-ascii?Q?FRT3xx3uSQexkpojT+p80CRkkVbI31ddRnG0dHSHXotbNaZv+Lmfs/8X0wV4?= =?us-ascii?Q?DjkWxjtH+MH0MaXzutppSwjPw/CeOAmEGFG2t3RGPL3iySSJdffyOyQIj2DC?= =?us-ascii?Q?OWo9uWbqZq7bjgd9kwXQZvCHeECI8pZT6k1CkWG8FGRa8YKBmkwhP2aIX+cI?= =?us-ascii?Q?ddMW6rD3FtWKYHZGCSMi+CCuKp/rF0CEUBQC8S6Rss3zNpzKUzsYJBHbDci9?= =?us-ascii?Q?wcsomUv2ge2heg8Vzr2hQ6brNRG/DjejsINdFbkLYm7Hhfq6KReEI5RY1LdQ?= =?us-ascii?Q?cFS4L3LtbB3Mnzc9dUbfflHw91+IPm7d4f7u05iVQRYh6Yp1Mw4Q6c3cHcAd?= =?us-ascii?Q?YuOpSU3ONUUxCmyO38HrdiMa91jUgjr97VwfD1fkKjVONfaAamZascKNHLfh?= =?us-ascii?Q?r58KPmtXw5hH9QwLHu0iMcqFfGwy4sX2f6+w5K/JaOigksLMXlLkGqcqOuwg?= =?us-ascii?Q?0mWNNLukva7uv6onIz27wiKNz6sF3dDCo7F5X5hfokbLUDHBe+XARCYI7iQH?= =?us-ascii?Q?m+x5C7TdxmRH901juVD4omNHvHTw5BJ7Pia3B2DzFseFM54a28EAfgSoWxd6?= =?us-ascii?Q?2vKRfAxB61Ijjlw=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:44:04.6022 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eed1d843-0858-43e5-2cff-08dd5019ed8d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002321.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5622 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=14ee2e354918873110f7d602138c08fceff0f485 Thanks. Xueming Li --- >From 14ee2e354918873110f7d602138c08fceff0f485 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 5 Feb 2025 08:23:18 -0800 Subject: [PATCH] net/qede: fix nested loops Cc: Xueming Li [ upstream commit c8b3833965dc84914e94776cadfc8fb48c34459b ] Using variable in outer loop, and inner loop is obvious bug. This bug is in base code, so likely on other platforms as well. Link: https://pvs-studio.com/en/blog/posts/cpp/1183/ Fixes: 81dba2b2ff61 ("net/qede/base: add LLDP support") Signed-off-by: Stephen Hemminger --- drivers/net/qede/base/ecore_dcbx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c index 31234f18cf..72bbedd65a 100644 --- a/drivers/net/qede/base/ecore_dcbx.c +++ b/drivers/net/qede/base/ecore_dcbx.c @@ -1363,7 +1363,7 @@ ecore_lldp_mib_update_event(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) struct ecore_dcbx_mib_meta_data data; enum _ecore_status_t rc = ECORE_SUCCESS; struct lldp_received_tlvs_s tlvs; - int i; + int i, j; for (i = 0; i < LLDP_MAX_LLDP_AGENTS; i++) { OSAL_MEM_ZERO(&data, sizeof(data)); @@ -1381,9 +1381,9 @@ ecore_lldp_mib_update_event(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt) if (!tlvs.length) continue; - for (i = 0; i < MAX_TLV_BUFFER; i++) - tlvs.tlvs_buffer[i] = - OSAL_CPU_TO_BE32(tlvs.tlvs_buffer[i]); + for (j = 0; j < MAX_TLV_BUFFER; j++) + tlvs.tlvs_buffer[j] = + OSAL_CPU_TO_BE32(tlvs.tlvs_buffer[j]); OSAL_LLDP_RX_TLVS(p_hwfn, tlvs.tlvs_buffer, tlvs.length); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:03.613071934 +0800 +++ 0084-net-qede-fix-nested-loops.patch 2025-02-18 19:39:00.728244030 +0800 @@ -1 +1 @@ -From c8b3833965dc84914e94776cadfc8fb48c34459b Mon Sep 17 00:00:00 2001 +From 14ee2e354918873110f7d602138c08fceff0f485 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit c8b3833965dc84914e94776cadfc8fb48c34459b ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org