From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 385D34625C for ; Tue, 18 Feb 2025 13:44:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32DEB402A0; Tue, 18 Feb 2025 13:44:39 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060.outbound.protection.outlook.com [40.107.93.60]) by mails.dpdk.org (Postfix) with ESMTP id 83C02402A0 for ; Tue, 18 Feb 2025 13:44:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GJo7mRQkHkJlsJqjEvGT4v0CHViiXxoCBiNffa6Hp+QZoisNTwK9C2FzJC27y7Fti/vAYnSygG+TPtH9jVBOjzo1in2TqBqHbN48zpGRqepMTpmrnriWn6+ro+LXkO4ybvTmwDY/hogutVdeRGkWYVHBhZP0nRsjsM1RLsT5AOUsTOuEGrzyxahbwcK5a3EFaL+d7GNK1P6Biw0CH43+iAagfkMEyolGpYGPGTEaK9iJ6qi8gjO+4MPAEiUSZV46DQtmRxocGvVzG9o81EZEZ/x+Fc+HhZSkYX1F2luRzjvhrSBLfHncGb5ySj7QoGSFjajtqo67BSl57DT2ozln8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=65Hibf5FWLBkO68sdqmunpjJTxUD3CxgQOtcG/sxiAE=; b=ITXYsLtORQxxiEtURznMxbwYXv/a9GSZ9VooUGMh7P9L+Tv8WLWmA4NR6kIPnogyJ6SDvD31bSAlyAE8iPDXYzCZjEvkL07iP5L1R08JDgHeReHO1SSMN7CevMGLLWpTnbl0hab2yA6S0LuuE2qxk3teFCfmvsY9yYlFbxfLHgM9nAAFRoafhGzxq3AlrZZcaExE2lu9pHDy9GSpZR4IC1j1wQOC/HcTHirzUhiJejPAYJowMCJbKE5jyxAQaPmsj6lFk/NjmGutARNnI5PDd7qIuw7uWFnolcc92U3yjnRFlnz8O5khD2DTkqegidCkLl5K40a2fasca5kd1jPJBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=6wind.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=65Hibf5FWLBkO68sdqmunpjJTxUD3CxgQOtcG/sxiAE=; b=pA/L81PvSgKj9A1DFy/7qmGuewBeDMoYxRsZxwqYcTl9+AT8W1HDDw8dSPgrG6Jt8Io3wmFa9NJXwWGD/89nIoVGRTxn48fiqUGaGX7wjYJT9N/p4zqkfMyo4pnQod02+w2O+6AzmlW5neXpqU+ECGibyWoEeDTSmb6VkCj9eGSkWsUJuOiHh4YJJEjna20BGmhpc5ELTm4xnRK7UfQqthJikc9hBkKZCLSU8n5rkK9MvtzXuK77fXIi3xTmFCG1bt6k6PIstfrEsaNH7KCOGH2D2TKqzSI97nB/DHgsGahaBBp4Mu0RXmRoB4TrxmFFUzvXhlaX/RnoIpIBusQ4HA== Received: from SA1PR03CA0003.namprd03.prod.outlook.com (2603:10b6:806:2d3::14) by DS7PR12MB5717.namprd12.prod.outlook.com (2603:10b6:8:70::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.17; Tue, 18 Feb 2025 12:44:32 +0000 Received: from SA2PEPF000015C8.namprd03.prod.outlook.com (2603:10b6:806:2d3:cafe::79) by SA1PR03CA0003.outlook.office365.com (2603:10b6:806:2d3::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.18 via Frontend Transport; Tue, 18 Feb 2025 12:44:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF000015C8.mail.protection.outlook.com (10.167.241.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:44:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:44:23 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:44:21 -0800 From: Xueming Li To: Ariel Otilibili CC: , dpdk stable Subject: patch 'eal/linux: remove useless assignments' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:35:22 +0800 Message-ID: <20250218123523.36836-88-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C8:EE_|DS7PR12MB5717:EE_ X-MS-Office365-Filtering-Correlation-Id: 90f28507-6708-443f-0929-08dd5019fdd5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|376014|1800799024|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?TXVhRBh9qCxJAYeYu6wsJlAuY9LGKXSqmErUBvCMvKJXQE1ZV+S+Rgjqxxp8?= =?us-ascii?Q?SKJmzUSbNBwJYWNTtbgeX1rCbPsxTdLneKzIIBF8nnXNyKEqVGWl+V7dxkTW?= =?us-ascii?Q?KMcJrwHhvSriIOOD2QUTyiDQe+dry5TQIFJ+wdf0mrKT6fZOQqA9Wr80P0b4?= =?us-ascii?Q?9NeGvFQdoA6FFZjeLRx5WRFYLIg0u5kIzX0WyRr/DlpNXRD9ry7t8DZQtg70?= =?us-ascii?Q?hnRbucEkpGYDLc8m275Gmi0ux9kzfFfB9S5AIkiXTV/BvEtp7fwk4xunvpDd?= =?us-ascii?Q?zNoe7stl4ajWVAcsGlvwPmYOi4E0W19UMSWQ1Pyao8Q9omyh5+tb5iOpNBqA?= =?us-ascii?Q?WKp5dnFgvcliCcsn7j/KB6CbbQZSbz+YuuCzW+13RJ8RF2euKKeGdocJVqt8?= =?us-ascii?Q?DiVeylWomGwTygdJIHT1Wm0266usC0WLQXY423ASKV88sclyolqvOl/GsViz?= =?us-ascii?Q?L/0a9hsPkaakOiejzniPkkLZhJbTmX5u1ca8VHUESFkqCD7L0U1iy1xOmRgZ?= =?us-ascii?Q?GioORI2Ojdt+iBWV2VGqUmNeyK3W3vszjJ44KmyvxP0mlOin2lcYS7YUzbIF?= =?us-ascii?Q?SVLOnjQ9e5OtHatY6zuk/9vielxl5wbKLJEpWRsDyVFk1pfTmfvxToek2UsO?= =?us-ascii?Q?QrE0BsNzaggJfDK90arIilQ/ystNW/769Y/1VmK4qycRi10hlA9PrnUCt/FI?= =?us-ascii?Q?4agTsp3fkpqA6FeCAKuVSb0WCWZMCskPa8PnpZfF7Ka9Ar/SNr6tLxjCT5hV?= =?us-ascii?Q?m9irDQsGIis0HXzX573XHtsNc9hT8hEsdvuf+db2IpUz0rz5iULgob5HCujV?= =?us-ascii?Q?7NO1t+tlKn5wt61J2SJ3CKEafxracn/LQlNjKQFKgmSkRMQqtKFszFRtjM4j?= =?us-ascii?Q?6VHgBQy0s6tZYbwLjlToIVmWgokz6nijvjFO6WIXAIywqmrqzJAYO5TU6j7N?= =?us-ascii?Q?meiBiPPYsmb+HGjFSzSZpKqK8QXKRYOPteqRMJTJ1IhSh4HPmDiZjYJ7KCZt?= =?us-ascii?Q?3bvtq6uOmCqaMeF4b/I1+FIw18LjsoNCG0QhCIADok2ZIpTA+5jD0hew03cj?= =?us-ascii?Q?XBsDl+I8NpLv0EHe9/FRfO1VVprI8yBZ6v7ff/BIiVoMBn/Aw+6Q8ttS2yvk?= =?us-ascii?Q?EfNCzOoLMTmfZAboiHas8Hbb+cVRgwTYHYqNdvjXQAhyTwUM4hFT1SgKU50U?= =?us-ascii?Q?u/RRev2Cqx/AFQcwY4olI3CuJfNmXnigQ8c95gqYSo9FLU4cQsMosqir0biI?= =?us-ascii?Q?VZ1boqalHadoN1D7/xsowG17+7/sUh/VA1y51tVd624IijGILyFb9hBrdolI?= =?us-ascii?Q?9noaP5an5hHUCLIqPzwr6zCQKj1K4ZKIg3skxosTx8wcO+S9O8kCW6OjKnK3?= =?us-ascii?Q?vZ2pzsz1srzzRIghu/tTY/2QET6qHt8irrT/vT9hhOLsU1ym5IJX2XQCcPG7?= =?us-ascii?Q?E9uWr5B7nqoZAEV3i1mLwZs0UPH90s1A6BPuN8LzfE0eZvoYD0Rf+qvUZ4Xb?= =?us-ascii?Q?soJyoUkWMfFpHlU=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:44:31.8386 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90f28507-6708-443f-0929-08dd5019fdd5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C8.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5717 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=2a8873d4ce501d6c623ed204b04d34f54d8c91a9 Thanks. Xueming Li --- >From 2a8873d4ce501d6c623ed204b04d34f54d8c91a9 Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Mon, 13 Jan 2025 18:19:20 +0100 Subject: [PATCH] eal/linux: remove useless assignments Cc: Xueming Li [ upstream commit 36128ec5d93591700b72f3fc01bfe6216eaee905 ] Found by static analysis: In dev_uev_socket_fd_create(), fd is assigned before a return, and not used. The same for the variables buf and i in dev_uev_parse(). Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle") Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Signed-off-by: Ariel Otilibili --- lib/eal/linux/eal_dev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c index c0ba98852b..0d9053b409 100644 --- a/lib/eal/linux/eal_dev.c +++ b/lib/eal/linux/eal_dev.c @@ -129,7 +129,6 @@ dev_uev_socket_fd_create(void) return 0; err: close(fd); - fd = -1; return ret; } @@ -165,8 +164,6 @@ dev_uev_parse(const char *buf, struct rte_dev_event *event, int length) * uevent from udev. */ if (!strncmp(buf, "libudev", 7)) { - buf += 7; - i += 7; return -1; } if (!strncmp(buf, "ACTION=", 7)) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:03.706393117 +0800 +++ 0087-eal-linux-remove-useless-assignments.patch 2025-02-18 19:39:00.738244029 +0800 @@ -1 +1 @@ -From 36128ec5d93591700b72f3fc01bfe6216eaee905 Mon Sep 17 00:00:00 2001 +From 2a8873d4ce501d6c623ed204b04d34f54d8c91a9 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 36128ec5d93591700b72f3fc01bfe6216eaee905 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index e63f24d108..be97f56424 100644 +index c0ba98852b..0d9053b409 100644