From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C0034625C for ; Tue, 18 Feb 2025 13:44:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5685A402E9; Tue, 18 Feb 2025 13:44:40 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2080.outbound.protection.outlook.com [40.107.94.80]) by mails.dpdk.org (Postfix) with ESMTP id A03C0402D8 for ; Tue, 18 Feb 2025 13:44:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R7XYCfi8U8O2QqVjwJGMpYYyyMftx+6F1mOR4HKC4QaxU2Vgde3qKPxt6JbHbgEg321fyrBiDUmNeDChSdqv6DSm9wExc2iq4nOL0POHA3rsgc/bqJMD3FDIWJJiflS3TW9EW8+G96MOtNNrNz2pz/6JMbZh23dBu8ATndGmaDxoP2xtisbwq6OHBJd27Wg9L82t2Pc0d4R23I2XBA4pLrV5Nu4dO8Se2m3oOQc68oGsfYgkpVWjcQf/oQN/uLBV1NJ7My2Hgatq0pnRuP1ND1Up4fVXUsfKeWzPqzqwD3EVl5Vg2vURypF/L4rKGuZr3vhDozVwzYYM9DcSU33Eig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pxR+kvF6+npoKTEIF8exL1b0k3tL/qCm6GqBZFbXsuA=; b=sdidorc5oMDDxxdGhjA7FWcd7/atLutGeJ1CGDG3GLlN19+ZWF0oe0f+ftzXh5VrDjCJu7SjP894KRjFvn8RbyDpjYTbVqYkcv28E2wUg3QkKFmQslHSu6sWRb+cqUWRFzA4NYgIxwc/mIFMzIgYdly/s7O6sIm42csIBhjhe9bxkjpiNNFHpTvNxWaMHa76Try61MW1fD6sKY8iF7l2KR+jN858YM9cUmxLPlQIzES5FQJARfApsv9hh7FHW+y/cCF97YP3ywHwbsVc0pSe34IvmYi8pojbQoYb7zxC8nBWLZlLRKLDUyTrzQi/2K185Zqn0s/qEcxGCTBdZrrzfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=6wind.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pxR+kvF6+npoKTEIF8exL1b0k3tL/qCm6GqBZFbXsuA=; b=VjNwcN/XVBt8qU3qyr5w+AxSS9/WVtacxHcNAT+V3FDEHP6QyDzdMZTaGXZ2P9ehTt8RF8z1E0jAv1HExAGn4wjIKe3GjlTSdxI1RksIyIM6Urv40k/+ETXsmFtGsC1Z0Wyaj1cBOJW5SdG+UVoWhhsVYETt1qGzKWc1OJbAxqy+e5mJA0PJv1tG8/roqvtqNblmSudLZPsdAVonqPgXwhIDKcNH3vIM15Rh5GThry+mBsWf1d1RqYY94e3X1sLfFfkS2P6/QjSDTYGPn+AYk7wbNB45Uw3qgYS4vgmms5lv/aYSClxwCM4RqFTH3pfKkkXaY/qpjmI74yNtVCuOWg== Received: from SJ0PR05CA0122.namprd05.prod.outlook.com (2603:10b6:a03:33d::7) by PH8PR12MB7351.namprd12.prod.outlook.com (2603:10b6:510:215::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.17; Tue, 18 Feb 2025 12:44:33 +0000 Received: from SJ1PEPF00002321.namprd03.prod.outlook.com (2603:10b6:a03:33d:cafe::84) by SJ0PR05CA0122.outlook.office365.com (2603:10b6:a03:33d::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.13 via Frontend Transport; Tue, 18 Feb 2025 12:44:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00002321.mail.protection.outlook.com (10.167.242.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 12:44:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 04:44:25 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 04:44:23 -0800 From: Xueming Li To: Ariel Otilibili CC: , Chengwen Feng , "Konstantin Ananyev" , dpdk stable Subject: patch 'mempool: fix errno in empty create' has been queued to stable release 23.11.4 Date: Tue, 18 Feb 2025 20:35:23 +0800 Message-ID: <20250218123523.36836-89-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250218123523.36836-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002321:EE_|PH8PR12MB7351:EE_ X-MS-Office365-Filtering-Correlation-Id: ae5c8b3a-43b3-460d-88fc-08dd5019fee4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|376014|1800799024|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Bc7uiZr0D7tUvzZnfPe/Tm2AaJImdt6+beVPhNCx+c+n1bXsM0uEV93Bb48X?= =?us-ascii?Q?1GevL9mg8UMVA/k819mVNvlHGDIrIv6Q0RrkWhPJ0DaISG3Hkhn2J3ObtN9m?= =?us-ascii?Q?awBcEQk1UzaS3OxkRyjIyXZL9c804yphlYxLavA8R7Vnxjk1uoQjZ/GsQ8Sd?= =?us-ascii?Q?Tz8gJgAZYe0RqJq6zsAn+BXxdc48lTikpXR2YfnmpqfMXjP+FuI2+H/OrtrO?= =?us-ascii?Q?+fK8PsZg8FbyIgqs1suQ2eHoP6IHt6G/zAOU1x1Drycs+QMPuptPlkQAcEZF?= =?us-ascii?Q?Y+qDUabCpEBkhvQIauvwKiwcv4laKa9jCCU925Kn/w1w/mV/81FtCqSJ1QtA?= =?us-ascii?Q?dFcP4M/4x2XhSB/yAJS3uwKF1keRcdfTLvOO8f1EE+IDTn0QgrKsUMWWe9ba?= =?us-ascii?Q?KRYwA/O7hHzdxwPg1mxhAdErieMmntpZMo+Vo2kBhwwWklpTsKNTlxDesilx?= =?us-ascii?Q?x/B47VRNdbK67D8a57YpuCk1EEhhEpe01c0VrUhessEtzeT+pwKv4vqZgf4I?= =?us-ascii?Q?0AX7KkDObO+h/gL5LGJr/PR6eQ8KgzZAHPb4fPoRkHvzLGL2IskY6YsMGXUU?= =?us-ascii?Q?VivXSwFaTztKgXE1ZzR6PvWp5CY/NE8ymFMoJ5EpUjrRksiqWvsIbBwVblGb?= =?us-ascii?Q?V+C1AaIpICC1AUYtdZ8j57UPdphHbDKw6oNRrN83kgqlSmuMl3uBhfcfrLco?= =?us-ascii?Q?Qs8fslfGJYFE3aJ5XXETerKhwDqBeuPTHnK8lu9mU9ucTaXDe7Pb03xm2KfF?= =?us-ascii?Q?TabIKr3sK3L51KUDZhZpIP4HRYMfgTDPIG7J2ejiGFgCvD+lgtLGkR2qc5q4?= =?us-ascii?Q?+LbARrZATUeFhFKfEPjDRVGlWhmv0Ug3D9wbyLDKMvgdWQyVZVAYfF/HiBA/?= =?us-ascii?Q?JiRdHhoYH31AjormyzyUWkZ+37ch+cYpxmi9zMujtDVKRXP7ZE6b0z13m1XJ?= =?us-ascii?Q?VR3hsNspCLx4/mGOidGKQ5NwnjnlMgk90/dc/8JjGzNfL6cvi+s5igZTNJ0G?= =?us-ascii?Q?wSqGOQ6ny9kfnKm+ERQRe5zHGILqkFaRGBLF0qyOrbUbprmtOPXBOXeXwEFG?= =?us-ascii?Q?xGwK4XrbDzuqoC73IAqtYCFsuBHjkl3NhelIW3yXClDWF5GZZ0X8KELqljBj?= =?us-ascii?Q?x6YD2EyAbQnIrIARbul1tBvsDv+AnCJKwHlZjjWRVa7X1k0ejMb66qjF9N2u?= =?us-ascii?Q?y+IgMP9L4gytT+6SAKm9qqavQMchpODpvQntNob1oWdK71uQJu252nykxCJz?= =?us-ascii?Q?bThLn0XpaqtiNCf0nClSBHqJefMaO9EgxqSVk5GGauEV1QDeVXY+ffe4DYo/?= =?us-ascii?Q?B7jSGWohKCFvu6l6Db08RC8ceqhwkndrT5gpD/M+TIp1xd2xvaYA5PHmJb2V?= =?us-ascii?Q?Y8X8yfDLOJOUBTqSPUzViz9+CEf5zPrLxL4qlehOXYBxWNUeix8SnjCmrohg?= =?us-ascii?Q?9GJJtDuF61NT1NfU7N9Mw0lGDwZ0OafBy1YQrmmEHfBx48LpdayY/hcBeo6f?= =?us-ascii?Q?z4dQiYAuLJ9nMAc=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 12:44:33.6804 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae5c8b3a-43b3-460d-88fc-08dd5019fee4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002321.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7351 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. Please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=5a7e0e1cfe70bc32fc87ef7141fac01bc27ae73f Thanks. Xueming Li --- >From 5a7e0e1cfe70bc32fc87ef7141fac01bc27ae73f Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Mon, 20 Jan 2025 13:21:55 +0100 Subject: [PATCH] mempool: fix errno in empty create Cc: Xueming Li [ upstream commit a81d8ceff4e961995c78df6dbc9353dbbfbd8c32 ] When returning from rte_mempool_set_ops_byname(), rte_errno is not set for error exits. The API requires rte_errno to be set in that case. Bugzilla ID: 1559 Fixes: c2c6b2f41305 ("mempool: fix default ops for an empty mempool") Signed-off-by: Ariel Otilibili Acked-by: Chengwen Feng Acked-by: Konstantin Ananyev --- lib/mempool/rte_mempool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index 7a7a9bf6db..038bd967ab 100644 --- a/lib/mempool/rte_mempool.c +++ b/lib/mempool/rte_mempool.c @@ -927,8 +927,10 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size, else ret = rte_mempool_set_ops_byname(mp, "ring_mp_mc", NULL); - if (ret) + if (ret) { + rte_errno = -ret; goto exit_unlock; + } /* * local_cache pointer is set even if cache_size is zero. -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-02-18 19:39:03.739092212 +0800 +++ 0088-mempool-fix-errno-in-empty-create.patch 2025-02-18 19:39:00.738244029 +0800 @@ -1 +1 @@ -From a81d8ceff4e961995c78df6dbc9353dbbfbd8c32 Mon Sep 17 00:00:00 2001 +From 5a7e0e1cfe70bc32fc87ef7141fac01bc27ae73f Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a81d8ceff4e961995c78df6dbc9353dbbfbd8c32 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index d8e39e5c20..1e4f24783c 100644 +index 7a7a9bf6db..038bd967ab 100644 @@ -26 +28 @@ -@@ -928,8 +928,10 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size, +@@ -927,8 +927,10 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,