From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 493EE4626B for ; Wed, 19 Feb 2025 19:46:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 175FC4014F; Wed, 19 Feb 2025 19:46:00 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id A463C4014F for ; Wed, 19 Feb 2025 19:45:58 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-220e83d65e5so841995ad.1 for ; Wed, 19 Feb 2025 10:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739990758; x=1740595558; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=JqWEJ+iusIh3WGYUAKhkQ3qSD1adLwMYAmrB8kn95AQ=; b=QtejmxGhaLvehrbR6etzljHAT6amDGV8f+h+8EVhsu4Oyl2T6NlO1mbPbHl1BrQBnO mtAItWFAprGwBBxMLmGv6pQ0AL6RGzRV96NdB82qjmApdBZOkCn0CWWw9jPsrOJ2UrwO YHPUolWPi88XTh7lARbSNDzOrcq6DrD5RMsW1Fi69tOv+n6Rr9bx/WoTFcpusX2yEOlD wD3lnDOB+D6UIdUQjjYqhKvwsMvT1oNaDb9fWPF+4E0s7EkpzDIi4Q3mcfYWmtA5FgFO uESgmgay70/mUsGwv6VkvZgBxlaBNN0xe8Zxy39EMZoZj7ur/oUSQTvONLnTtro3UYe0 Rojw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739990758; x=1740595558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JqWEJ+iusIh3WGYUAKhkQ3qSD1adLwMYAmrB8kn95AQ=; b=BAH5jELT87YDrp0sM3trkIxbahJX8CjNmTkArYbZjyFVwxASFnYyZxQDATPQbAKCBa Y/Skh7iwS1U8ub9WdkHz0dwlxHSDbBT2U9aUYZuk4exNbBuPAqZhiEDq2hmuolxr0QO/ xXgOldEuJCLZRCG1aW57a4Z2VMpvKCXmUhjcDvoFA+EtChyZwvSPWuEnmr3cpvhXp241 tYUzNLqwFCxJCIiSvJ7JpJhZLsb37kv1R+ckLWKkXXq2Qb7Idh64WrM6b754VbyxlBqT iUCpwLL2GN2JGZt2T4iNW5H7Fjwz/x8eBm7mQD5niq9NhsldgpVLxSJdYEDEbsnRr9T3 Lo+A== X-Forwarded-Encrypted: i=1; AJvYcCWfrKdeC0VyxxgCuESCr3/P5WfoxRP3od4+y+uZ6ceXj+lHBNrx6iMrSHLbhMJaZP/exZIEMVs=@dpdk.org X-Gm-Message-State: AOJu0YwdCyjPdw9we41S6fVJbZ7pgGTMG5jsJRxVJEDpceaN1pl1+/kf 0/wGKZbnxtbdGosOgxipdf/gUYrcJ9IAKizYTpkKXDGPcidiQXjuVS2uotIy9I0= X-Gm-Gg: ASbGncs6Y8LIXm6soIhf89g3RLUv37vFJCUHsgqmnWza2ZwOtUVD7sMuEG+a4Fz9ARQ 5evrk/Z2AOSU8E3Yj/qvfriGJwhKII3fU449h0pxxgyM9BmshGFqA7XcwntnEbMXIOFqhPjNGSb 4NjFOMu2p4WHkGxpD5mDWKxdTFPChw8VC60WS5+6F8J9sQ2PiI0nG4kUynAc3z0aO8v1zZyjgot BUjYwAR+PmcLrQyw8mgTO7uRL5rMYrzKIXWHzwq2S1HWh/uC5fz7xH3hWvz6vamAJ5RWcIdqCF2 Ryad2a6wPnBbif4swD7VeI8xXi7c0Ak8M+7Na/fXbWuuK8UTqgYs31z2j8+2Fe9qtAfu X-Google-Smtp-Source: AGHT+IH1PlxVqRHYDVd5IgXmEj3ZllkVTnZxIxUZm4nPU+qB35aUXhq0ZIKteRWTe7Dt7irisRLzVQ== X-Received: by 2002:a17:902:eb83:b0:220:d078:eb28 with SMTP id d9443c01a7336-221711d1730mr77509825ad.48.1739990757676; Wed, 19 Feb 2025 10:45:57 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fc13ba6285sm12287279a91.48.2025.02.19.10.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 10:45:57 -0800 (PST) Date: Wed, 19 Feb 2025 10:45:55 -0800 From: Stephen Hemminger To: Thierry Herbelot Cc: dev@dpdk.org, Thomas Monjalon , stable@dpdk.org Subject: Re: [PATCH] ethdev: fix get_reg_info Message-ID: <20250219104555.0bc2e0ff@hermes.local> In-Reply-To: <20250218115828.2107335-1-thierry.herbelot@6wind.com> References: <20250218115828.2107335-1-thierry.herbelot@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 18 Feb 2025 12:58:28 +0100 Thierry Herbelot wrote: > 'width' and 'offset' are input parameters when dumping the register > info of an Ethernet device. They should be copied in the new request > before calling the device callback function. > > Fixes: 083db2ed9e9 ('ethdev: add report of register names and filter') > Cc: stable@dpdk.org > > Signed-off-by: Thierry Herbelot Why does the ethdev code create an on stack temporary variable. Looks like it only wants to make sure that names element is NULL. Really should be one function and when extended fields were added should have used API versioning. Probably too late now, although rte_eth_dev_get_reg_info_ext() is an experimental API.