From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 772B346280 for ; Thu, 20 Feb 2025 17:42:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 699664065B; Thu, 20 Feb 2025 17:42:13 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id B8E9240615 for ; Thu, 20 Feb 2025 17:42:09 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-220d28c215eso18376485ad.1 for ; Thu, 20 Feb 2025 08:42:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1740069729; x=1740674529; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c8mVx65OZgwlPD3YqCSP4AJR4DoGBjJVIPIjf98KaNw=; b=qjf2xsa30+JXAEbaUPpm2ebcGO5J4wj6fEBQb5vNlFEwm6+JRDNzxI0cpPxy2+RRHI EfE3WxrGPhHmaI5gz6OQaeAYeMUKhCU9CL9z4nUtJRJtXawnu0d1MfiOD6SOdDasAEqd vR5AQC6swr9VhbRm0V6stGDTbC/0+8tNr5m5NVLvxtrowibHDFg/kP6QREupESgNiCGU REgXkE7zXcZFY807o+XiUWEiI7HPYZVNJK6HAwdHqQytCiljF6hJCiTQBs+13djEg/DH SVF1G1PBLQwQoxHR8vTe6aX3756BqMtdBY8yKXBVpxT1a9ojrHQ7u+yvJPNRCsdB5vkn VOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740069729; x=1740674529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c8mVx65OZgwlPD3YqCSP4AJR4DoGBjJVIPIjf98KaNw=; b=qQAzPyIp5DJIZBggl5i3/dP7L7Zd3uLNLftRSV9VnkMJJpgsYcQ9aPEn/xJ7t1fwzH 0QMHFEQzfhq3fcCsoKnr48J8RopuAdyQzybAHR9IAhtGR1np4+Cv9s0B5cy9mYlxjZoM ATQrSBvRsExJbrPZSjoSR/LoYpHzE6RDaakvHCNEAK/W40NovGZ06Yk7IUibEXUp6WSP 7pUx58hpiTe8XmzWw6KhPv0hMsfC1jkeVGls57U1pOKrkZy47jBkIRTscf8sLz0qI2CG oE+9vORGKOqhOs3QRMH30X5rnj9kFCX1K+2gwRXQPKA2fESPShsLk1qyTv2WTXEYaN53 Sq7Q== X-Forwarded-Encrypted: i=1; AJvYcCWuRGU7SaaSIZPNCVbuoAocWtSgQYGMuq4v5DZHaL9muQXLhrJxpTGq8yTDAizNNdS6ahNmttY=@dpdk.org X-Gm-Message-State: AOJu0YzoREge/2IlL33ovzunj2/gqrDR+JqUndVCQrobPjXb17Xn/HF7 URfUscKFmoZF3klQESuSGtT7pPgq66/k0tx/KOUhxicbvPuzxeUGaAN8Bpx/mmw= X-Gm-Gg: ASbGncuUiPGE6Mj5Mi1009XSY120NLETdrjxGZo+vXm6VWkTF2AXDd1anX6s7Ga5pm3 obYV+4bL2oq5l61yJDesFG/07RoMkknak3zn7jDVHIRzzDYgBVhyskE9ZYf2Mo7Ds/IlJzNNwmy At/sWQHG4DaS2Tu/KkX2O1kmHPPvCwGx0S2cqnE7NAly/tXmFx8bSXCPrre/Lyj2ESmfg2icC+Y 8hwsPztuUapYU9uJRSEus5AHTmCtz7OlFn5Jv84zFGlFhxEgNqqofsjiE/cW2MLV8HqWRieOWOr xldCRl4F4lJ2H94e3coCg+rQVC5WWPe8Rl/kkHbLQHaxb+wiZrQ37PBlNvrEjCcFrbtU X-Google-Smtp-Source: AGHT+IGoWrBs4m+lNx7+BPLHM7lx3WQAj2K/TRxPWta9JbixYHISGlZgjjksFRKYf/MyYiL3KCkhLA== X-Received: by 2002:a17:903:8c5:b0:21f:6a36:7bf3 with SMTP id d9443c01a7336-22104030814mr385535625ad.12.1740069728959; Thu, 20 Feb 2025 08:42:08 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d5348e68sm123798305ad.28.2025.02.20.08.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 08:42:08 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Bruce Richardson , Kai Ji , Ciara Power , Fan Zhang Subject: [PATCH v9 08/15] crypto/qat: fix size calculation for memset Date: Thu, 20 Feb 2025 08:27:14 -0800 Message-ID: <20250220164151.9606-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250220164151.9606-1-stephen@networkplumber.org> References: <20241114011129.451243-1-stephen@networkplumber.org> <20250220164151.9606-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The memset was always doing 0 bytes since size computed later. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 3a80d7fb2ecd ("crypto/qat: support SHA3 plain hash") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_sym_session.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 3564a33484..7836c95064 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -2347,7 +2347,7 @@ int qat_sym_cd_cipher_set(struct qat_sym_session *cdesc, return 0; } -int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, +static int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, const uint8_t *authkey, uint32_t authkeylen, uint32_t aad_length, @@ -2620,27 +2620,27 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, break; case ICP_QAT_HW_AUTH_ALGO_SHA3_224: /* Plain SHA3-224 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_SHA3_256: /* Plain SHA3-256 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_SHA3_384: /* Plain SHA3-384 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_SHA3_512: /* Plain SHA3-512 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC: state1_size = ICP_QAT_HW_AES_XCBC_MAC_STATE1_SZ; -- 2.47.2