From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FA0B462AE for ; Mon, 24 Feb 2025 20:25:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 123DB427C0; Mon, 24 Feb 2025 20:25:41 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 11DEB427B7 for ; Mon, 24 Feb 2025 20:25:37 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-220c665ef4cso83658795ad.3 for ; Mon, 24 Feb 2025 11:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1740425137; x=1741029937; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=d/wXUIl0S3kn8dybOoMvyeaDZ8nTMY1NQWUdCKXFNIM=; b=MYZJuupchoOgkCi9jjpBg3M865hR8UnxvxfuK4dyDDmrvqmHCdwqLZGnY5dVfCWdPi PMSfadIlINDPvaVkNTfvkvybif6U4FrYgdWXsMcqDZm4xTaoeHDt2zD4tafUD6c5AG7w DU9J3DbdZwc4sEwjt+/WE5+TqZEtE//ovFJIuw4GYyL59kYe1ZxVCkBWF90r705Z/U/9 TkouFX774gXyjXtU6nMu+eWukCc6WEeQhrj6zwUDUoZKHGIBaCNO7Y9oXpBpeLSesDg9 hu/w4xrWUR2p7RaQHDUMhIC7UJLLIiYqmkq2ime/qJrn6v4r+uhwiZuBmo5rzC/BEoDA sRJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740425137; x=1741029937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d/wXUIl0S3kn8dybOoMvyeaDZ8nTMY1NQWUdCKXFNIM=; b=YlWGJK+8L5wOlyEo6s3yvUvcr+h5J/sGFiRgO99KPCfxOPdkjJqrLr/hjUBOtyDSFV neRAMRjnEO7CJ7U+K97f6GVIRDr5Zekdk1ka668ZyC9PgMbN+ylrD9tbX3kTmJicWdur 6Ar0RYd31DZw2NRZT216HaTmMqGO43bhIpzyfq/dIJkdD69tSEUVIJVMjS0xSaoXJ50M q+yRFQER1TVRH3A/9qxjPUZyfPMQuo9dUdICuO2FUO7J1YmXa5965RhGzHP7Je/Isx8/ Rx0D4tgYp47DhMtbmh2np7Ytyhi3VzDg3rq72DYRXwC/B3veOG86fMPGBbF21jr9CFgj akyQ== X-Forwarded-Encrypted: i=1; AJvYcCVTxbs65eX5w0fn8fipDMqYE4vJ9G9jJfVbiiXOC1b4/7YIRiTPmrjirtSU7mUBxQzGw6t2CPA=@dpdk.org X-Gm-Message-State: AOJu0Ywkzx/PYC9YdvDNqifbinc6anCdBMnaHgAiUOCNvIg2t0xvSVeX yBKaNBb45XGL8d/RbkkZi4LNSvWLAIaAABfxo3/nllSVXneQSBBA0KkEVNjg5xw= X-Gm-Gg: ASbGncuJnSzLFBlOm1nLU7OOc0fipfSnrF7e63AV93Ksq88aoW3NOnlrztjXhmYo8cb e7DzJ47iiFADp7ek3RZwiXFaoeFNO/2b5vC6GiB+weK1BcfS6aL4CDiz1Mrmk3RGB4EJxtDVzFG Gqa5591WP9L2IeBbuKpw5FjflsbCzXvjejQixOBjpaMyla6RUi7XSf8w7aWi7/D5Crd/eP7m+gd wqT52fasMmSgRm9xntFrop9eL0drZenmQIakd4y+kn8GuIhh8pHrpaV4G/o/8EE6txqJxq+c5Nl yGObx/PTVrQwRfU4ZI1lR3mAMUVz571tEzoAhCIbak0u2KcH8i8ZCgmOkQBYBlN02pRjWQHO5ee eTW0= X-Google-Smtp-Source: AGHT+IHzYmLnd84ZupllQg1o2qh+frPogWsqtNL/qu4m6IBX7xP+d5GNw3lRxcRT5oLTB/6bvC1+5g== X-Received: by 2002:a17:902:d48d:b0:21f:136a:a374 with SMTP id d9443c01a7336-221a0025a63mr248622685ad.43.1740425137146; Mon, 24 Feb 2025 11:25:37 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d5596115sm184570385ad.258.2025.02.24.11.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 11:25:36 -0800 (PST) Date: Mon, 24 Feb 2025 11:25:34 -0800 From: Stephen Hemminger To: Ariel Otilibili Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon , David Marchand , Maryam Tahhan , Ciara Loftus Subject: Re: [PATCH v6 2/2] net/af_xdp: Refactor af_xdp_tx_zc Message-ID: <20250224112534.684c19c6@hermes.local> In-Reply-To: <20250131231018.2163893-3-ariel.otilibili@6wind.com> References: <20250116195640.68885-1-ariel.otilibili@6wind.com> <20250131231018.2163893-3-ariel.otilibili@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Sat, 1 Feb 2025 00:10:21 +0100 Ariel Otilibili wrote: > @ -559,21 +582,12 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > mbuf = bufs[i]; > > if (mbuf->pool == umem->mb_pool) { > - if (!xsk_ring_prod__reserve(&txq->tx, 1, &idx_tx)) { > + if (!(desc = reserve_and_fill(txq, mbuf, umem))) { > kick_tx(txq, cq); > - if (!xsk_ring_prod__reserve(&txq->tx, 1, > - &idx_tx)) > + if (!(desc = reserve_and_fill(txq, mbuf, umem))) > goto out; > } Please avoid doing assignment in a conditional statement, can be error prone. Surprised checkpatch doesn't complain about it. Better as: desc = reserve_and_fill(txq, mbuf, umem); if (!desc) { kick_tx(txq, cq); desc = reserve_and_fill(txq, mbuf, umem); if (!desc) goto out;