From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8F2246364 for ; Fri, 7 Mar 2025 13:25:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D02D4029E; Fri, 7 Mar 2025 13:25:14 +0100 (CET) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mails.dpdk.org (Postfix) with ESMTP id CB15540E41 for ; Fri, 7 Mar 2025 13:25:12 +0100 (CET) Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43bcf9612f4so14840005e9.3 for ; Fri, 07 Mar 2025 04:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741350312; x=1741955112; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JyrJzDxfBTuIa4UZv2a/ASfJxbssHHHrOBDwmbxHUPM=; b=JwY6xdkqNoAMoZQbpfDDFL2WV5s6rKQoDIVr1nrrGFhu+vgr6gVHvHnlnt4sJgSWC8 +9VCF9hiv/fajf4AYgMksI3L1xGUjm93e6lHncxcb1qbW+r69k4zAwvmTof+x5NxDIm6 24OBszeYlV1GADEXSQu6B+9Qics9sd03tvVvvIjFt9+zy92KvSsivGgVDDodVE7cZnHp BUpD6Yj+Vlf3M2IakqxHou4o7iBSGmReUmdKXKU2s25sfY0w0gJ/f55PP0dARyIQIz86 /cnaAWfdICvSEL77h2IEELeAKZV6FPat6DNaO1eCSUoOU/Jc4YCIyvQas6FeWEdPTcLj z+tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741350312; x=1741955112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JyrJzDxfBTuIa4UZv2a/ASfJxbssHHHrOBDwmbxHUPM=; b=PcX+dINwU/QydYs9ih5HHcGMoFB3aYad+CXhmlMj7vr5F66QiMrU4ZYfLhvsUmdyeM dl91TpuWU1jB7HYyr64/4I04KdurlR9pIwYxkCvIVIlxXxy2J0kYPdTWSXbqVU1v1+2j DSrhK25g2fMr1wmmLQXQ9CONsG0HznCC/IofgmAyQjwDYjUGTE0XV+bWFrmcewuUmuVz 1lQ0vA/PCfcB/C7dc2zQfhsabRdStF5E2r6ZyTyFcIpUTZX0U+u6ZolsivfEhkSKHcF4 /rR7cE9X+OZrE+ThYuFb4eGH8QwxZ5HRUCsbJVr7aQVv/gN2utjHwuRq0z3nvJjsYBPm IKHQ== X-Forwarded-Encrypted: i=1; AJvYcCXw28NQWx8psn6UX4qi4gO2wyQTJRldXoSmeRJArP/0OBdkLjkONC7Q7F6hSKEwMsJELPn2hq8=@dpdk.org X-Gm-Message-State: AOJu0YxC6m7qzY2OiXw2VFYm/x/RewRAVhXYdQUxoz/Cu1fvUmaxkjKO 7L7Ua1GFQDBSngv43B3ASbqMCUMHSwx7P0tnv5vCHdYQMN9Ueb7YMWQjfGDV X-Gm-Gg: ASbGncsG0g0BClf/iATL6iz9p9OQjBSc5n4MAE74s0xSS86uCdOCdz74iszj0n3fGFw a5iGaEKJuqzonohlnda+8PakF/p8NzyKhAIFvZurQmuCnJ3G6tlayyScHKN/hsZyDMxGZpIwVAS DYSb2LvDRt+AxTii/LI2htXT/+JNWHRHH7hO0YbKK6ortj6L8iepM6LnbdMg4klAuvK2j4zWe7e vVp1zlxQOSes81ROM9BYiAzjpMa91evfxJ/90Qkxn/IeX4tCakBtHoNOTDU58A/gKp0TDl2jxU0 ubnM+UC3Nky9g6hro89W4MGW7dWQ9szxKqCFqHismwyAyY67vJA= X-Google-Smtp-Source: AGHT+IFqHT7YPCO5teFEcxS7ZwQ/itwQQ4PA2HDMJArEYcTHbPSFc+I6PhruMp2XyEaYPOcABDMAcQ== X-Received: by 2002:a05:600c:1549:b0:43b:c962:ad1c with SMTP id 5b1f17b1804b1-43c601cfd02mr22664715e9.15.1741350312198; Fri, 07 Mar 2025 04:25:12 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:ff31:f049:bd38:f7cf]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43bdd8c3173sm51207775e9.11.2025.03.07.04.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 04:25:11 -0800 (PST) From: luca.boccassi@gmail.com To: Mingjin Ye Cc: Bruce Richardson , dpdk stable Subject: patch 'net/ixgbe: fix minimum Rx/Tx descriptors' has been queued to stable release 22.11.8 Date: Fri, 7 Mar 2025 12:24:14 +0000 Message-ID: <20250307122431.1415551-15-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250307122431.1415551-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-79-luca.boccassi@gmail.com> <20250307122431.1415551-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a1cc0b5adae53f811a6d25ff9758c5c7e9c7cdff Thanks. Luca Boccassi --- >From a1cc0b5adae53f811a6d25ff9758c5c7e9c7cdff Mon Sep 17 00:00:00 2001 From: Mingjin Ye Date: Tue, 25 Feb 2025 09:12:36 +0000 Subject: [PATCH] net/ixgbe: fix minimum Rx/Tx descriptors [ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ] The minimum free packet threshold (tx_free_thresh) and the minimum RS bit threshold (tx_rs_thresh) both have a default value of 32. Therefore, the default minimum number of ring descriptors value is 64. For reference, see "Configuration of Transmit Queues" in doc/guides/prog_guide/ethdev/ethdev.rst Fixes: dee5f1fd5fc7 ("ixgbe: get queue info and descriptor limits") Signed-off-by: Mingjin Ye Acked-by: Bruce Richardson --- doc/guides/nics/ixgbe.rst | 8 +++----- drivers/net/ixgbe/ixgbe_rxtx.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst index f8eedb4c7f..dc9049f150 100644 --- a/doc/guides/nics/ixgbe.rst +++ b/doc/guides/nics/ixgbe.rst @@ -37,14 +37,12 @@ Ensure that the following pre-conditions are satisfied: * (rxq->nb_rx_desc % rxq->rx_free_thresh) == 0 -* rxq->nb_rx_desc < (IXGBE_MAX_RING_DESC - RTE_PMD_IXGBE_RX_MAX_BURST) +* rxq->nb_rx_desc >= IXGBE_MIN_RING_DESC + +* rxq->nb_rx_desc <= IXGBE_MAX_RING_DESC These conditions are checked in the code. -Scattered packets are not supported in this mode. -If an incoming packet is greater than the maximum acceptable length of one "mbuf" data size (by default, the size is 2 KB), -vPMD for RX would be disabled. - By default, IXGBE_MAX_RING_DESC is set to 4096 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32. Windows Prerequisites and Pre-conditions diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h index 668a5b9814..3af83b693c 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.h +++ b/drivers/net/ixgbe/ixgbe_rxtx.h @@ -24,7 +24,7 @@ * descriptors should meet the following condition: * (num_ring_desc * sizeof(rx/tx descriptor)) % 128 == 0 */ -#define IXGBE_MIN_RING_DESC 32 +#define IXGBE_MIN_RING_DESC 64 #define IXGBE_MAX_RING_DESC 4096 #define RTE_PMD_IXGBE_TX_MAX_BURST 32 -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 12:23:38.581612404 +0000 +++ 0015-net-ixgbe-fix-minimum-Rx-Tx-descriptors.patch 2025-03-07 12:23:38.014838527 +0000 @@ -1 +1 @@ -From 6808ee1ceddc76846f80ae3d05aad374a34a1754 Mon Sep 17 00:00:00 2001 +From a1cc0b5adae53f811a6d25ff9758c5c7e9c7cdff Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19,2 +20,2 @@ - doc/guides/nics/ixgbe.rst | 8 +++----- - drivers/net/intel/ixgbe/ixgbe_rxtx.h | 2 +- + doc/guides/nics/ixgbe.rst | 8 +++----- + drivers/net/ixgbe/ixgbe_rxtx.h | 2 +- @@ -24 +25 @@ -index 8dcde7ae1c..a03ec7a7e8 100644 +index f8eedb4c7f..dc9049f150 100644 @@ -27 +28 @@ -@@ -68,14 +68,12 @@ Ensure that the following pre-conditions are satisfied: +@@ -37,14 +37,12 @@ Ensure that the following pre-conditions are satisfied: @@ -42 +43 @@ - By default, IXGBE_MAX_RING_DESC is set to 8192 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32. + By default, IXGBE_MAX_RING_DESC is set to 4096 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32. @@ -45,5 +46,5 @@ -diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.h b/drivers/net/intel/ixgbe/ixgbe_rxtx.h -index 278f665108..54569c7ade 100644 ---- a/drivers/net/intel/ixgbe/ixgbe_rxtx.h -+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.h -@@ -26,7 +26,7 @@ +diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h +index 668a5b9814..3af83b693c 100644 +--- a/drivers/net/ixgbe/ixgbe_rxtx.h ++++ b/drivers/net/ixgbe/ixgbe_rxtx.h +@@ -24,7 +24,7 @@ @@ -55 +56 @@ - #define IXGBE_MAX_RING_DESC 8192 + #define IXGBE_MAX_RING_DESC 4096