From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 865C946364 for ; Fri, 7 Mar 2025 13:25:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BE7E40E35; Fri, 7 Mar 2025 13:25:30 +0100 (CET) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 43CA140E35 for ; Fri, 7 Mar 2025 13:25:29 +0100 (CET) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43bdc607c16so13902285e9.1 for ; Fri, 07 Mar 2025 04:25:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741350329; x=1741955129; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k4kATDkLEXYGKvlOeu9XSo7FKivS4XNIoedBEWar+TY=; b=fJlVLEwhz4b4R3UkLWW9zXBiG9DwBCJmbFwhQEuQsR3NSvSrq3qNroATxo7pob1K6i nCdKBk+bGtOS5cW1nGzn0MHOggnFP7L2Ho15gbR3oKr7kiOsmQBUTBAhS88sTzF4eWuG hji11BOvRZe+0DN75BquR2gHHqvE7mVQW+dcrIEyhKpV+r4doI7NnmtZCwzuh2VSeVef EfEhhUxq903x5zUSe+qUlgOM5cptbVQNbL10gLXzfjPtNPyiqrylLYXcMuTIeiOyK9av NS/CLK7vjfsJbYeGbWhay4ZSHTPsyx78HntE2F2Euzar7Pi6fxyu6XzhAdy3siXp87B/ 6pcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741350329; x=1741955129; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k4kATDkLEXYGKvlOeu9XSo7FKivS4XNIoedBEWar+TY=; b=V5s2wr/m7gvzIpIZr4RmxGkcSlE2Ts7IA1gH4iQhw01r5bcQDnf0g1o2KEVn5XWNyY NkM5x6ZovOqDNTY6eDUiwm5FXkaaKvv5qELZYVckkQO8zzMQBOE9kPXdBJkdiyYQXJ97 A7dGaaNvCMg+a87JqYMXRbI1Dj9SjOqCILkSqS32DKFRxZ95p/27Dy8hHQz5lFO8BMaL BV9TYsgkiaOC8VyeAlMf9VwtB+i/37O6Tet+8LQT4Lyz7NDNwa8YZFLP9u7BQMPWNIq/ iKVOldid+8dEHk0/b1mjUL+aHO6g4P7XUcKPM8dDX5TACTOkJyRkOQM9AqED/d4PY3U9 XUnw== X-Forwarded-Encrypted: i=1; AJvYcCUXqwlENXIW78z/lF9Cc7EvzxV9hUkBgfP1tz90OwXIoEiAyqav13O+hRK16WV4OHM+sM8PCu0=@dpdk.org X-Gm-Message-State: AOJu0YxQ6WUxR9x97mIwpmDNfexotyi3yjSVu5G/ELf/RmsMvfyQ/OPP UlkhfBkOuDkWShy6eHmLLDFq8IpG71lm/6kwR9+A0QQw9i3QidOQIApSDI6y X-Gm-Gg: ASbGncsBrNgu25V65GeBHjcd87gdWpg7Spx+d4t9FGS23azLbw1TFOWhLEkapYeYfVY UsIPtwKNad2rSSbZrl2Zg1KY1mBp3Z/OCwGI/3VwkoDPqhriVsz1k+bmTrrDDWVHJcZHodroXIs 2muq4Qtjbbps2cfr+nDfttqOc4HN5VV/L3sxqRdjht6TYX4yjgwFWDdDiOw0Ef/6L1nPvaDVavb OgCGD53J2cX1kHHbaGvVfQBxWGmuiZAuqR7UTQn7r2Mq+hTPKv2kkGJoTP7sGtOI+UK66QS2lee W6BkHGcHDWCtxx4AZMtqpnWyP89N+jNdW8Ul+n58Ylnea6mk1k0= X-Google-Smtp-Source: AGHT+IFKbDufhqAIN/OJ0FH0IwQgpYe6nWXZBbOoRLVkodmrK6T01PZm2t7/YblQ2tq9C+RhJxTetQ== X-Received: by 2002:a05:600c:4f14:b0:43b:c2d7:44d with SMTP id 5b1f17b1804b1-43c5a629bc4mr19573575e9.21.1741350328592; Fri, 07 Mar 2025 04:25:28 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:ff31:f049:bd38:f7cf]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43bdd8de4ffsm50314795e9.24.2025.03.07.04.25.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 04:25:28 -0800 (PST) From: luca.boccassi@gmail.com To: Andre Muezerie Cc: David Marchand , dpdk stable Subject: patch 'stack: fix pop in C11 implementation' has been queued to stable release 22.11.8 Date: Fri, 7 Mar 2025 12:24:19 +0000 Message-ID: <20250307122431.1415551-20-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250307122431.1415551-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-79-luca.boccassi@gmail.com> <20250307122431.1415551-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/851486f6cc3e1324c1c8c7243bcb8286130c32ec Thanks. Luca Boccassi --- >From 851486f6cc3e1324c1c8c7243bcb8286130c32ec Mon Sep 17 00:00:00 2001 From: Andre Muezerie Date: Mon, 3 Feb 2025 17:23:37 -0800 Subject: [PATCH] stack: fix pop in C11 implementation [ upstream commit 916424f2c6029cd8da5c56ed62847a4b09d7e0ac ] Variable "success" was not being initialized and there was a code path where the last do/while loop in __rte_stack_lf_pop_elems looked at the value of this variable before it was set to any. Compiling with msvc resulted in stack_lf_autotest sometimes crashing. The fix is to initialize the variable. This same fix was applied to stack\rte_stack_lf_generic.h in the past but was missed here. Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation") Signed-off-by: Andre Muezerie Reviewed-by: David Marchand --- lib/stack/rte_stack_lf_c11.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stack/rte_stack_lf_c11.h b/lib/stack/rte_stack_lf_c11.h index 8403196d51..13ee26be4e 100644 --- a/lib/stack/rte_stack_lf_c11.h +++ b/lib/stack/rte_stack_lf_c11.h @@ -77,7 +77,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list, { struct rte_stack_lf_head old_head; uint64_t len; - int success; + int success = 0; /* Reserve num elements, if available */ len = __atomic_load_n(&list->len, __ATOMIC_RELAXED); -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 12:23:38.757334778 +0000 +++ 0020-stack-fix-pop-in-C11-implementation.patch 2025-03-07 12:23:38.022838760 +0000 @@ -1 +1 @@ -From 916424f2c6029cd8da5c56ed62847a4b09d7e0ac Mon Sep 17 00:00:00 2001 +From 851486f6cc3e1324c1c8c7243bcb8286130c32ec Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 916424f2c6029cd8da5c56ed62847a4b09d7e0ac ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 60d46e963b..ee1c79c095 100644 +index 8403196d51..13ee26be4e 100644 @@ -36 +37 @@ - len = rte_atomic_load_explicit(&list->len, rte_memory_order_relaxed); + len = __atomic_load_n(&list->len, __ATOMIC_RELAXED);