From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9E2546364 for ; Fri, 7 Mar 2025 13:24:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D473840E39; Fri, 7 Mar 2025 13:24:40 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id 9A91040E39 for ; Fri, 7 Mar 2025 13:24:39 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43bd87f7c2eso10112675e9.3 for ; Fri, 07 Mar 2025 04:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741350279; x=1741955079; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+J+NPj8GyI1T0phSR9FcjaqOp/O7ajjkc8rcetVBWn4=; b=NCqmGpyCA2Sso36eTN+zFs7HKCoTICZtcY3e+wSKLpgn9xMs53i0W0nZaJ4BVdXAUp jMDZOm/j+3vnmPWZmu1WslAmuksQvrmciTwGAqsE516Vb4oJgKvqWebBLuDXOtEoyUro FF58RNvcQtXS4e2lmr8e2J0RWuT9Md7rWBYmr3yDuuWy0iaCRLS7EaBU1FmzTvSEdhKD Cvq2ySE4QzzPi+PuQGRsgH6ZoL/vMhqfb89bqdKIDhCdV8Q1yGPFydCYOYyC0msNTemd g1K2uJFInHFqw33y3DQxBkhvsaxDwF6tidKusig/NuZetYHY0frMyEGWwo+CsHB83Ek9 OKsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741350279; x=1741955079; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+J+NPj8GyI1T0phSR9FcjaqOp/O7ajjkc8rcetVBWn4=; b=ODAx2lW/fqqDnvqPlHo8aAs8gG/MCI9bpN/mcqEiasdiKJWn9nJn2sB1xdZdw0N0Yx 3DbjvHSsVqnNO5GG7sHDuzjiJdrz8adJlPevQkQebf8zHQm63PKvf2Qgx0H222n3UIID Iz7qNjtRe8GVHVwfOLnrzKMut8bsr7ssmBK+qm89/m/blXVqCAWKXKCJo/HiNICXp/fY FTbBmu0dFnggmvYR4tXmDTapevoPMf2BsCAIn9brTS+a+AHzH18Fuf2DAErwqxf9z+69 fQlyS/c+1B5I2KPy/GqOebxtwdEtj16wRKz9JrsIFxYYxlBfjEMnfnMKY8LhxunVDEJI JNCw== X-Gm-Message-State: AOJu0YykvCnwXnCE6UCdTnMao1tPURSO0e8y/adGcfLqYLi6PDp0rKyl DkWxlyXB09eu2LRKoJJidijR4HVGVprEK/phc9C1n/aKEh4joy5Js6XSLrt9 X-Gm-Gg: ASbGncs+JJzQ74Tslt+XsnR8z0fO/WkZFmOH92dDJ9Urij3GLT7sikgIDJnKIED03sE 7QTkHdyjMXN0+wSpXNoWKRdZLh18aUwbHfkE1Oy5+qybvBx/V4r7K30ZyqOsbcdmJcZpn/ZP1NI hLvQOyXR0C61FxzLS68IulaLsEp4x+58HEadqSPVaYDtHWSR7yuVhj7F4uI6ioKfb2pNU5TZI1l Y1+kw6HFSMeBFaWA2l4ttRQqJSXEzlom9FQMN4vxvbldIUFLtRlLSMwzKQzmIZUT+HnOCmJ/Kzu KzbsAH6BknQJXZyOBtem5agwaaUDy4W8wniPSWbW84L6As1FzcM= X-Google-Smtp-Source: AGHT+IF7Aee79iZ/aSzsnwK+6tgWFzacG8Xbl7zq+r/bdttS9BipBGhYk5CKufcfOyulQMtfepmmjg== X-Received: by 2002:a05:600c:19d0:b0:439:8a8c:d3ca with SMTP id 5b1f17b1804b1-43c5cf3cea3mr21296025e9.29.1741350278949; Fri, 07 Mar 2025 04:24:38 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:ff31:f049:bd38:f7cf]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43bd426c01bsm81258275e9.2.2025.03.07.04.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 04:24:38 -0800 (PST) From: luca.boccassi@gmail.com To: Chengwen Feng Cc: dpdk stable Subject: patch 'app/testpmd: avoid crash in DCB config' has been queued to stable release 22.11.8 Date: Fri, 7 Mar 2025 12:24:04 +0000 Message-ID: <20250307122431.1415551-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250307122431.1415551-1-luca.boccassi@gmail.com> References: <20250217170456.1068278-79-luca.boccassi@gmail.com> <20250307122431.1415551-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/9502cde78b96b713f43d68055964d0b5c0747033 Thanks. Luca Boccassi --- >From 9502cde78b96b713f43d68055964d0b5c0747033 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 20 Feb 2025 15:06:51 +0800 Subject: [PATCH] app/testpmd: avoid crash in DCB config [ upstream commit d646e219b34ffc4d531f3703fc317e7cff9a25ae ] The "port config dcb ..." command will segment fault when input with invalid port id, this patch fixes it. Fixes: 9b53e542e9e1 ("app/testpmd: add priority flow control") Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 5336df528b..90b501863c 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3046,6 +3046,9 @@ cmd_config_dcb_parsed(void *parsed_result, uint8_t pfc_en; int ret; + if (port_id_is_invalid(port_id, ENABLED_WARN)) + return; + port = &ports[port_id]; /** Check if the port is not started **/ if (port->port_status != RTE_PORT_STOPPED) { @@ -6237,6 +6240,9 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result, int rx_fc_enable, tx_fc_enable; int ret; + if (port_id_is_invalid(res->port_id, ENABLED_WARN)) + return; + /* * Rx on/off, flow control is enabled/disabled on RX side. This can indicate * the RTE_ETH_FC_TX_PAUSE, Transmit pause frame at the Rx side. -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 12:23:38.215920937 +0000 +++ 0005-app-testpmd-avoid-crash-in-DCB-config.patch 2025-03-07 12:23:37.990837825 +0000 @@ -1 +1 @@ -From d646e219b34ffc4d531f3703fc317e7cff9a25ae Mon Sep 17 00:00:00 2001 +From 9502cde78b96b713f43d68055964d0b5c0747033 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d646e219b34ffc4d531f3703fc317e7cff9a25ae ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 6b0d8af4f6..6ca3eedb92 100644 +index 5336df528b..90b501863c 100644 @@ -21 +22 @@ -@@ -3462,6 +3462,9 @@ cmd_config_dcb_parsed(void *parsed_result, +@@ -3046,6 +3046,9 @@ cmd_config_dcb_parsed(void *parsed_result, @@ -31 +32 @@ -@@ -6664,6 +6667,9 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result, +@@ -6237,6 +6240,9 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result,