From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C78D46364 for ; Fri, 7 Mar 2025 13:47:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2445540E30; Fri, 7 Mar 2025 13:47:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8BF9D40E30 for ; Fri, 7 Mar 2025 13:47:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zhT30KV5sOK+hW8wkgCUvNHYzw1GIrY1m6llZIxe4Kg=; b=IH5SSm+7Mc1tVa3z37twW7ibOXqM0DtmY0f6QHPNkPf3JdPo3k3l3HaM9HytSupQYgLL60 S3SWlRPmmbX3tv/tEHYytuVo4ujTjLQa8tlnfQ2q2BbCfRuT1JwgqRYcOVPbJDTWFzvvBs OGR6iZxgpBlNSBIkb6BqJv3Hf2rQXB4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517--1ZoK11FPPWnCoZbJoTr1Q-1; Fri, 07 Mar 2025 07:47:36 -0500 X-MC-Unique: -1ZoK11FPPWnCoZbJoTr1Q-1 X-Mimecast-MFC-AGG-ID: -1ZoK11FPPWnCoZbJoTr1Q_1741351656 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F05511800EC5; Fri, 7 Mar 2025 12:47:35 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E85731956095; Fri, 7 Mar 2025 12:47:33 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Aaron Conole , Andre Muezerie , dpdk stable Subject: patch 'ci: build with MSVC in GHA' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:46:34 +0000 Message-ID: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eiCIFMO0YWXY0WuvqdzJKZ2HP47-g_doGAndfAjrcvs_1741351656 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e22b7840f4f40661012bc54dc607ab5dd13c41b0 Thanks. Kevin --- >From e22b7840f4f40661012bc54dc607ab5dd13c41b0 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 12 Feb 2025 17:46:16 +0100 Subject: [PATCH] ci: build with MSVC in GHA [ upstream commit 6d80989ab2dcae3d70c0deeccf104c00b49d029c ] Add a build target in Windows 2022 for MSVC. Signed-off-by: David Marchand Acked-by: Aaron Conole Acked-by: Andre Muezerie --- .github/workflows/build.yml | 38 +++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d99700b6e9..cd71805168 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -175,4 +175,42 @@ jobs: build/meson-logs/testlog.txt + windows-vm-builds: + name: ${{ join(matrix.config.*, '-') }} + runs-on: ${{ matrix.config.os }} + strategy: + fail-fast: false + matrix: + config: + - os: windows-2022 + compiler: msvc + + steps: + - name: Checkout sources + uses: actions/checkout@v4 + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: '3.x' + - name: Install dependencies + run: python -m pip install meson==1.6.1 ninja + - name: Configure + shell: cmd + run: | + call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64 + meson setup -Denable_stdatomic=true build + - name: Build + shell: cmd + run: | + call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64 + meson compile -C build + - name: Upload logs on failure + if: failure() + uses: actions/upload-artifact@v4 + with: + name: meson-logs-${{ join(matrix.config.*, '-') }} + path: | + build/.ninja_log + build/meson-logs/meson-log.txt + prepare-container-images: name: ${{ join(matrix.config.*, '-') }} -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:56.949845053 +0000 +++ 0001-ci-build-with-MSVC-in-GHA.patch 2025-03-07 11:02:56.785335333 +0000 @@ -1 +1 @@ -From 6d80989ab2dcae3d70c0deeccf104c00b49d029c Mon Sep 17 00:00:00 2001 +From e22b7840f4f40661012bc54dc607ab5dd13c41b0 Mon Sep 17 00:00:00 2001 @@ -6 +6 @@ -Add a build target in Windows 2022 for MSVC. +[ upstream commit 6d80989ab2dcae3d70c0deeccf104c00b49d029c ] @@ -8 +8 @@ -Cc: stable@dpdk.org +Add a build target in Windows 2022 for MSVC. @@ -18 +18 @@ -index dcafb4a8f5..aef692ca1f 100644 +index d99700b6e9..cd71805168 100644