From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F88A46364 for ; Fri, 7 Mar 2025 13:48:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18E11402C3; Fri, 7 Mar 2025 13:48:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B607C40E30 for ; Fri, 7 Mar 2025 13:48:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9NBR8X4YmCdewc/Xzru20bKW1kwewEEbahqce5O04uI=; b=PYGAlqpW4mfsxA6+LsAZ9aMxDHmnWnKRVIlYCd2zOHfdhI1AcDFtdtnD5r46yTKZWWi5GO WJN4qVRW4XnYPo9zvlpMxOtbBggLV6TRjqvhxKK/wnzRXXUq1BQudnfP1ciDi+T2Tw5zMy iTHUizhaMplPno3j7eW1yQENQtiLcOo= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-DfIuapJwMBqeHVUGVbAybQ-1; Fri, 07 Mar 2025 07:48:21 -0500 X-MC-Unique: DfIuapJwMBqeHVUGVbAybQ-1 X-Mimecast-MFC-AGG-ID: DfIuapJwMBqeHVUGVbAybQ_1741351700 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 65BC918001E0; Fri, 7 Mar 2025 12:48:20 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D20E01956095; Fri, 7 Mar 2025 12:48:18 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Pravin Pathak , dpdk stable Subject: patch 'event/dlb2: fix event weight handling in SSE code path' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:46:54 +0000 Message-ID: <20250307124726.475001-21-ktraynor@redhat.com> In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com> References: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: V1KsP4KOUY8mrxhhBxbFrkBTmV83DwBzh8kfWXEvwoc_1741351700 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b5906479c816db6926d0bc3ae615da292a379891 Thanks. Kevin --- >From b5906479c816db6926d0bc3ae615da292a379891 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Tue, 21 Jan 2025 17:11:35 +0000 Subject: [PATCH] event/dlb2: fix event weight handling in SSE code path [ upstream commit 96357d5afefc7f4be8f5735f0d5ea011e68d24f2 ] Commit 6e2e98d6775b ("event/dlb2: support independent enqueue") updated the avx512 code path with support for the event, or "qe" weights. However, the SSE code path looks to have been missed in the update. Update the SSE "build_hcws" function to match the changes made to the AVX-512 version. Bugzilla ID: 1616 Fixes: 6e2e98d6775b ("event/dlb2: support independent enqueue") Signed-off-by: Bruce Richardson Reviewed-by: Pravin Pathak --- drivers/event/dlb2/dlb2_sse.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/event/dlb2/dlb2_sse.c b/drivers/event/dlb2/dlb2_sse.c index 248d7519d5..f2e1f9fb7e 100644 --- a/drivers/event/dlb2/dlb2_sse.c +++ b/drivers/event/dlb2/dlb2_sse.c @@ -191,9 +191,9 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, /* will only be set for DLB 2.5 + */ - if (qm_port->cq_weight) { - qe[0].weight = ev[0].impl_opaque & 3; - qe[1].weight = ev[1].impl_opaque & 3; - qe[2].weight = ev[2].impl_opaque & 3; - qe[3].weight = ev[3].impl_opaque & 3; + if (qm_port->dlb2->enable_cq_weight) { + qe[0].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[0]); + qe[1].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[1]); + qe[2].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[2]); + qe[3].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[3]); } @@ -206,4 +206,5 @@ dlb2_event_build_hcws(struct dlb2_port *qm_port, cmd_byte_map[qm_port->is_directed][ev[i].op]; qe[i].sched_type = sched_type[i]; + qe[i].weight = RTE_PMD_DLB2_GET_QE_WEIGHT(&ev[i]); qe[i].data = ev[i].u64; qe[i].qid = queue_id[i]; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:57.670221610 +0000 +++ 0021-event-dlb2-fix-event-weight-handling-in-SSE-code-pat.patch 2025-03-07 11:02:56.862521372 +0000 @@ -1 +1 @@ -From 96357d5afefc7f4be8f5735f0d5ea011e68d24f2 Mon Sep 17 00:00:00 2001 +From b5906479c816db6926d0bc3ae615da292a379891 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 96357d5afefc7f4be8f5735f0d5ea011e68d24f2 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org