patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Mingjin Ye <mingjinx.ye@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'net/ixgbe: fix minimum Rx/Tx descriptors' has been queued to stable release 24.11.2
Date: Fri,  7 Mar 2025 12:46:58 +0000	[thread overview]
Message-ID: <20250307124726.475001-25-ktraynor@redhat.com> (raw)
In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 24.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/12/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/1abcbab1309344932a050a9a91a4bb562fecddf2

Thanks.

Kevin

---
From 1abcbab1309344932a050a9a91a4bb562fecddf2 Mon Sep 17 00:00:00 2001
From: Mingjin Ye <mingjinx.ye@intel.com>
Date: Tue, 25 Feb 2025 09:12:36 +0000
Subject: [PATCH] net/ixgbe: fix minimum Rx/Tx descriptors

[ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ]

The minimum free packet threshold (tx_free_thresh) and the minimum RS bit
threshold (tx_rs_thresh) both have a default value of 32. Therefore, the
default minimum number of ring descriptors value is 64.

For reference, see "Configuration of Transmit Queues" in
doc/guides/prog_guide/ethdev/ethdev.rst

Fixes: dee5f1fd5fc7 ("ixgbe: get queue info and descriptor limits")

Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 doc/guides/nics/ixgbe.rst      | 8 +++-----
 drivers/net/ixgbe/ixgbe_rxtx.h | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst
index 8dcde7ae1c..a03ec7a7e8 100644
--- a/doc/guides/nics/ixgbe.rst
+++ b/doc/guides/nics/ixgbe.rst
@@ -69,12 +69,10 @@ Ensure that the following pre-conditions are satisfied:
 *   (rxq->nb_rx_desc % rxq->rx_free_thresh) == 0
 
-*   rxq->nb_rx_desc  < (IXGBE_MAX_RING_DESC - RTE_PMD_IXGBE_RX_MAX_BURST)
+*   rxq->nb_rx_desc >= IXGBE_MIN_RING_DESC
+
+*   rxq->nb_rx_desc <= IXGBE_MAX_RING_DESC
 
 These conditions are checked in the code.
 
-Scattered packets are not supported in this mode.
-If an incoming packet is greater than the maximum acceptable length of one "mbuf" data size (by default, the size is 2 KB),
-vPMD for RX would be disabled.
-
 By default, IXGBE_MAX_RING_DESC is set to 8192 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32.
 
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h
index 0550c1da60..a5807960a7 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.h
+++ b/drivers/net/ixgbe/ixgbe_rxtx.h
@@ -25,5 +25,5 @@
  *      (num_ring_desc * sizeof(rx/tx descriptor)) % 128 == 0
  */
-#define	IXGBE_MIN_RING_DESC	32
+#define	IXGBE_MIN_RING_DESC	64
 #define	IXGBE_MAX_RING_DESC	8192
 
-- 
2.48.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-03-07 11:02:57.831147322 +0000
+++ 0025-net-ixgbe-fix-minimum-Rx-Tx-descriptors.patch	2025-03-07 11:02:56.876718432 +0000
@@ -1 +1 @@
-From 6808ee1ceddc76846f80ae3d05aad374a34a1754 Mon Sep 17 00:00:00 2001
+From 1abcbab1309344932a050a9a91a4bb562fecddf2 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ]
+
@@ -14 +15,0 @@
-Cc: stable@dpdk.org
@@ -19,2 +20,2 @@
- doc/guides/nics/ixgbe.rst            | 8 +++-----
- drivers/net/intel/ixgbe/ixgbe_rxtx.h | 2 +-
+ doc/guides/nics/ixgbe.rst      | 8 +++-----
+ drivers/net/ixgbe/ixgbe_rxtx.h | 2 +-
@@ -43,5 +44,5 @@
-diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.h b/drivers/net/intel/ixgbe/ixgbe_rxtx.h
-index 278f665108..54569c7ade 100644
---- a/drivers/net/intel/ixgbe/ixgbe_rxtx.h
-+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.h
-@@ -27,5 +27,5 @@
+diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h
+index 0550c1da60..a5807960a7 100644
+--- a/drivers/net/ixgbe/ixgbe_rxtx.h
++++ b/drivers/net/ixgbe/ixgbe_rxtx.h
+@@ -25,5 +25,5 @@


  parent reply	other threads:[~2025-03-07 12:49 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 12:46 patch 'ci: build with MSVC in GHA' " Kevin Traynor
2025-03-07 12:46 ` patch 'net/netvsc: scan all net devices under the PCI device' " Kevin Traynor
2025-03-07 12:46 ` patch 'net/netvsc: remove device if its net devices removed' " Kevin Traynor
2025-03-07 12:46 ` patch 'doc: fix feature flags for queue start/stop' " Kevin Traynor
2025-03-07 12:46 ` patch 'doc: add VXLAN matching requirement in mlx5 guide' " Kevin Traynor
2025-03-07 12:46 ` patch 'app/testpmd: use VXLAN flow flags from user if set' " Kevin Traynor
2025-03-07 12:46 ` patch 'ethdev: fix registers info request' " Kevin Traynor
2025-03-07 12:46 ` patch 'app/testpmd: show all DCB priority TC map' " Kevin Traynor
2025-03-07 12:46 ` patch 'app/testpmd: avoid crash in DCB config' " Kevin Traynor
2025-03-07 12:46 ` patch 'net/mana: fix multi-process tracking' " Kevin Traynor
2025-03-07 12:46 ` patch 'app/testpmd: fix out-of-bound reference in offload config' " Kevin Traynor
2025-03-07 12:46 ` patch 'net/ngbe: fix WOL and NCSI capabilities' " Kevin Traynor
2025-03-07 12:46 ` patch 'net/txgbe: remove useless condition for SW-FW sync' " Kevin Traynor
2025-03-07 12:46 ` patch 'net/nfp: fix representor port statistics' " Kevin Traynor
2025-03-07 12:46 ` patch 'bus/pci: fix registered device name' " Kevin Traynor
2025-03-07 12:46 ` patch 'net/nfp: fix init failure handling' " Kevin Traynor
2025-03-07 12:46 ` patch 'vhost/crypto: skip fetch before vring init' " Kevin Traynor
2025-03-07 12:46 ` patch 'examples/vhost_crypto: fix user callbacks' " Kevin Traynor
2025-03-07 12:46 ` patch 'vhost: check descriptor chains length' " Kevin Traynor
2025-03-07 12:46 ` patch 'test/bbdev: update FFT test vectors' " Kevin Traynor
2025-03-07 12:46 ` patch 'event/dlb2: fix event weight handling in SSE code path' " Kevin Traynor
2025-03-07 12:46 ` patch 'test/event: fix number of queues in eventdev conf' " Kevin Traynor
2025-03-07 12:46 ` patch 'net/e1000: fix crashes in secondary processes' " Kevin Traynor
2025-03-07 12:46 ` patch 'net/ixgbe: " Kevin Traynor
2025-03-07 12:46 ` Kevin Traynor [this message]
2025-03-07 12:46 ` patch 'net/mlx5/hws: fix fragmented packet type matching' " Kevin Traynor
2025-03-07 12:47 ` patch 'net/mlx5: fix leak in HWS flow counter action' " Kevin Traynor
2025-03-07 12:47 ` patch 'net/mlx5: fix crash with null flow list creation' " Kevin Traynor
2025-03-07 12:47 ` patch 'net/mlx5: fix actions translation error overwrite' " Kevin Traynor
2025-03-07 12:47 ` patch 'net/mlx5: fix hardware packet type translation' " Kevin Traynor
2025-03-07 12:47 ` patch 'common/cnxk: fix inbound IPsec SA setup' " Kevin Traynor
2025-03-07 12:47 ` patch 'stack: fix pop in C11 implementation' " Kevin Traynor
2025-03-07 12:47 ` patch 'test/crypto: fix AES-ECB test lengths' " Kevin Traynor
2025-03-07 12:47 ` patch 'examples/ipsec-secgw: fix IV length in CTR 192/256' " Kevin Traynor
2025-03-07 12:47 ` patch 'crypto/cnxk: fix asymmetric operation status code' " Kevin Traynor
2025-03-07 12:47 ` patch 'test/crypto: remove unused variable' " Kevin Traynor
2025-03-07 12:47 ` patch 'crypto/openssl: validate incorrect RSA signature' " Kevin Traynor
2025-03-07 12:47 ` patch 'test/crypto: fix check for OOP header data' " Kevin Traynor
2025-03-07 12:47 ` patch 'crypto/qat: fix SM3 state size' " Kevin Traynor
2025-03-07 12:47 ` patch 'test/dma: fix pointers in IOVA as PA mode' " Kevin Traynor
2025-03-07 12:47 ` patch 'doc: update ionic driver guide' " Kevin Traynor
2025-03-07 12:47 ` patch 'ci: point at GitHub mirror' " Kevin Traynor
2025-03-07 12:47 ` patch 'ci: fix ccache for Ubuntu 22.04' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307124726.475001-25-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=mingjinx.ye@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).