From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A82446364 for ; Fri, 7 Mar 2025 13:49:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52572402C3; Fri, 7 Mar 2025 13:49:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1A516402C3 for ; Fri, 7 Mar 2025 13:49:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgSlUKvXRhEFD6/g/VFiZMUKj41qUsb4BJ6IC/SNVOs=; b=Rwk89wMZfnhZqm/EOxOK3+OOVvNkktuJFLySZeIiwwREqnTSoZaHc86casz8lCocZFq+cK u93K/KZr1hD923x2i7YkO2SiubKGQx2Ho3TtIrXry5xYtlc3YdcZQAfZQnV7QbLrgoIbjZ B/QUceWq25/wcrPHvvukRa8X867zrFU= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-gJAhcKukNcqqU470cQspiQ-1; Fri, 07 Mar 2025 07:48:30 -0500 X-MC-Unique: gJAhcKukNcqqU470cQspiQ-1 X-Mimecast-MFC-AGG-ID: gJAhcKukNcqqU470cQspiQ_1741351709 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 526CD180AF67; Fri, 7 Mar 2025 12:48:29 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8AF151956095; Fri, 7 Mar 2025 12:48:27 +0000 (UTC) From: Kevin Traynor To: Mingjin Ye Cc: Bruce Richardson , dpdk stable Subject: patch 'net/ixgbe: fix minimum Rx/Tx descriptors' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:46:58 +0000 Message-ID: <20250307124726.475001-25-ktraynor@redhat.com> In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com> References: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: X3BcNeRECI_AEXdvdbhNKaGXm-B_YS88c-fnZ_TkJFU_1741351709 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1abcbab1309344932a050a9a91a4bb562fecddf2 Thanks. Kevin --- >From 1abcbab1309344932a050a9a91a4bb562fecddf2 Mon Sep 17 00:00:00 2001 From: Mingjin Ye Date: Tue, 25 Feb 2025 09:12:36 +0000 Subject: [PATCH] net/ixgbe: fix minimum Rx/Tx descriptors [ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ] The minimum free packet threshold (tx_free_thresh) and the minimum RS bit threshold (tx_rs_thresh) both have a default value of 32. Therefore, the default minimum number of ring descriptors value is 64. For reference, see "Configuration of Transmit Queues" in doc/guides/prog_guide/ethdev/ethdev.rst Fixes: dee5f1fd5fc7 ("ixgbe: get queue info and descriptor limits") Signed-off-by: Mingjin Ye Acked-by: Bruce Richardson --- doc/guides/nics/ixgbe.rst | 8 +++----- drivers/net/ixgbe/ixgbe_rxtx.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst index 8dcde7ae1c..a03ec7a7e8 100644 --- a/doc/guides/nics/ixgbe.rst +++ b/doc/guides/nics/ixgbe.rst @@ -69,12 +69,10 @@ Ensure that the following pre-conditions are satisfied: * (rxq->nb_rx_desc % rxq->rx_free_thresh) == 0 -* rxq->nb_rx_desc < (IXGBE_MAX_RING_DESC - RTE_PMD_IXGBE_RX_MAX_BURST) +* rxq->nb_rx_desc >= IXGBE_MIN_RING_DESC + +* rxq->nb_rx_desc <= IXGBE_MAX_RING_DESC These conditions are checked in the code. -Scattered packets are not supported in this mode. -If an incoming packet is greater than the maximum acceptable length of one "mbuf" data size (by default, the size is 2 KB), -vPMD for RX would be disabled. - By default, IXGBE_MAX_RING_DESC is set to 8192 and RTE_PMD_IXGBE_RX_MAX_BURST is set to 32. diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h index 0550c1da60..a5807960a7 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.h +++ b/drivers/net/ixgbe/ixgbe_rxtx.h @@ -25,5 +25,5 @@ * (num_ring_desc * sizeof(rx/tx descriptor)) % 128 == 0 */ -#define IXGBE_MIN_RING_DESC 32 +#define IXGBE_MIN_RING_DESC 64 #define IXGBE_MAX_RING_DESC 8192 -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:57.831147322 +0000 +++ 0025-net-ixgbe-fix-minimum-Rx-Tx-descriptors.patch 2025-03-07 11:02:56.876718432 +0000 @@ -1 +1 @@ -From 6808ee1ceddc76846f80ae3d05aad374a34a1754 Mon Sep 17 00:00:00 2001 +From 1abcbab1309344932a050a9a91a4bb562fecddf2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6808ee1ceddc76846f80ae3d05aad374a34a1754 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19,2 +20,2 @@ - doc/guides/nics/ixgbe.rst | 8 +++----- - drivers/net/intel/ixgbe/ixgbe_rxtx.h | 2 +- + doc/guides/nics/ixgbe.rst | 8 +++----- + drivers/net/ixgbe/ixgbe_rxtx.h | 2 +- @@ -43,5 +44,5 @@ -diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.h b/drivers/net/intel/ixgbe/ixgbe_rxtx.h -index 278f665108..54569c7ade 100644 ---- a/drivers/net/intel/ixgbe/ixgbe_rxtx.h -+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.h -@@ -27,5 +27,5 @@ +diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h +index 0550c1da60..a5807960a7 100644 +--- a/drivers/net/ixgbe/ixgbe_rxtx.h ++++ b/drivers/net/ixgbe/ixgbe_rxtx.h +@@ -25,5 +25,5 @@