From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C086846364 for ; Fri, 7 Mar 2025 13:48:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6CC9402C3; Fri, 7 Mar 2025 13:48:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E11E1402C3 for ; Fri, 7 Mar 2025 13:48:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69e7GXqIVLhMCAH+kJZzdwa+USMDjNmP8ZXQiFYT7E4=; b=YsIFPUsCxRo2tvY5TnLPZlMlXKTwu5pVnc82+pkvSOfVz+xR8ulVE0lFILOSveCZvV7HNj 8shEjcfCHXhR3MesTBkcDuMHeYKn/dfnC3RdmA+3ZSVuzl7/8zKrzZ25I/UkeVs3aPeSLs 7MXZie8cmXR2jDQMdthkTgm77aHTQvo= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-sry_MyfIPReenhEzyia1Vw-1; Fri, 07 Mar 2025 07:48:34 -0500 X-MC-Unique: sry_MyfIPReenhEzyia1Vw-1 X-Mimecast-MFC-AGG-ID: sry_MyfIPReenhEzyia1Vw_1741351713 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 992A418009FC; Fri, 7 Mar 2025 12:48:33 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 05C821956095; Fri, 7 Mar 2025 12:48:31 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: fix leak in HWS flow counter action' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:47:00 +0000 Message-ID: <20250307124726.475001-27-ktraynor@redhat.com> In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com> References: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: t7IKgEFnw-750YPg4UGkuTlsqA4pqSKkyJEOSFjot1I_1741351713 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/daeec245a60a4fc3848a41073438a0471dffe920 Thanks. Kevin --- >From daeec245a60a4fc3848a41073438a0471dffe920 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 27 Jan 2025 11:53:47 +0100 Subject: [PATCH] net/mlx5: fix leak in HWS flow counter action [ upstream commit 9e34fcc81c005a60c919c572ef83c10ebb0201af ] This was caught by our internal covscan. mp_name can be leaked in case of errors. Fixes: 4d368e1da3a4 ("net/mlx5: support flow counter action for HWS") Signed-off-by: David Marchand Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_hws_cnt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c index 0197c098f6..eaceedd5ba 100644 --- a/drivers/net/mlx5/mlx5_hws_cnt.c +++ b/drivers/net/mlx5/mlx5_hws_cnt.c @@ -724,5 +724,5 @@ mlx5_hws_cnt_pool_create(struct rte_eth_dev *dev, ret = mlx5_hws_cnt_svc_init(priv->sh, error); if (ret) - return ret; + goto error; } cparam.fetch_sz = HWS_CNT_CACHE_FETCH_DEFAULT; @@ -768,4 +768,5 @@ error: mlx5_hws_cnt_pool_destroy(priv->sh, cpool); priv->hws_cpool = NULL; + mlx5_free(mp_name); return ret; } -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:57.902815983 +0000 +++ 0027-net-mlx5-fix-leak-in-HWS-flow-counter-action.patch 2025-03-07 11:02:56.879599449 +0000 @@ -1 +1 @@ -From 9e34fcc81c005a60c919c572ef83c10ebb0201af Mon Sep 17 00:00:00 2001 +From daeec245a60a4fc3848a41073438a0471dffe920 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9e34fcc81c005a60c919c572ef83c10ebb0201af ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org