From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E74A046364 for ; Fri, 7 Mar 2025 13:48:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E187B40E3A; Fri, 7 Mar 2025 13:48:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2B9A6402EF for ; Fri, 7 Mar 2025 13:48:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q68UVpS0t6klqfMndVq/8NyN7DjuK0eokhss6nu4O6s=; b=h/fIw89e5s8KII0kzfhcadLGSwzC6walEAXxBiPvRJdAdL4sWzj23lcVOZP9BXB2ALX94s i2VvVHMUSXnQbaCefzqP5K4XjBN4CzrW1zoBB7mY82D6nzBoAMd6ubzA58cySoinLqhxP4 uxnwUJ7fZD/A1elyrMKpQcI9ZilwffI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-209-3LiWPK1qM6qWont6YL73Ug-1; Fri, 07 Mar 2025 07:48:36 -0500 X-MC-Unique: 3LiWPK1qM6qWont6YL73Ug-1 X-Mimecast-MFC-AGG-ID: 3LiWPK1qM6qWont6YL73Ug_1741351715 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B9373180AB16; Fri, 7 Mar 2025 12:48:35 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 357331956095; Fri, 7 Mar 2025 12:48:33 +0000 (UTC) From: Kevin Traynor To: Kevin Traynor Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: fix crash with null flow list creation' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:47:01 +0000 Message-ID: <20250307124726.475001-28-ktraynor@redhat.com> In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com> References: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NNDuuR9XbQsAJFkbbNRp-M8N1WPp1CpOJ4PIqkqplNM_1741351715 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/88819b70bbbc88fa3d5e04f0f3099ae811dfda70 Thanks. Kevin --- >From 88819b70bbbc88fa3d5e04f0f3099ae811dfda70 Mon Sep 17 00:00:00 2001 From: Kevin Traynor Date: Fri, 14 Feb 2025 10:05:45 +0000 Subject: [PATCH] net/mlx5: fix crash with null flow list creation [ upstream commit c30b356a4d48542fe99c47aa470afc8cd1ced9f5 ] flow null driver ops may get selected and try to call .list_create causing a seg fault. Full details and back traces in bugzilla. Add a null ops implementation for .list_create. Bugzilla ID: 1661 Fixes: e38776c36c8a ("net/mlx5: introduce HWS for non-template flow API") Signed-off-by: Kevin Traynor Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 3d3b422f05..936a82e524 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -4032,4 +4032,18 @@ mlx5_flow_validate_item_nsh(struct rte_eth_dev *dev, } +static uintptr_t +flow_null_list_create(struct rte_eth_dev *dev __rte_unused, + enum mlx5_flow_type type __rte_unused, + const struct rte_flow_attr *attr __rte_unused, + const struct rte_flow_item items[] __rte_unused, + const struct rte_flow_action actions[] __rte_unused, + bool external __rte_unused, + struct rte_flow_error *error) +{ + rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, NULL); + return 0; +} + static int flow_null_validate(struct rte_eth_dev *dev __rte_unused, @@ -4151,4 +4165,5 @@ flow_null_counter_query(struct rte_eth_dev *dev, /* Void driver to protect from null pointer reference. */ const struct mlx5_flow_driver_ops mlx5_flow_null_drv_ops = { + .list_create = flow_null_list_create, .validate = flow_null_validate, .prepare = flow_null_prepare, -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:57.937256954 +0000 +++ 0028-net-mlx5-fix-crash-with-null-flow-list-creation.patch 2025-03-07 11:02:56.886335768 +0000 @@ -1 +1 @@ -From c30b356a4d48542fe99c47aa470afc8cd1ced9f5 Mon Sep 17 00:00:00 2001 +From 88819b70bbbc88fa3d5e04f0f3099ae811dfda70 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c30b356a4d48542fe99c47aa470afc8cd1ced9f5 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index a2ee237841..3fbe89a9d4 100644 +index 3d3b422f05..936a82e524 100644