From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47EC646364 for ; Fri, 7 Mar 2025 13:47:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4115340E30; Fri, 7 Mar 2025 13:47:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6CD1E40E30 for ; Fri, 7 Mar 2025 13:47:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFhHOsQ47joYDDHExJufv5PBbeuSVNjkYprZYSgXv80=; b=RRmEuHBbNqWwRJfriUT77K2ovBOmFNSyIt/efxwauXp+BqjNjJUxSTAUyirE5rSbJOwh4e v5HHIiwzr6sYCIs9c1StLGsh19g8X4X3+RexLKuPkUyYcuuGa9yAxrc3nWwHXMGTXcgiGX /8egErF2gDsaAN0sVIzZfTr6ynAwB2o= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-685-m-pbqazfNCOoBjiLDldXYQ-1; Fri, 07 Mar 2025 07:47:40 -0500 X-MC-Unique: m-pbqazfNCOoBjiLDldXYQ-1 X-Mimecast-MFC-AGG-ID: m-pbqazfNCOoBjiLDldXYQ_1741351660 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D3BA4180035C; Fri, 7 Mar 2025 12:47:39 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 968971956095; Fri, 7 Mar 2025 12:47:38 +0000 (UTC) From: Kevin Traynor To: Long Li Cc: dpdk stable Subject: patch 'net/netvsc: remove device if its net devices removed' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:46:36 +0000 Message-ID: <20250307124726.475001-3-ktraynor@redhat.com> In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com> References: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kVcEorH6dtFUCPzBEYHacp69x7FSpV5xvZD8WGqG8Iw_1741351660 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/0b181fd78d3ef1833dd1bf7bb4c25dec2e4b3fb5 Thanks. Kevin --- >From 0b181fd78d3ef1833dd1bf7bb4c25dec2e4b3fb5 Mon Sep 17 00:00:00 2001 From: Long Li Date: Thu, 13 Feb 2025 10:58:24 -0800 Subject: [PATCH] net/netvsc: remove device if its net devices removed [ upstream commit 1ec0995e173da14f2871ee19326f275f94f412c4 ] An RTE device can have multiple Ethernet devices. On hot plug events, it can't be removed until all its Ethernet devices have been removed. Fixes: a2a23a794b3a ("net/netvsc: support VF device hot add/remove") Signed-off-by: Long Li --- drivers/net/netvsc/hn_vf.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c index b664beaa5d..5d8058774d 100644 --- a/drivers/net/netvsc/hn_vf.c +++ b/drivers/net/netvsc/hn_vf.c @@ -103,4 +103,5 @@ static void hn_remove_delayed(void *args) struct rte_device *dev = rte_eth_devices[port_id].device; int ret; + bool all_eth_removed; /* Tell VSP to switch data path to synthetic */ @@ -139,5 +140,15 @@ static void hn_remove_delayed(void *args) port_id, ret); - ret = rte_dev_remove(dev); + /* Remove the rte device when all its eth devices are removed */ + all_eth_removed = true; + RTE_ETH_FOREACH_DEV_OF(port_id, dev) { + if (rte_eth_devices[port_id].state != RTE_ETH_DEV_UNUSED) { + all_eth_removed = false; + break; + } + } + if (all_eth_removed) + ret = rte_dev_remove(dev); + hv->vf_ctx.vf_state = vf_removed; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:57.009515994 +0000 +++ 0003-net-netvsc-remove-device-if-its-net-devices-removed.patch 2025-03-07 11:02:56.790335354 +0000 @@ -1 +1 @@ -From 1ec0995e173da14f2871ee19326f275f94f412c4 Mon Sep 17 00:00:00 2001 +From 0b181fd78d3ef1833dd1bf7bb4c25dec2e4b3fb5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1ec0995e173da14f2871ee19326f275f94f412c4 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org