From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A8AD46364 for ; Fri, 7 Mar 2025 13:48:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 851DB402C3; Fri, 7 Mar 2025 13:48:53 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 198EB402C3 for ; Fri, 7 Mar 2025 13:48:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6KDOZLGGWgGlKuHWu+3zdwFvvF8naLM65QNMg40QZu8=; b=hX6AMtFT80qbfVfspy/KRQLZKtqDxskkORNp0ARoZQlt6gM3ORPQgHYM5KZwr+RwtraZyl +ZkI0dA5X5lSS1Pi7cHff379B3ORpuWR5I+28SpJXUpuIatiNYhjLmnwUYaAPloX8shxkv rbItw8W1ecCjsn4YhXeJ8MauweTufgs= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-BQDn7vWHPUiwZIOOpaEMTA-1; Fri, 07 Mar 2025 07:48:47 -0500 X-MC-Unique: BQDn7vWHPUiwZIOOpaEMTA-1 X-Mimecast-MFC-AGG-ID: BQDn7vWHPUiwZIOOpaEMTA_1741351725 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6F4521828B65; Fri, 7 Mar 2025 12:48:44 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 74F4D1956095; Fri, 7 Mar 2025 12:48:42 +0000 (UTC) From: Kevin Traynor To: Andre Muezerie Cc: David Marchand , dpdk stable Subject: patch 'stack: fix pop in C11 implementation' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:47:05 +0000 Message-ID: <20250307124726.475001-32-ktraynor@redhat.com> In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com> References: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HIQNozRrxfouxMjj2_e6H1SN-TpDxNPUO20D9aY2qoY_1741351725 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/cd6fd838eea712e240afb4d7c77e50b9237d42e6 Thanks. Kevin --- >From cd6fd838eea712e240afb4d7c77e50b9237d42e6 Mon Sep 17 00:00:00 2001 From: Andre Muezerie Date: Mon, 3 Feb 2025 17:23:37 -0800 Subject: [PATCH] stack: fix pop in C11 implementation [ upstream commit 916424f2c6029cd8da5c56ed62847a4b09d7e0ac ] Variable "success" was not being initialized and there was a code path where the last do/while loop in __rte_stack_lf_pop_elems looked at the value of this variable before it was set to any. Compiling with msvc resulted in stack_lf_autotest sometimes crashing. The fix is to initialize the variable. This same fix was applied to stack\rte_stack_lf_generic.h in the past but was missed here. Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation") Signed-off-by: Andre Muezerie Reviewed-by: David Marchand --- lib/stack/rte_stack_lf_c11.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stack/rte_stack_lf_c11.h b/lib/stack/rte_stack_lf_c11.h index 60d46e963b..ee1c79c095 100644 --- a/lib/stack/rte_stack_lf_c11.h +++ b/lib/stack/rte_stack_lf_c11.h @@ -78,5 +78,5 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list, struct rte_stack_lf_head old_head; uint64_t len; - int success; + int success = 0; /* Reserve num elements, if available */ -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:58.087113084 +0000 +++ 0032-stack-fix-pop-in-C11-implementation.patch 2025-03-07 11:02:56.899467733 +0000 @@ -1 +1 @@ -From 916424f2c6029cd8da5c56ed62847a4b09d7e0ac Mon Sep 17 00:00:00 2001 +From cd6fd838eea712e240afb4d7c77e50b9237d42e6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 916424f2c6029cd8da5c56ed62847a4b09d7e0ac ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org