From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABDE546364 for ; Fri, 7 Mar 2025 13:48:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2BFD402C3; Fri, 7 Mar 2025 13:48:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2475F40E3A for ; Fri, 7 Mar 2025 13:48:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dJB83aLyOiW+EV9xH+yU2QET98ur4C66QBvlqCs6VLY=; b=NzOQTFGp8pBOtlc7CezatF2UXuBcvDvMgFo3LEN7VkH7QwL3YGlnumKw2Vk+XK8UGpiwRY 5YsaoYWcGncsg7Axudkj+mSfTKhtb1v/kX3o7KZm5sZqqbRp2PiJdNBzAvPDVAoh22vCRN LqKYzGnZv2QPOO9eHWD2sNknboreWzI= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-wb_LqU21ObitXbBH08SZgA-1; Fri, 07 Mar 2025 07:48:51 -0500 X-MC-Unique: wb_LqU21ObitXbBH08SZgA-1 X-Mimecast-MFC-AGG-ID: wb_LqU21ObitXbBH08SZgA_1741351729 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AD4451955DE9; Fri, 7 Mar 2025 12:48:49 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E64FE1956095; Fri, 7 Mar 2025 12:48:47 +0000 (UTC) From: Kevin Traynor To: Nithinsen Kaithakadan Cc: Anoob Joseph , Akhil Goyal , dpdk stable Subject: patch 'examples/ipsec-secgw: fix IV length in CTR 192/256' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:47:07 +0000 Message-ID: <20250307124726.475001-34-ktraynor@redhat.com> In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com> References: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OfdQhrvlPdkUgQBC8qRgnulkSMwzajrYk66glZmVpLw_1741351729 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c0be494e48b95495ba1976d61d71df60f0e1849e Thanks. Kevin --- >From c0be494e48b95495ba1976d61d71df60f0e1849e Mon Sep 17 00:00:00 2001 From: Nithinsen Kaithakadan Date: Fri, 7 Feb 2025 13:45:43 +0000 Subject: [PATCH] examples/ipsec-secgw: fix IV length in CTR 192/256 [ upstream commit 7e2a7c336737084d8d8ef89260e511ff5670edbf ] This patch fixes IV length to 8 in case of AES-CTR 192/256. AES-CTR IV length is set 8 in SA config as it is used for per packet IV length and set it to 16 in xform since the application populates 16B IV in the datapath. AES-CTR requires 16B IV constructed from nonce and counter. Fixes: 9413c3901f31 ("examples/ipsec-secgw: support additional algorithms") Signed-off-by: Nithinsen Kaithakadan Acked-by: Anoob Joseph Acked-by: Akhil Goyal --- .mailmap | 1 + examples/ipsec-secgw/sa.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index ab00a189cb..a4bacad9a4 100644 --- a/.mailmap +++ b/.mailmap @@ -1114,4 +1114,5 @@ Nirmoy Das Nishikant Nayak Nithin Dabilpuram +Nithinsen Kaithakadan Nitin Saxena Nitzan Weller diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index 425bfbf590..313919b4b5 100644 --- a/examples/ipsec-secgw/sa.c +++ b/examples/ipsec-secgw/sa.c @@ -105,5 +105,5 @@ const struct supported_cipher_algo cipher_algos[] = { .keyword = "aes-192-ctr", .algo = RTE_CRYPTO_CIPHER_AES_CTR, - .iv_len = 16, + .iv_len = 8, .block_size = 16, .key_len = 28 @@ -112,5 +112,5 @@ const struct supported_cipher_algo cipher_algos[] = { .keyword = "aes-256-ctr", .algo = RTE_CRYPTO_CIPHER_AES_CTR, - .iv_len = 16, + .iv_len = 8, .block_size = 16, .key_len = 36 -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:58.155982428 +0000 +++ 0034-examples-ipsec-secgw-fix-IV-length-in-CTR-192-256.patch 2025-03-07 11:02:56.905335850 +0000 @@ -1 +1 @@ -From 7e2a7c336737084d8d8ef89260e511ff5670edbf Mon Sep 17 00:00:00 2001 +From c0be494e48b95495ba1976d61d71df60f0e1849e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7e2a7c336737084d8d8ef89260e511ff5670edbf ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index b3ffe83f46..b8c482d0e5 100644 +index ab00a189cb..a4bacad9a4 100644 @@ -28 +29 @@ -@@ -1120,4 +1120,5 @@ Nirmoy Das +@@ -1114,4 +1114,5 @@ Nirmoy Das