From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2265246364 for ; Fri, 7 Mar 2025 13:49:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A46940E41; Fri, 7 Mar 2025 13:49:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5CA7E402C3 for ; Fri, 7 Mar 2025 13:48:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NifEq8lfCYyHMuakBLW1Z1YV06y4c1jFy420LQxtPCo=; b=ik0UW02DKzpkcvzAy6c0N83fJCzJ5DEjINZnbO8GgIVZU4TqEYueHptdqk7UgWsq2GXlIJ w26sPxHBMF5zl/3Q3ybTnv+kBPIr9lxjoxRR4e/NlOf1maOESUIs3Fvk0AHDD8mRQosFIh G8KaY4wcezqTmSwQXTide2HQjNjmj+s= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-410-NCTEwIxAPP225ofsGdZQ9g-1; Fri, 07 Mar 2025 07:48:57 -0500 X-MC-Unique: NCTEwIxAPP225ofsGdZQ9g-1 X-Mimecast-MFC-AGG-ID: NCTEwIxAPP225ofsGdZQ9g_1741351736 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6A02319560AF; Fri, 7 Mar 2025 12:48:56 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D10F31956095; Fri, 7 Mar 2025 12:48:54 +0000 (UTC) From: Kevin Traynor To: Gowrishankar Muthukrishnan Cc: Akhil Goyal , dpdk stable Subject: patch 'crypto/openssl: validate incorrect RSA signature' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:47:10 +0000 Message-ID: <20250307124726.475001-37-ktraynor@redhat.com> In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com> References: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QkQzLy5Zu0I-q29Kbi9H5wCrwOuTsUnYmtztHjFy6jQ_1741351736 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1e5703cce5415e8bf08e3cc2ffe0869fd26545e0 Thanks. Kevin --- >From 1e5703cce5415e8bf08e3cc2ffe0869fd26545e0 Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Sun, 23 Feb 2025 11:34:04 +0530 Subject: [PATCH] crypto/openssl: validate incorrect RSA signature [ upstream commit 6c209dd8785f34bfdc99b869c14e063d084508c2 ] Return correct error status when incorrect signature is used in RSA verify op. Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- drivers/crypto/openssl/rte_openssl_pmd.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index b090611bd0..5bfad92b7c 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -2804,7 +2804,13 @@ process_openssl_rsa_op_evp(struct rte_crypto_op *cop, } - if (EVP_PKEY_verify_recover(rsa_ctx, tmp, &outlen, + ret = EVP_PKEY_verify_recover(rsa_ctx, tmp, &outlen, op->rsa.sign.data, - op->rsa.sign.length) <= 0) { + op->rsa.sign.length); + if (ret <= 0) { + /* OpenSSL RSA verification returns one on + * successful verification, otherwise 0. Hence, + * this enqueue operation should succeed even if + * invalid signature has been requested in verify. + */ OPENSSL_free(tmp); goto err_rsa; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:58.255536448 +0000 +++ 0037-crypto-openssl-validate-incorrect-RSA-signature.patch 2025-03-07 11:02:56.907335858 +0000 @@ -1 +1 @@ -From 6c209dd8785f34bfdc99b869c14e063d084508c2 Mon Sep 17 00:00:00 2001 +From 1e5703cce5415e8bf08e3cc2ffe0869fd26545e0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6c209dd8785f34bfdc99b869c14e063d084508c2 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org