From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78FD946364 for ; Fri, 7 Mar 2025 13:48:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73F6740E30; Fri, 7 Mar 2025 13:48:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1B55540E41 for ; Fri, 7 Mar 2025 13:48:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741351694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zXVJuOMOilyzdhn92TOohxFnfWssS+Tbe2rX5F0Kdls=; b=aLw6fhCG4QJCMSRVgPhhKziK0Yaq/Xc/wCrOdF5arnGML8YU7t2Yi7yAES8imPFGXGWSD/ 8NnTo4/UE9gUuWmJSWzaggS/WWhNYPpyQTkQ8Hgf2zrVwtlOPQwMQbbKoSVThIg6LHR4ke TF59nhKGftEIkud9c7hio3hgwVpyBsw= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-IaiX0OrcN3mqP9QIgmklaA-1; Fri, 07 Mar 2025 07:47:43 -0500 X-MC-Unique: IaiX0OrcN3mqP9QIgmklaA-1 X-Mimecast-MFC-AGG-ID: IaiX0OrcN3mqP9QIgmklaA_1741351662 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 51584180049D; Fri, 7 Mar 2025 12:47:42 +0000 (UTC) Received: from rh.Home (unknown [10.45.226.25]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8790E1956095; Fri, 7 Mar 2025 12:47:40 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Bruce Richardson , dpdk stable Subject: patch 'doc: fix feature flags for queue start/stop' has been queued to stable release 24.11.2 Date: Fri, 7 Mar 2025 12:46:37 +0000 Message-ID: <20250307124726.475001-4-ktraynor@redhat.com> In-Reply-To: <20250307124726.475001-1-ktraynor@redhat.com> References: <20250307124726.475001-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TQH90oMgU7QdJOZftAhxRXXObvL4ScCE3F9ajbDyMHs_1741351662 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/12/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ff3e9c0712ecd03bd1f8ddcc2f33ef48c609aa89 Thanks. Kevin --- >From ff3e9c0712ecd03bd1f8ddcc2f33ef48c609aa89 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Mon, 16 Dec 2024 10:53:42 -0800 Subject: [PATCH] doc: fix feature flags for queue start/stop [ upstream commit 4f6641cbdd571433d38fd82781916e0f1e64908b ] Several drivers have mismatch between the ethdev ops for queue start/stop and the documentation. The gve driver does implement queue start/stop support. The mana, netvsc, virtio and vmxnet3 drivers do not implement the rx_queue_start callback. Fixes: 410333da8b5f ("net/mana: start/stop Tx queues") Fixes: beff6d8e8e2e ("net/netvsc: add documentation") Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files") Fixes: 24595041937e ("net/vmxnet3: update feature doc") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- doc/guides/nics/features.rst | 1 + doc/guides/nics/features/gve.ini | 1 + doc/guides/nics/features/mana.ini | 1 - doc/guides/nics/features/netvsc.ini | 1 - doc/guides/nics/features/virtio.ini | 1 - doc/guides/nics/features/vmxnet3.ini | 1 - 6 files changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index 8bd448139e..a075c057ec 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -150,4 +150,5 @@ Queue start/stop Supports starting/stopping a specific Rx/Tx queue of a port. +This is required for use deferred start configuration option. * **[implements] eth_dev_ops**: ``rx_queue_start``, ``rx_queue_stop``, ``tx_queue_start``, diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/features/gve.ini index 8dfa229bb0..f18b829eda 100644 --- a/doc/guides/nics/features/gve.ini +++ b/doc/guides/nics/features/gve.ini @@ -7,4 +7,5 @@ Speed capabilities = Y Link status = Y +Queue start/stop = Y MTU update = Y TSO = Y diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/features/mana.ini index 42fd3327d2..db555ffe27 100644 --- a/doc/guides/nics/features/mana.ini +++ b/doc/guides/nics/features/mana.ini @@ -9,5 +9,4 @@ Link status = P Removal event = Y Rx interrupt = Y -Queue start/stop = Y RSS hash = Y L3 checksum offload = Y diff --git a/doc/guides/nics/features/netvsc.ini b/doc/guides/nics/features/netvsc.ini index de8c698184..32df77a03e 100644 --- a/doc/guides/nics/features/netvsc.ini +++ b/doc/guides/nics/features/netvsc.ini @@ -8,5 +8,4 @@ Speed capabilities = P Link status = Y Free Tx mbuf on demand = Y -Queue start/stop = Y Scattered Rx = Y Promiscuous mode = Y diff --git a/doc/guides/nics/features/virtio.ini b/doc/guides/nics/features/virtio.ini index a5eab4932f..f0a1a564f9 100644 --- a/doc/guides/nics/features/virtio.ini +++ b/doc/guides/nics/features/virtio.ini @@ -9,5 +9,4 @@ Link status = Y Link status event = Y Rx interrupt = Y -Queue start/stop = Y Scattered Rx = P Promiscuous mode = Y diff --git a/doc/guides/nics/features/vmxnet3.ini b/doc/guides/nics/features/vmxnet3.ini index 971695fc4a..749887d642 100644 --- a/doc/guides/nics/features/vmxnet3.ini +++ b/doc/guides/nics/features/vmxnet3.ini @@ -8,5 +8,4 @@ Speed capabilities = P Link status = Y Link status event = Y -Queue start/stop = Y MTU update = Y LRO = Y -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-07 11:02:57.041873600 +0000 +++ 0004-doc-fix-feature-flags-for-queue-start-stop.patch 2025-03-07 11:02:56.793335367 +0000 @@ -1 +1 @@ -From 4f6641cbdd571433d38fd82781916e0f1e64908b Mon Sep 17 00:00:00 2001 +From ff3e9c0712ecd03bd1f8ddcc2f33ef48c609aa89 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4f6641cbdd571433d38fd82781916e0f1e64908b ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org