From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD21346423 for ; Wed, 19 Mar 2025 15:21:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA9194026B; Wed, 19 Mar 2025 15:21:50 +0100 (CET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id 32AC14026B for ; Wed, 19 Mar 2025 15:21:49 +0100 (CET) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3965c995151so4483316f8f.1 for ; Wed, 19 Mar 2025 07:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742394109; x=1742998909; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BBMmMyhonGIOMZrJyAt/E6tutCPY8O88bcEGzFy2ORA=; b=Elj2viDDqJ5IgCw/5Y4u/ey6tRxLrfuwoxm8KnMusnjQo1k/mEvFND0gTHg/DPOasZ 0k8uTPfKK3Fi/yVTnMTJk2lB/biZGNZxmTaNGkTywmU5CfbXuUs0pdf9NVPVDB7nfKV+ d+wE6YQcj+tidRf0U8RIWgMrt5nwVv0xwgHlbZnv/y/nj7qLt/F19VWS2YHMJdCmrzyR 5ecp2NBxTEacsNEQLgpyl9ipMTz32CtluPNQdufkfqrpUobxXv0WfL5T2jWPgRupwG7D NYV23cpT3pc2551fVNSIh6y+49yHqdWp/9VGv5/9UIHNQtqqAwH/XqBzM0w5U4U30fCI p9kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742394109; x=1742998909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BBMmMyhonGIOMZrJyAt/E6tutCPY8O88bcEGzFy2ORA=; b=Tvsu+3XWdlirn9Wn47DVXTqqlQ03ADF59GHkbaQee7FM81yZFn8NDlZSQXE3xHK9dl V4UU5jciuFKFKRwmvYMo3yvhPSxkgntoCKGPjnxyW4W/hsdQ+JzOZBPeaxDr6X9lr7/n LNQ7+3qGKn6zg+bLaK7bI3tTWPkyJ1JfNgxWOX/1YBxpVWXrqE5SXHevazFWH42lTJB5 UlsFNTPwz6ZDMIimbrTMbY8fR17BxM5aGDOE/jd33s7QekI+SEsbxo6ao/A7qlnJxe/s pOKRN7jg5mTtc4iUqybZS1iNnxKlAA8dWhqN6+ylv52YeeOVqn3y0K9FtvIsQ3110KiV meMQ== X-Forwarded-Encrypted: i=1; AJvYcCVC+ijLQKjma3KfFO9wbrEv6iEMnmLE/9L75THYuO3dV99ecYV/61ZvGUf/hUgqLOTf2ifAZCA=@dpdk.org X-Gm-Message-State: AOJu0YzKoF/rg56W8JrrM19fz3mCMMXHzzzlbLo0VxdycCQNJHw7LhYt +ELaqL/j/iTuA80wZUTvryn7onNFbWAOPixwCn8Bba57P456PRuQ X-Gm-Gg: ASbGncuBCEfVno4wIqAvta9chKko72cHJrzugCiLqQinJ4x+6ioAeyhLeACnBsq0Rht 4EY2n8jv5zj2qPjdS0/16arQUjq9z1YX1pAhZR3dVOWMeL8ASKRuFD9FO6nTIjpyTXyCkKTyoRf Y/YfXjZ27emQztquMHPu3X8aJrNm3rga+ORAcShmdFAOlMxMM3erKmk0nxM/BHKdxfzB5rcYzT1 oGefc87w20Ntvko+Vv42VRhBlDXcIf0DAk/mqs5FFJf8ROnVGDf8dQTLKJnjOaR/n6j0oWU3gkM y1+U54ohnObuTOJU0kEjV3e942ZTNW3uq8W5C8c/C7MvI7h30Vs= X-Google-Smtp-Source: AGHT+IFxdddO7GlmfJpYxMT0YaWCI5HfxfF+0x5DGlILXswUVpa0SbfbSdg2/suqvSPtA6+koPlSgw== X-Received: by 2002:a05:6000:400a:b0:391:3207:2e75 with SMTP id ffacd0b85a97d-399739bc965mr3386880f8f.18.1742394108378; Wed, 19 Mar 2025 07:21:48 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:4eab:5a5d:ba39:287e]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-395cb7eb8c2sm20667311f8f.85.2025.03.19.07.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 07:21:47 -0700 (PDT) From: luca.boccassi@gmail.com To: Yang Ming Cc: Bruce Richardson , dpdk stable Subject: patch 'net/iavf: fix mbuf release in Arm multi-process' has been queued to stable release 22.11.8 Date: Wed, 19 Mar 2025 14:21:12 +0000 Message-ID: <20250319142142.439602-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250307122431.1415551-28-luca.boccassi@gmail.com> References: <20250307122431.1415551-28-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/21/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/1011c5f2e70fdad2ea21c61cf73fd34a05bbe00a Thanks. Luca Boccassi --- >From 1011c5f2e70fdad2ea21c61cf73fd34a05bbe00a Mon Sep 17 00:00:00 2001 From: Yang Ming Date: Fri, 7 Mar 2025 13:40:22 +0800 Subject: [PATCH] net/iavf: fix mbuf release in Arm multi-process [ upstream commit 289d1b2e348032543f9b823d2eaf3d0e0073af56 ] This patch addresses a bug related to mbuf release in the Arm architecture. The previous patch resolved the mbuf release issue in a multi-process environment but was only applicable to the x86 architecture, leaving Arm unaddressed. This patch extends the fix to include the Arm architecture, ensuring consistent behavior across both x86 and Arm platforms. Fixes: fced83c1229e ("net/iavf: fix mbuf release in multi-process") Signed-off-by: Yang Ming Acked-by: Bruce Richardson --- drivers/net/iavf/iavf_rxtx.c | 3 +++ drivers/net/iavf/iavf_rxtx.h | 2 ++ drivers/net/iavf/iavf_rxtx_vec_neon.c | 8 ++------ 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 3272553b5c..1f82d1cf3f 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -368,6 +368,9 @@ struct iavf_rxq_ops iavf_rxq_release_mbufs_ops[] = { #ifdef RTE_ARCH_X86 [IAVF_REL_MBUFS_SSE_VEC].release_mbufs = iavf_rx_queue_release_mbufs_sse, #endif +#ifdef RTE_ARCH_ARM64 + [IAVF_REL_MBUFS_NEON_VEC].release_mbufs = iavf_rx_queue_release_mbufs_neon, +#endif }; static const diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 180f7ec108..b56519a507 100644 --- a/drivers/net/iavf/iavf_rxtx.h +++ b/drivers/net/iavf/iavf_rxtx.h @@ -416,6 +416,7 @@ enum iavf_rxtx_rel_mbufs_type { IAVF_REL_MBUFS_DEFAULT = 0, IAVF_REL_MBUFS_SSE_VEC = 1, IAVF_REL_MBUFS_AVX512_VEC = 2, + IAVF_REL_MBUFS_NEON_VEC = 3, }; /* Receive Flex Descriptor profile IDs: There are a total @@ -724,6 +725,7 @@ void iavf_set_default_ptype_table(struct rte_eth_dev *dev); void iavf_tx_queue_release_mbufs_avx512(struct iavf_tx_queue *txq); void iavf_rx_queue_release_mbufs_sse(struct iavf_rx_queue *rxq); void iavf_tx_queue_release_mbufs_sse(struct iavf_tx_queue *txq); +void iavf_rx_queue_release_mbufs_neon(struct iavf_rx_queue *rxq); static inline void iavf_dump_rx_descriptor(struct iavf_rx_queue *rxq, diff --git a/drivers/net/iavf/iavf_rxtx_vec_neon.c b/drivers/net/iavf/iavf_rxtx_vec_neon.c index 83825aa427..23c1d6c3a2 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_neon.c +++ b/drivers/net/iavf/iavf_rxtx_vec_neon.c @@ -391,20 +391,16 @@ iavf_recv_pkts_vec(void *__rte_restrict rx_queue, return _recv_raw_pkts_vec(rx_queue, rx_pkts, nb_pkts, NULL); } -static void __rte_cold +void __rte_cold iavf_rx_queue_release_mbufs_neon(struct iavf_rx_queue *rxq) { _iavf_rx_queue_release_mbufs_vec(rxq); } -static const struct iavf_rxq_ops neon_vec_rxq_ops = { - .release_mbufs = iavf_rx_queue_release_mbufs_neon, -}; - int __rte_cold iavf_rxq_vec_setup(struct iavf_rx_queue *rxq) { - rxq->ops = &neon_vec_rxq_ops; + rxq->rel_mbufs_type = IAVF_REL_MBUFS_NEON_VEC; return iavf_rxq_vec_setup_default(rxq); } -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-19 14:20:57.121189100 +0000 +++ 0001-net-iavf-fix-mbuf-release-in-Arm-multi-process.patch 2025-03-19 14:20:57.049288704 +0000 @@ -1 +1 @@ -From 289d1b2e348032543f9b823d2eaf3d0e0073af56 Mon Sep 17 00:00:00 2001 +From 1011c5f2e70fdad2ea21c61cf73fd34a05bbe00a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 289d1b2e348032543f9b823d2eaf3d0e0073af56 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19,3 +20,3 @@ - drivers/net/intel/iavf/iavf_rxtx.c | 3 +++ - drivers/net/intel/iavf/iavf_rxtx.h | 2 ++ - drivers/net/intel/iavf/iavf_rxtx_vec_neon.c | 8 ++------ + drivers/net/iavf/iavf_rxtx.c | 3 +++ + drivers/net/iavf/iavf_rxtx.h | 2 ++ + drivers/net/iavf/iavf_rxtx_vec_neon.c | 8 ++------ @@ -24,5 +25,5 @@ -diff --git a/drivers/net/intel/iavf/iavf_rxtx.c b/drivers/net/intel/iavf/iavf_rxtx.c -index 657963750d..a999073691 100644 ---- a/drivers/net/intel/iavf/iavf_rxtx.c -+++ b/drivers/net/intel/iavf/iavf_rxtx.c -@@ -380,6 +380,9 @@ struct iavf_rxq_ops iavf_rxq_release_mbufs_ops[] = { +diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c +index 3272553b5c..1f82d1cf3f 100644 +--- a/drivers/net/iavf/iavf_rxtx.c ++++ b/drivers/net/iavf/iavf_rxtx.c +@@ -368,6 +368,9 @@ struct iavf_rxq_ops iavf_rxq_release_mbufs_ops[] = { @@ -37,6 +38,6 @@ - static inline void -diff --git a/drivers/net/intel/iavf/iavf_rxtx.h b/drivers/net/intel/iavf/iavf_rxtx.h -index 6a54b446cf..823a6efa9a 100644 ---- a/drivers/net/intel/iavf/iavf_rxtx.h -+++ b/drivers/net/intel/iavf/iavf_rxtx.h -@@ -404,6 +404,7 @@ enum iavf_rxtx_rel_mbufs_type { + static const +diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h +index 180f7ec108..b56519a507 100644 +--- a/drivers/net/iavf/iavf_rxtx.h ++++ b/drivers/net/iavf/iavf_rxtx.h +@@ -416,6 +416,7 @@ enum iavf_rxtx_rel_mbufs_type { @@ -50,2 +51,2 @@ -@@ -729,6 +730,7 @@ void iavf_set_default_ptype_table(struct rte_eth_dev *dev); - void iavf_tx_queue_release_mbufs_avx512(struct ci_tx_queue *txq); +@@ -724,6 +725,7 @@ void iavf_set_default_ptype_table(struct rte_eth_dev *dev); + void iavf_tx_queue_release_mbufs_avx512(struct iavf_tx_queue *txq); @@ -53 +54 @@ - void iavf_tx_queue_release_mbufs_sse(struct ci_tx_queue *txq); + void iavf_tx_queue_release_mbufs_sse(struct iavf_tx_queue *txq); @@ -58,5 +59,5 @@ -diff --git a/drivers/net/intel/iavf/iavf_rxtx_vec_neon.c b/drivers/net/intel/iavf/iavf_rxtx_vec_neon.c -index 6bc8e1db2a..a583340f15 100644 ---- a/drivers/net/intel/iavf/iavf_rxtx_vec_neon.c -+++ b/drivers/net/intel/iavf/iavf_rxtx_vec_neon.c -@@ -393,20 +393,16 @@ iavf_recv_pkts_vec(void *__rte_restrict rx_queue, +diff --git a/drivers/net/iavf/iavf_rxtx_vec_neon.c b/drivers/net/iavf/iavf_rxtx_vec_neon.c +index 83825aa427..23c1d6c3a2 100644 +--- a/drivers/net/iavf/iavf_rxtx_vec_neon.c ++++ b/drivers/net/iavf/iavf_rxtx_vec_neon.c +@@ -391,20 +391,16 @@ iavf_recv_pkts_vec(void *__rte_restrict rx_queue, @@ -82,2 +83 @@ - rxq->mbuf_initializer = ci_rxq_mbuf_initializer(rxq->port_id); - return 0; + return iavf_rxq_vec_setup_default(rxq); @@ -84,0 +85 @@ +