From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEDD446423 for ; Wed, 19 Mar 2025 15:22:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E838640649; Wed, 19 Mar 2025 15:22:10 +0100 (CET) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id AB56640611 for ; Wed, 19 Mar 2025 15:22:09 +0100 (CET) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43cec5cd73bso31505995e9.3 for ; Wed, 19 Mar 2025 07:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742394129; x=1742998929; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hTGATzSQwQ4JjQVY3knN7/jF+97L0Zz+VDcIK7xuzAA=; b=ZARy931nkuGa0Lrr/8JtT8miX0c7MeQlS3WLyrmPgznFNBrrb/k8ljzwVWbozKA9vm yJUV+dOPVKwITUwOzv13M1r4Zll3UzmqLtrHm6AeR8voU6pOT8wZiB+52DjbflYlbTNk 5yI/oiE4dwmngThGuvgbvQi+L2uPRUiwwl+6QYulH7KM1MekPotNj4Z7QhDA671DOITh bRLG2x38kgdOA4D1p+YEQgSA+OjaX8v4MVFJ4C61gqzJobJ7oQ2aoeaF4UErXOMp45Lh iZiP7c96ocxqm4ju30utV8w1X74NqOpmplg1UGgVPIipd9+d0AWtav14F/W8GZ+potY8 n2AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742394129; x=1742998929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hTGATzSQwQ4JjQVY3knN7/jF+97L0Zz+VDcIK7xuzAA=; b=UQT6W/UVSkbjktcne/MvgqWqGdY3J24RW3kRvKuO23hWWkCuIFUAUgJM/Xoo6Gn9fD kT6jxWMwb8w20YsLbCJfER+xCHQkecrittgOBjyN1Pih16k6UgKUvyZqbDyM1taaBqsh eF9xnSlrAHRr5dN3MqZcrNLbzau0+S0U/oGXd8e939/r0HCsDMTQg3MLC8Cl8ekxHZ9H sKXxu5cND5s90LKGggwSVhXVlf+DsC4imZPRabqsyOzW11cu96PFL/hsnVXtVDmkEEL4 Qg7lVeOaycVWID4P/vqYPVPWLZhMQvQ+dQ3g3wSncg7OS+bPZKfo+ABIh0TJ/ua2mIaT bOHQ== X-Forwarded-Encrypted: i=1; AJvYcCXteEh0O6hEuwwrwPOuXY87Mkkli+C82FuROFwpkIQ6InFsAAQKSGSZ+YR+u5WBhPAGs4i+U3U=@dpdk.org X-Gm-Message-State: AOJu0YwLFuQoRFHp4yK9ZlDxJ+eGcMHpDdaRHWwF0Voqjt7/KwY2fpGk 7mKipomC8AOJNqcUqtf8/He8qxzqH3URfezMHOgH/SPcslWcvZ54IpwrUA== X-Gm-Gg: ASbGncsqrl3iFRMk4rsnpz0BhN160JEJCZ3JFoQYCQXvCuY8Kx1xW3s3WXpO0Cr43e8 pnLrCiodK+/6msumsLnBTZrJfdvQOxhfETdxVavgJTzRFA1/j6GGE1xHOIROHxLpiW24zUCnJWq BC8fOz+t7WTZ9mdBUb4v8jwx0os6yjb09TY1+C0eYTr5Th04v1IkGJxCIuLPZvTrtzccZlQiqzG k5PcB2ppgFyOAlcjJs67WJzuNU52U9Bvxvq3PU9Zi4rrMUCBJK+lngUiNWDAeEJ23uA42tCotox bWkZS6zaaasnOkqTB0OJISSAqLfa0mgTBe6X2LuUK8Vs18lAFmYWLBWDU9MLXw== X-Google-Smtp-Source: AGHT+IGWULbRh/iPpRMbLR9D9NL7LDC6cxHsLIc458ev10YY+D1Ze9wvaQUxmh//oq9BJ5GWWukj3Q== X-Received: by 2002:a05:600c:4503:b0:43d:609:b305 with SMTP id 5b1f17b1804b1-43d437c32a0mr34083375e9.17.1742394129083; Wed, 19 Mar 2025 07:22:09 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:4eab:5a5d:ba39:287e]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43d43f55c99sm20469125e9.24.2025.03.19.07.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 07:22:08 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Bruce Richardson , Vladimir Medvedkin , dpdk stable Subject: patch 'pdump: clear statistics when enabled' has been queued to stable release 22.11.8 Date: Wed, 19 Mar 2025 14:21:21 +0000 Message-ID: <20250319142142.439602-10-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250319142142.439602-1-luca.boccassi@gmail.com> References: <20250307122431.1415551-28-luca.boccassi@gmail.com> <20250319142142.439602-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/21/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/37489c4ec76b13fa4b79cbb0052c4418be665802 Thanks. Luca Boccassi --- >From 37489c4ec76b13fa4b79cbb0052c4418be665802 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 19 Dec 2024 15:58:53 -0800 Subject: [PATCH] pdump: clear statistics when enabled [ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ] The pdump statistics are used to keep track of the number of packets captured, filtered, etc. These need not be cumalative and instead should be start counting when capture starts. This fixes the issue where multiple invocations of dumpcap would include counts from previous invocations. Bugzilla ID: 1604 Fixes: 10f726efe26c ("pdump: support pcapng and filtering") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- lib/pdump/rte_pdump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index 63835a1a67..016a0c38cf 100644 --- a/lib/pdump/rte_pdump.c +++ b/lib/pdump/rte_pdump.c @@ -202,6 +202,8 @@ pdump_register_rx_callbacks(enum pdump_version ver, rte_errno); return rte_errno; } + + memset(&pdump_stats->rx[port][qid], 0, sizeof(struct rte_pdump_stats)); } else if (operation == DISABLE) { int ret; @@ -260,6 +262,7 @@ pdump_register_tx_callbacks(enum pdump_version ver, rte_errno); return rte_errno; } + memset(&pdump_stats->tx[port][qid], 0, sizeof(struct rte_pdump_stats)); } else if (operation == DISABLE) { int ret; -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-19 14:20:57.458335455 +0000 +++ 0010-pdump-clear-statistics-when-enabled.patch 2025-03-19 14:20:57.081289241 +0000 @@ -1 +1 @@ -From b8392fa204ed46b580d61e7621948f1b187c9f98 Mon Sep 17 00:00:00 2001 +From 37489c4ec76b13fa4b79cbb0052c4418be665802 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 679c3dd0b5..0e6ffc167b 100644 +index 63835a1a67..016a0c38cf 100644 @@ -28 +29 @@ -@@ -199,6 +199,8 @@ pdump_register_rx_callbacks(enum pdump_version ver, +@@ -202,6 +202,8 @@ pdump_register_rx_callbacks(enum pdump_version ver, @@ -37 +38 @@ -@@ -257,6 +259,7 @@ pdump_register_tx_callbacks(enum pdump_version ver, +@@ -260,6 +262,7 @@ pdump_register_tx_callbacks(enum pdump_version ver,