From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E113546423 for ; Wed, 19 Mar 2025 15:21:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF196402E8; Wed, 19 Mar 2025 15:21:50 +0100 (CET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id 61CB84026B for ; Wed, 19 Mar 2025 15:21:50 +0100 (CET) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3914aba1ce4so5609989f8f.2 for ; Wed, 19 Mar 2025 07:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742394110; x=1742998910; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5xfSK6IiLDxrUGh6d2uwWTmz0d5sRB1niez+CG835X8=; b=Me8q/g53De9lWECOZXdNaqAj5i42CGky6i8ooeexUHuGfVEBEm8gathsGWZm/t7ClU uGDfIk6Qq5TR+2rb2hLOBs5RJxRFmlmugfPlmzeUdAzG4BCVfPkf33zohAeuGDYlWqEm Vcd5uQkDb0jGi4rBwhKhfYI4HOeAEI5C8jPQ+ucvl2eVc2nG3Kxo7/3/9foqx84ASD3m bpGayWZuRxXfcfSIATP5Y4QSm38Ws+ZjYkGB3eQj9yhaipAp4S967H74P0oeXWXGeS+1 WMLuTFvUTxFLcCEGrzIp1mu9nCmmnldwT/yIU63JOpMx+tyMxcZDiL66JNRMMrN90oqK fI3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742394110; x=1742998910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5xfSK6IiLDxrUGh6d2uwWTmz0d5sRB1niez+CG835X8=; b=nad1NsgrqnEU4onjPXtdhzwXVX6d5M2Kzu1/ZUdFrAwB4sFthaFDcb4XvXjiL/SOOs AkBQ1parhwH5OrY8fmSSX+UnwKs++IL9l8Cy5zyFPMwo0EGJFD2a6dx3/xtlC70R9U3n PYBtBuz6ixB2ytAmhOVqco+5wyMmWcD0WFBuklS4bybiwQSqk37si9+FJjzOZ5SzAMWf VHT+H0s5uhKhm8SoHmY55WF4pV8Bq0Sw5DtE1GMs7AMzeec6KQo0Y249f0m84pEYpSBu ovylnRbGEmQhRozrlLrI2g7Izf+52Q8ot60kV+sIUzZpHTGcozDUHKMNrM4vcFTXBTrD IOaA== X-Forwarded-Encrypted: i=1; AJvYcCUUYf1Nh/N/4qT9pmKWhVuDWRwhtfEZn2W2mZlgKzVTdQdkUZpqzex5JCYgK5Mzsn7xtzKyBs8=@dpdk.org X-Gm-Message-State: AOJu0Yyr5oG4NdebFzwV3Mx6HtXFTCFL4dPiEttsYPLZLtrQ9aDRuLgh pkseQXolgeg0xy8JO9hLMO2fFISS8PxkePM1cuy8CP7D9v6LnvQkZr75lQ== X-Gm-Gg: ASbGncu0xXh8S8ODKYMhciTLqbX0ptWnt4CX3ChJOn7MXbTFZczBgMHgCvagP8UIGPu nx67f+wNnAfv9dptXAs50RMF9c3ti9N0BHD8WOKY8PgJ3ZHhY202rYreWnFzCatL+G0xXE/seVW QYyCrBYF7FrrDlTd473ND6D88Xyin2GAsjS9/WWy/L5+geoKT3shvD0uV/3N6m88k4phzwHTfrr X9fRVHClzgPco4inZ3sxIAHoKDiPghhZH0vYnKv/XV2OAEyxxzQmJ+/iZjLy9MTThL7ElXiMFjG qJK9F+ir39A2OW2MJzE0mA1u8O/Qec32CQ6wsDcTxw/WIdlMPmE= X-Google-Smtp-Source: AGHT+IGjBIH4zjkFALf57NI8ixHcy7GvrlkJtXOnZcLSeIr48+Ypu6Jt5drixRlJZv1ukiLGTtL8Ng== X-Received: by 2002:a05:6000:1f84:b0:398:9e96:e798 with SMTP id ffacd0b85a97d-399739c11ccmr3962975f8f.13.1742394109575; Wed, 19 Mar 2025 07:21:49 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:4eab:5a5d:ba39:287e]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-395c83b6b70sm21426398f8f.30.2025.03.19.07.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 07:21:49 -0700 (PDT) From: luca.boccassi@gmail.com To: Matthew Smith Cc: Vladimir Medvedkin , dpdk stable Subject: patch 'net/ice: fix dropped packets when using VRRP' has been queued to stable release 22.11.8 Date: Wed, 19 Mar 2025 14:21:13 +0000 Message-ID: <20250319142142.439602-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250319142142.439602-1-luca.boccassi@gmail.com> References: <20250307122431.1415551-28-luca.boccassi@gmail.com> <20250319142142.439602-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/21/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/7d5b6278e0800e92989582d86cf1eced59ee01a6 Thanks. Luca Boccassi --- >From 7d5b6278e0800e92989582d86cf1eced59ee01a6 Mon Sep 17 00:00:00 2001 From: Matthew Smith Date: Tue, 11 Mar 2025 21:40:31 +0000 Subject: [PATCH] net/ice: fix dropped packets when using VRRP [ upstream commit 6f866eb93e796aaf226f66c689e4c4e1b2290c90 ] While adding a vsi for an ice PF, set the ICE_AQ_VSI_SW_FLAG_LOCAL_LB flag. This will prevent packets from being dropped when using a virtual MAC address with VRRP. Also set the ICE_AQ_VSI_SW_FLAG_SRC_PRUNE flag to prevent transmitted packets from being looped back in some circumstances. Fixes: f9cf4f864150 ("net/ice: support device initialization") Signed-off-by: Matthew Smith Acked-by: Vladimir Medvedkin --- drivers/net/ice/ice_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index ba19c16384..591d067851 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -1591,6 +1591,10 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type) * by ice_init_hw */ vsi_ctx.info.sw_id = hw->port_info->sw_id; + vsi_ctx.info.sw_flags = ICE_AQ_VSI_SW_FLAG_LOCAL_LB; + vsi_ctx.info.sw_flags |= ICE_AQ_VSI_SW_FLAG_SRC_PRUNE; + cfg = ICE_AQ_VSI_PROP_SW_VALID; + vsi_ctx.info.valid_sections |= rte_cpu_to_le_16(cfg); vsi_ctx.info.sw_flags2 = ICE_AQ_VSI_SW_FLAG_LAN_ENA; /* Allow all untagged or tagged packets */ vsi_ctx.info.inner_vlan_flags = ICE_AQ_VSI_INNER_VLAN_TX_MODE_ALL; -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-19 14:20:57.159459325 +0000 +++ 0002-net-ice-fix-dropped-packets-when-using-VRRP.patch 2025-03-19 14:20:57.053288771 +0000 @@ -1 +1 @@ -From 6f866eb93e796aaf226f66c689e4c4e1b2290c90 Mon Sep 17 00:00:00 2001 +From 7d5b6278e0800e92989582d86cf1eced59ee01a6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6f866eb93e796aaf226f66c689e4c4e1b2290c90 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ - drivers/net/intel/ice/ice_ethdev.c | 4 ++++ + drivers/net/ice/ice_ethdev.c | 4 ++++ @@ -22,5 +23,5 @@ -diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c -index 3cdfa16f77..21d3795954 100644 ---- a/drivers/net/intel/ice/ice_ethdev.c -+++ b/drivers/net/intel/ice/ice_ethdev.c -@@ -1696,6 +1696,10 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type) +diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c +index ba19c16384..591d067851 100644 +--- a/drivers/net/ice/ice_ethdev.c ++++ b/drivers/net/ice/ice_ethdev.c +@@ -1591,6 +1591,10 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)