From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05F5646423 for ; Wed, 19 Mar 2025 15:21:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2FCD4026B; Wed, 19 Mar 2025 15:21:52 +0100 (CET) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id 710FD40609 for ; Wed, 19 Mar 2025 15:21:51 +0100 (CET) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3913cf69784so5867216f8f.1 for ; Wed, 19 Mar 2025 07:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742394111; x=1742998911; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xRMmoKZ3QdkeQ2GJwhc8t9M4fLyXgwxd/K5vTxSkSzk=; b=L34A6BnviWQaDpsZFaU878+V5r8LDsqP05w3wyrIlIwggTrFIFKEVTRbXJeLMRccXy LEPSSd8SNs1dotI5pZBBTrgfcZRwSb4rkhLs9rX9iKvIS9B9cI6K9a5uyZqM0VuiDsjf iFLgNO8hmEnZSOylnFJdY6uRbeLAT5PBHKh/1GL2tNT16xZRJGVgdgCcurRF0qdRn4+W isZChENe9z9fM8PEBaX9WqHcDOw3RfrwEiDVsSiZwfoSpWBLIiMAFJxJo80aBWKO2eE8 06/IM1KPn97xb2voO+yz4WixZQ4AsF5Zk+0M0sKC9XCPGo78iUiH1lXUGJJ+JQsFL6Qd wWJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742394111; x=1742998911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xRMmoKZ3QdkeQ2GJwhc8t9M4fLyXgwxd/K5vTxSkSzk=; b=nu3Z8mQXVRiiM6lhU9k8FwNQ+gxwzy1gEB6WngcPhoTK0eKVw5JQJg3VdRRgKHqDP6 AbDAzVY8wQZB3ReZJh8FJAIW7RU1nrRPDpN/MC6AzBHv3+9D2WM8p1SOzbt152OCUZ2x S0GSVfdCcqosKQxjVOSAi5BHeedhkjJskMawPVGjVXpmGnsO+QkBigyHIMFTxx0rKF/0 6aGSQV6oEvYVJlB5r3Jy/pZL+7ZE4xCQ43BGxYG6MVoL4PFbIKSSuanZYsf3jv2QLg9W wlzq7U31lxCFqYhUeQy+f767DD2DCIjoZo1YLcfcjHryc0UF4CdTvbGo3/Ux2/hFSC3M /7oA== X-Forwarded-Encrypted: i=1; AJvYcCXGGU0FYVs20E+E9idQLPPY8jouG4kWptRvZh3VVgyKk/LX8E4yCTqUAdudKrcujz8qkINBen8=@dpdk.org X-Gm-Message-State: AOJu0YzB7JuRKqoMXBH5YAL6T8NjSdE7QyN4wPw5hVRy5bDZtLyuTW4q f01uEBLE2kc/LbX5h644n8hYhtCsdZtgDxnM8teaxzHprMQ+w2L9RYOkcA== X-Gm-Gg: ASbGncvPRB6QLiZIbxIou0bmXlVpRbK6ta5duGCurMj72hrXcsHnnviuVH3iUclVUGb ZJ6YXv/YfafwxqebMflHdnpYRzcbwOQCdTom0403Z4zzjV84op8Xo3CXUDmK758HMSGDPyZnX3f M+2frlnbRQIIvtK2+bqGZgQ7KJ+8AdqNxbjfmvjSjNvgvuPJFEMtftMKUMy4MerAHcCos+Tsm4m m+l2bLNk16In3QUy+raoKOmkWbmi6jK+d9ZUnZSrsOO2IyTz6a7A7ih8/YiSSnWZqYfrCZU06bL +fH+CYEESTZayLY6c5kGM/4FKzK32lXbTAm3rHFyqmsVZepqls0= X-Google-Smtp-Source: AGHT+IE67FYGklHcmtVEevBqHobMesLUCOio34v17Fh/2WJztAmKJWdtcTSFHaQOgIuyzCEV0avwYQ== X-Received: by 2002:a5d:5f94:0:b0:391:11b:c7e9 with SMTP id ffacd0b85a97d-399739cbebcmr3424538f8f.28.1742394110834; Wed, 19 Mar 2025 07:21:50 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:4eab:5a5d:ba39:287e]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-395c82c255bsm20708909f8f.23.2025.03.19.07.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 07:21:50 -0700 (PDT) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Vladimir Medvedkin , dpdk stable Subject: patch 'net/iavf: check interrupt registration failure' has been queued to stable release 22.11.8 Date: Wed, 19 Mar 2025 14:21:14 +0000 Message-ID: <20250319142142.439602-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250319142142.439602-1-luca.boccassi@gmail.com> References: <20250307122431.1415551-28-luca.boccassi@gmail.com> <20250319142142.439602-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/21/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/63ddf74eee79d5db70c098e8fae414bdcba201c4 Thanks. Luca Boccassi --- >From 63ddf74eee79d5db70c098e8fae414bdcba201c4 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 10 Mar 2025 13:11:15 +0000 Subject: [PATCH] net/iavf: check interrupt registration failure [ upstream commit 12e8844f0bda3c4e4e578e180dfa0136f9285182 ] When registering interrupts, there was no check if the registration of the interrupt succeeded. Add in such a check, and go to fallback path if the check fails. This prevents errors on FreeBSD due to missed admin queue messages. Fixes: cd3b124955d4 ("net/iavf: enable interrupt polling") Signed-off-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- drivers/net/iavf/iavf_ethdev.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index c117896547..0ff55a57b4 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2656,18 +2656,16 @@ iavf_dev_init(struct rte_eth_dev *eth_dev) ð_dev->data->mac_addrs[0]); - if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) { - /* register callback func to eal lib */ - rte_intr_callback_register(pci_dev->intr_handle, - iavf_dev_interrupt_handler, - (void *)eth_dev); + if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR && + /* register callback func to eal lib */ + rte_intr_callback_register(pci_dev->intr_handle, + iavf_dev_interrupt_handler, (void *)eth_dev) == 0) /* enable uio intr after callback register */ rte_intr_enable(pci_dev->intr_handle); - } else { + else rte_eal_alarm_set(IAVF_ALARM_INTERVAL, iavf_dev_alarm_handler, eth_dev); - } /* configure and enable device interrupt */ iavf_enable_irq0(hw); -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-19 14:20:57.197210074 +0000 +++ 0003-net-iavf-check-interrupt-registration-failure.patch 2025-03-19 14:20:57.057288838 +0000 @@ -1 +1 @@ -From 12e8844f0bda3c4e4e578e180dfa0136f9285182 Mon Sep 17 00:00:00 2001 +From 63ddf74eee79d5db70c098e8fae414bdcba201c4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 12e8844f0bda3c4e4e578e180dfa0136f9285182 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - drivers/net/intel/iavf/iavf_ethdev.c | 12 +++++------- + drivers/net/iavf/iavf_ethdev.c | 12 +++++------- @@ -20,5 +21,5 @@ -diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c -index 9cd2b0c867..1ab84b0bfc 100644 ---- a/drivers/net/intel/iavf/iavf_ethdev.c -+++ b/drivers/net/intel/iavf/iavf_ethdev.c -@@ -2825,18 +2825,16 @@ iavf_dev_init(struct rte_eth_dev *eth_dev) +diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c +index c117896547..0ff55a57b4 100644 +--- a/drivers/net/iavf/iavf_ethdev.c ++++ b/drivers/net/iavf/iavf_ethdev.c +@@ -2656,18 +2656,16 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)