From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30DD446423 for ; Wed, 19 Mar 2025 15:21:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C4AC4026B; Wed, 19 Mar 2025 15:21:55 +0100 (CET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id C5D4440609 for ; Wed, 19 Mar 2025 15:21:52 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4394a0c65fcso41713055e9.1 for ; Wed, 19 Mar 2025 07:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742394112; x=1742998912; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pW35k70HwkdznE/D7otWUz50pMhq6pPu4067NYktOtk=; b=SHxoE9L50kIC3GZseMBu7QK7ghloElCirc3qCK28PqyYm76cpsjx/lLhqesWGRx/Pi YenJfLn5JtTAdkO0aVboDpBXBfLMX4Lmlr4qECAZGZp1AXd3R2F9Se1ieVOzNcusiLQG Ur1+eCisIl2xNZVtSXioTT9REibdz2aDzRlRwyAXZqW8pRhRKzVY9tlfCZ5dg6UHtv5Y +obIvVm+2ESVVewhTSMJ7YziBes4hWp679EaFIkte/RpIm1ZBSRkqot+iMYGuGj0HAOt CB7GUx/u0rH+ixx0If3ccgf1g9SYea0x1MTnlOGuPWgmiIpDvMPfknji/DA7g9kTQFR5 pVUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742394112; x=1742998912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pW35k70HwkdznE/D7otWUz50pMhq6pPu4067NYktOtk=; b=I5scUkHbf6Bbe0baCIt2RRzTXFRa+VmwztBUjI4RtC1H7AERNUlZbsSge4XNLm/omf T9ZNeZhwGN613/FgEyVyyEu27PWKiVOy4YYJtezKF4clMMYQjvbuli7wAsUCKReD+8YY mqv0sPzHTQLu3QgUvxXbzSGEI1zz1Mg0+Zgf0pscClhEUrrSXvGqq4rYCOs+kWpVuubi n6496MkEn0ozjhkAnruzNBW5JcZXbDqGFNt29tgBOyOTUob4Zt9nZwLuLd3Gd1+qmtXA 2cu98F0kpER/dwRzBCMwWgjghyuqCFghdp7uOGlrGMin9H+DnaSw3MXfAAyYsLs71Apd NgEQ== X-Forwarded-Encrypted: i=1; AJvYcCXxb+Rnak28gJjJ+kj+A06qGsKe8HcBJ9q96D9oRuJ5IOmBeN86UK0jzk596ZDGMOZBkcDans4=@dpdk.org X-Gm-Message-State: AOJu0YwS3DERhu1gQ+cmwVBB8gBLSOAxsS8tFd1POx2Wr5cAOl1NoT/M SLo1DmeHmsOf67/sX1oVpNUDuMNKsbzJ3RAZuhKPo+4lL7zCxd3P X-Gm-Gg: ASbGncslr+YDV0EutEASruGualfJkjYO4aLQ+zdu10oqT/CEr5J68VN0FdWRO8GxBBO /bhR6v+c/Se2M2mw+qBboRqxVlkq/9hJQ3EdGDnSTBhcaYO+5WY6bpEpR2h8ehS4VL7BuYoXnno ImKQ+e1dQF9yETuRMwcWC074fwpCQHKBKsTacJ7R6ofDdizeyVNlqarLiCMYpcChqrDNypKZpDk F6qqD5msq2Jnx7cr8dSd5zDf6iVzNSkjRBb4UJJMybDOrLQqMRVEJl175FIqnNGlUrjYTVkL4Pg AWR3yQyzIjFDzbYjbjE5VuT19Umx1XhHOabIbeUiYCxxegIAYiQ= X-Google-Smtp-Source: AGHT+IHXDKj1DFLI5g6wtcY1AFdcAJvYI4KCUhGEwxq3+8EnPeS/bPqWMfoGSddXVuVf4/3HoVhS3Q== X-Received: by 2002:a05:6000:1565:b0:391:2c67:798f with SMTP id ffacd0b85a97d-39973afad05mr3178327f8f.41.1742394112137; Wed, 19 Mar 2025 07:21:52 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:4eab:5a5d:ba39:287e]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-395cb318af0sm21216582f8f.73.2025.03.19.07.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 07:21:51 -0700 (PDT) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Vladimir Medvedkin , dpdk stable Subject: patch 'net/iavf: fix crash on app exit on FreeBSD' has been queued to stable release 22.11.8 Date: Wed, 19 Mar 2025 14:21:15 +0000 Message-ID: <20250319142142.439602-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250319142142.439602-1-luca.boccassi@gmail.com> References: <20250307122431.1415551-28-luca.boccassi@gmail.com> <20250319142142.439602-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/21/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ad8a7ddf129931efaebb971ea92d275f0f0728d5 Thanks. Luca Boccassi --- >From ad8a7ddf129931efaebb971ea92d275f0f0728d5 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 10 Mar 2025 13:11:16 +0000 Subject: [PATCH] net/iavf: fix crash on app exit on FreeBSD [ upstream commit 44a86bcf2447d7d914d7195448285aa82eaedcba ] With the fallback interrupt path now enabled on FreeBSD there are segmentation faults on app exit, due to the alarm interrupt trying to access invalid pointers. Add checks for null to fix these crashes. Fixes: cd3b124955d4 ("net/iavf: enable interrupt polling") Signed-off-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- drivers/net/iavf/iavf_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 0ff55a57b4..656a4c6176 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2529,6 +2529,9 @@ void iavf_dev_alarm_handler(void *param) { struct rte_eth_dev *dev = (struct rte_eth_dev *)param; + if (dev == NULL || dev->data == NULL || dev->data->dev_private == NULL) + return; + struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(dev->data->dev_private); uint32_t icr0; -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-19 14:20:57.230789784 +0000 +++ 0004-net-iavf-fix-crash-on-app-exit-on-FreeBSD.patch 2025-03-19 14:20:57.057288838 +0000 @@ -1 +1 @@ -From 44a86bcf2447d7d914d7195448285aa82eaedcba Mon Sep 17 00:00:00 2001 +From ad8a7ddf129931efaebb971ea92d275f0f0728d5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 44a86bcf2447d7d914d7195448285aa82eaedcba ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/iavf/iavf_ethdev.c | 3 +++ + drivers/net/iavf/iavf_ethdev.c | 3 +++ @@ -19,5 +20,5 @@ -diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c -index 1ab84b0bfc..2335746f04 100644 ---- a/drivers/net/intel/iavf/iavf_ethdev.c -+++ b/drivers/net/intel/iavf/iavf_ethdev.c -@@ -2698,6 +2698,9 @@ void +diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c +index 0ff55a57b4..656a4c6176 100644 +--- a/drivers/net/iavf/iavf_ethdev.c ++++ b/drivers/net/iavf/iavf_ethdev.c +@@ -2529,6 +2529,9 @@ void