From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91AEB46468 for ; Mon, 24 Mar 2025 17:18:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AF3C40A7F; Mon, 24 Mar 2025 17:18:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 67BB240A7F for ; Mon, 24 Mar 2025 17:18:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742833128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0M8a+YfcMBGzpeC4x2s11ylg3UxsyOU/Oa9v8qwqsNY=; b=dB6CqI8qIsJihAuEVvLfjwrJvDSweUOwfiEC3LSbrva8KG1lK+AGxIsA0LtwRTTgLbVq7O bdn+vRreN19sTPQideFf9x8taBnArMbzVp52kA29zo3eYFB7GymJpOMM0lG6SAHNAvY+rp ZfH2eMnC1R2PcdFLHmCzoThxCTx/E6k= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-_vaJnrmQNy6VGaGE6Fv8OQ-1; Mon, 24 Mar 2025 12:18:44 -0400 X-MC-Unique: _vaJnrmQNy6VGaGE6Fv8OQ-1 X-Mimecast-MFC-AGG-ID: _vaJnrmQNy6VGaGE6Fv8OQ_1742833123 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2ECAE180025A; Mon, 24 Mar 2025 16:18:43 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.16]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3FB7F30001A2; Mon, 24 Mar 2025 16:18:40 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Bruce Richardson , Vladimir Medvedkin , dpdk stable Subject: patch 'pdump: clear statistics when enabled' has been queued to stable release 24.11.2 Date: Mon, 24 Mar 2025 16:16:34 +0000 Message-ID: <20250324161731.63950-27-ktraynor@redhat.com> In-Reply-To: <20250324161731.63950-1-ktraynor@redhat.com> References: <20250324161731.63950-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RHopARY7qcPGegOp1Xc0TFbIdTW9DuNlhtQuVfgcOxs_1742833123 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/aa006690018044577d7e532bb8e549c3868d2944 Thanks. Kevin --- >From aa006690018044577d7e532bb8e549c3868d2944 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 19 Dec 2024 15:58:53 -0800 Subject: [PATCH] pdump: clear statistics when enabled [ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ] The pdump statistics are used to keep track of the number of packets captured, filtered, etc. These need not be cumalative and instead should be start counting when capture starts. This fixes the issue where multiple invocations of dumpcap would include counts from previous invocations. Bugzilla ID: 1604 Fixes: 10f726efe26c ("pdump: support pcapng and filtering") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- lib/pdump/rte_pdump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index 679c3dd0b5..0e6ffc167b 100644 --- a/lib/pdump/rte_pdump.c +++ b/lib/pdump/rte_pdump.c @@ -200,4 +200,6 @@ pdump_register_rx_callbacks(enum pdump_version ver, return rte_errno; } + + memset(&pdump_stats->rx[port][qid], 0, sizeof(struct rte_pdump_stats)); } else if (operation == DISABLE) { int ret; @@ -258,4 +260,5 @@ pdump_register_tx_callbacks(enum pdump_version ver, return rte_errno; } + memset(&pdump_stats->tx[port][qid], 0, sizeof(struct rte_pdump_stats)); } else if (operation == DISABLE) { int ret; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-24 16:15:15.796128285 +0000 +++ 0027-pdump-clear-statistics-when-enabled.patch 2025-03-24 16:15:14.858803779 +0000 @@ -1 +1 @@ -From b8392fa204ed46b580d61e7621948f1b187c9f98 Mon Sep 17 00:00:00 2001 +From aa006690018044577d7e532bb8e549c3868d2944 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b8392fa204ed46b580d61e7621948f1b187c9f98 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org