From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F09C46468 for ; Mon, 24 Mar 2025 17:18:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E51EF40DDA; Mon, 24 Mar 2025 17:18:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3C52B40A71 for ; Mon, 24 Mar 2025 17:18:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742833083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VNSndBzBbPd43arJU6nHDh7+oGPil5yg8EeYjHqvxR4=; b=KYAVO9lpnN4rzb65wHjLcXnAM7zkfQ5H5ZRij3NX+jLH2SvKOA1UJXhHzs+wEJBqsyQVoP 6v8I16yjUmwCVBLNtGYZUkQLhiEC5sDOEu7Q+XMPwnIMZqhFAjZFy77a2EnAhfDq0Gg7nJ BMiKPODnbIji5vBPpDt1EnGt1Iu1IHI= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-1ZF1GD9NPlWFVp7U0CAxlQ-1; Mon, 24 Mar 2025 12:17:49 -0400 X-MC-Unique: 1ZF1GD9NPlWFVp7U0CAxlQ-1 X-Mimecast-MFC-AGG-ID: 1ZF1GD9NPlWFVp7U0CAxlQ_1742833068 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AE73018EBE9B; Mon, 24 Mar 2025 16:17:48 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.16]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B446B30001A1; Mon, 24 Mar 2025 16:17:46 +0000 (UTC) From: Kevin Traynor To: Vladimir Medvedkin Cc: Bruce Richardson , dpdk stable Subject: patch 'net/ice: fix flow engines order' has been queued to stable release 24.11.2 Date: Mon, 24 Mar 2025 16:16:11 +0000 Message-ID: <20250324161731.63950-4-ktraynor@redhat.com> In-Reply-To: <20250324161731.63950-1-ktraynor@redhat.com> References: <20250324161731.63950-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zmzTp_2Dr3HqNs4WCq9jIway2ggtF01JNfi1sWB9HJc_1742833068 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/12e9bbdcb1d569de187e21d6ff9ae214dae16901 Thanks. Kevin --- >From 12e9bbdcb1d569de187e21d6ff9ae214dae16901 Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Mon, 10 Mar 2025 17:40:28 +0000 Subject: [PATCH] net/ice: fix flow engines order [ upstream commit b309503d63159680d4ff8ca9e968fcb12ac609a0 ] Currently, the driver evaluates rules with the engines in the order they are executed in the hardware. However, in this situation, some wildcarded flows that are also supported by the ACL engine are installed as switch engine rules, which scales poorly with each distinct wildcard mask configuration. Reorder flow engine evaluation for RTE flow rule installation to fix this problem. Fixes: fabc9e1322e2 ("net/ice: fix flows handling") Signed-off-by: Vladimir Medvedkin Acked-by: Bruce Richardson --- drivers/net/ice/ice_generic_flow.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index 5c34e0385f..4049157eab 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -2240,7 +2240,7 @@ static struct ice_flow_parser *get_flow_parser(uint32_t group) switch (group) { case 0: - return &ice_switch_parser; - case 1: return &ice_acl_parser; + case 1: + return &ice_switch_parser; case 2: return &ice_fdir_parser; @@ -2299,4 +2299,11 @@ ice_flow_process_filter(struct rte_eth_dev *dev, for (int i = 0; i < ICE_FLOW_ENGINE_NB; i++) { + /** + * Evaluate parsers in the following order: + * ACL - for some subset of wildcard matching rules + * Switch - This engine is placed after ACL because + * it scales worse than ACL for different wildcard masks. + * FDIR - for exact match rules + **/ parser = get_flow_parser(i); if (parser == NULL) { -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-24 16:15:14.978019886 +0000 +++ 0004-net-ice-fix-flow-engines-order.patch 2025-03-24 16:15:14.701735300 +0000 @@ -1 +1 @@ -From b309503d63159680d4ff8ca9e968fcb12ac609a0 Mon Sep 17 00:00:00 2001 +From 12e9bbdcb1d569de187e21d6ff9ae214dae16901 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b309503d63159680d4ff8ca9e968fcb12ac609a0 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ - drivers/net/intel/ice/ice_generic_flow.c | 11 +++++++++-- + drivers/net/ice/ice_generic_flow.c | 11 +++++++++-- @@ -22 +23 @@ -diff --git a/drivers/net/intel/ice/ice_generic_flow.c b/drivers/net/intel/ice/ice_generic_flow.c +diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c @@ -24,2 +25,2 @@ ---- a/drivers/net/intel/ice/ice_generic_flow.c -+++ b/drivers/net/intel/ice/ice_generic_flow.c +--- a/drivers/net/ice/ice_generic_flow.c ++++ b/drivers/net/ice/ice_generic_flow.c