From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 171CE46468 for ; Mon, 24 Mar 2025 17:18:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FF8D40A7F; Mon, 24 Mar 2025 17:18:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C73C240A7F for ; Mon, 24 Mar 2025 17:18:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742833085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vMWbU+SM/FA7P6p22ceR62HG7qqHZA0JwWQsuMz79Rc=; b=G29tHccSvd1+XiQxwwn7RRZJ5NgwbCUZLLUB7JqSE6d7BgP1hfoBCU8YPxUH8xuFPYShY2 d4kFsQZYRbGKix8IXocmco0EutqyirOtpHf6sYgZNVZSyd9z/7JjpQBMycN32PIoOEtzse 87B5EkfZrZo0SrOd3ReghqUbaWg/fCQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-ha1FKnsINwiyicKYeHAvWw-1; Mon, 24 Mar 2025 12:17:52 -0400 X-MC-Unique: ha1FKnsINwiyicKYeHAvWw-1 X-Mimecast-MFC-AGG-ID: ha1FKnsINwiyicKYeHAvWw_1742833071 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A635A1955D84; Mon, 24 Mar 2025 16:17:51 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.16]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7ABBC30001A1; Mon, 24 Mar 2025 16:17:49 +0000 (UTC) From: Kevin Traynor To: Matthew Smith Cc: Vladimir Medvedkin , dpdk stable Subject: patch 'net/ice: fix dropped packets when using VRRP' has been queued to stable release 24.11.2 Date: Mon, 24 Mar 2025 16:16:12 +0000 Message-ID: <20250324161731.63950-5-ktraynor@redhat.com> In-Reply-To: <20250324161731.63950-1-ktraynor@redhat.com> References: <20250324161731.63950-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: iqIXRx1LbVNhx-huJCMbX-dDGdgU-3ZtX_ROtrwkGqY_1742833071 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1ea4b841a336fc8421d14feebca26c38b0cba852 Thanks. Kevin --- >From 1ea4b841a336fc8421d14feebca26c38b0cba852 Mon Sep 17 00:00:00 2001 From: Matthew Smith Date: Tue, 11 Mar 2025 21:40:31 +0000 Subject: [PATCH] net/ice: fix dropped packets when using VRRP [ upstream commit 6f866eb93e796aaf226f66c689e4c4e1b2290c90 ] While adding a vsi for an ice PF, set the ICE_AQ_VSI_SW_FLAG_LOCAL_LB flag. This will prevent packets from being dropped when using a virtual MAC address with VRRP. Also set the ICE_AQ_VSI_SW_FLAG_SRC_PRUNE flag to prevent transmitted packets from being looped back in some circumstances. Fixes: f9cf4f864150 ("net/ice: support device initialization") Signed-off-by: Matthew Smith Acked-by: Vladimir Medvedkin --- drivers/net/ice/ice_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 93a6308a86..2929f1253d 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -1697,4 +1697,8 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type) */ vsi_ctx.info.sw_id = hw->port_info->sw_id; + vsi_ctx.info.sw_flags = ICE_AQ_VSI_SW_FLAG_LOCAL_LB; + vsi_ctx.info.sw_flags |= ICE_AQ_VSI_SW_FLAG_SRC_PRUNE; + cfg = ICE_AQ_VSI_PROP_SW_VALID; + vsi_ctx.info.valid_sections |= rte_cpu_to_le_16(cfg); vsi_ctx.info.sw_flags2 = ICE_AQ_VSI_SW_FLAG_LAN_ENA; /* Allow all untagged or tagged packets */ -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-24 16:15:15.007884633 +0000 +++ 0005-net-ice-fix-dropped-packets-when-using-VRRP.patch 2025-03-24 16:15:14.707735325 +0000 @@ -1 +1 @@ -From 6f866eb93e796aaf226f66c689e4c4e1b2290c90 Mon Sep 17 00:00:00 2001 +From 1ea4b841a336fc8421d14feebca26c38b0cba852 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6f866eb93e796aaf226f66c689e4c4e1b2290c90 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ - drivers/net/intel/ice/ice_ethdev.c | 4 ++++ + drivers/net/ice/ice_ethdev.c | 4 ++++ @@ -22,4 +23,4 @@ -diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c -index 3cdfa16f77..21d3795954 100644 ---- a/drivers/net/intel/ice/ice_ethdev.c -+++ b/drivers/net/intel/ice/ice_ethdev.c +diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c +index 93a6308a86..2929f1253d 100644 +--- a/drivers/net/ice/ice_ethdev.c ++++ b/drivers/net/ice/ice_ethdev.c