From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D07B46468 for ; Mon, 24 Mar 2025 17:18:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7764140A71; Mon, 24 Mar 2025 17:18:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1603040C35 for ; Mon, 24 Mar 2025 17:17:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742833078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w5gcmmatQqTnS9qutseW/9dpUfydMTX8LluGC349JEo=; b=R3S8IkAUu7DcWlS9YtWB2XGl4w6YRafdvUUSmdqQNIRDKgXNN73sL+Zq1UVdyRQ3sDDqqc QM1EoYWlEibLZP6PtaXyfsOdwjGoeT7xbxbaG291bTied1lW/ySP9gSw3+qaJsbCLcTkvU /qU8O772epotzah4znTFWy9Q4rRvzD8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-xKmMkgKmM6GQAMTZaB14Bg-1; Mon, 24 Mar 2025 12:17:55 -0400 X-MC-Unique: xKmMkgKmM6GQAMTZaB14Bg-1 X-Mimecast-MFC-AGG-ID: xKmMkgKmM6GQAMTZaB14Bg_1742833074 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0A614180AF74; Mon, 24 Mar 2025 16:17:54 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.16]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4161D30001A1; Mon, 24 Mar 2025 16:17:51 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Vladimir Medvedkin , dpdk stable Subject: patch 'net/iavf: check interrupt registration failure' has been queued to stable release 24.11.2 Date: Mon, 24 Mar 2025 16:16:13 +0000 Message-ID: <20250324161731.63950-6-ktraynor@redhat.com> In-Reply-To: <20250324161731.63950-1-ktraynor@redhat.com> References: <20250324161731.63950-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wOW55_Fc9-bMh_TXLAOXJzV2GaWh-maiBHrR53EILKs_1742833074 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f19ad7db5cb62ce548c23a9b31d84d70ade68464 Thanks. Kevin --- >From f19ad7db5cb62ce548c23a9b31d84d70ade68464 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 10 Mar 2025 13:11:15 +0000 Subject: [PATCH] net/iavf: check interrupt registration failure [ upstream commit 12e8844f0bda3c4e4e578e180dfa0136f9285182 ] When registering interrupts, there was no check if the registration of the interrupt succeeded. Add in such a check, and go to fallback path if the check fails. This prevents errors on FreeBSD due to missed admin queue messages. Fixes: cd3b124955d4 ("net/iavf: enable interrupt polling") Signed-off-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- drivers/net/iavf/iavf_ethdev.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 7f80cd6258..9767f1d372 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2826,16 +2826,14 @@ iavf_dev_init(struct rte_eth_dev *eth_dev) - if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) { - /* register callback func to eal lib */ - rte_intr_callback_register(pci_dev->intr_handle, - iavf_dev_interrupt_handler, - (void *)eth_dev); + if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR && + /* register callback func to eal lib */ + rte_intr_callback_register(pci_dev->intr_handle, + iavf_dev_interrupt_handler, (void *)eth_dev) == 0) /* enable uio intr after callback register */ rte_intr_enable(pci_dev->intr_handle); - } else { + else rte_eal_alarm_set(IAVF_ALARM_INTERVAL, iavf_dev_alarm_handler, eth_dev); - } /* configure and enable device interrupt */ -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-24 16:15:15.040561800 +0000 +++ 0006-net-iavf-check-interrupt-registration-failure.patch 2025-03-24 16:15:14.710735337 +0000 @@ -1 +1 @@ -From 12e8844f0bda3c4e4e578e180dfa0136f9285182 Mon Sep 17 00:00:00 2001 +From f19ad7db5cb62ce548c23a9b31d84d70ade68464 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 12e8844f0bda3c4e4e578e180dfa0136f9285182 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - drivers/net/intel/iavf/iavf_ethdev.c | 12 +++++------- + drivers/net/iavf/iavf_ethdev.c | 12 +++++------- @@ -20,4 +21,4 @@ -diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c -index 9cd2b0c867..1ab84b0bfc 100644 ---- a/drivers/net/intel/iavf/iavf_ethdev.c -+++ b/drivers/net/intel/iavf/iavf_ethdev.c +diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c +index 7f80cd6258..9767f1d372 100644 +--- a/drivers/net/iavf/iavf_ethdev.c ++++ b/drivers/net/iavf/iavf_ethdev.c