From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3AF246468 for ; Mon, 24 Mar 2025 17:18:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AECC740DCE; Mon, 24 Mar 2025 17:18:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E3EFF40A71 for ; Mon, 24 Mar 2025 17:18:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742833082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bBYiWnQIhyH8Wwec/6/XlB6A9yvmyEAV2Qr1pcDEWrQ=; b=bURhplIR+qctkBRfLHidwieZXwSf1htHpvTDUReSTNd5DHQIdWIwxLfjnMHIQsKNwDPgkW l2qBGiXo+WhAfuPnebErrvonL+rb2m/sUiOqawe1okIxfJsMt629ac6VlZ/GcyC2BsIVZ1 9WMEkAgHYjc94He5LStx+UUWVTdI8/g= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-qjDNl4JAMqunj9ElT9D2-Q-1; Mon, 24 Mar 2025 12:17:57 -0400 X-MC-Unique: qjDNl4JAMqunj9ElT9D2-Q-1 X-Mimecast-MFC-AGG-ID: qjDNl4JAMqunj9ElT9D2-Q_1742833076 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2CFC6180AF6B; Mon, 24 Mar 2025 16:17:56 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.16]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9829C30001A1; Mon, 24 Mar 2025 16:17:54 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Vladimir Medvedkin , dpdk stable Subject: patch 'net/iavf: fix crash on app exit on FreeBSD' has been queued to stable release 24.11.2 Date: Mon, 24 Mar 2025 16:16:14 +0000 Message-ID: <20250324161731.63950-7-ktraynor@redhat.com> In-Reply-To: <20250324161731.63950-1-ktraynor@redhat.com> References: <20250324161731.63950-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YXkpRg63rsVmmq-_4XhFOrr3LN9owEHF1Hd0lDxso1E_1742833076 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/eac74e15d918cd528c7d879a6ce39dab80093845 Thanks. Kevin --- >From eac74e15d918cd528c7d879a6ce39dab80093845 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 10 Mar 2025 13:11:16 +0000 Subject: [PATCH] net/iavf: fix crash on app exit on FreeBSD [ upstream commit 44a86bcf2447d7d914d7195448285aa82eaedcba ] With the fallback interrupt path now enabled on FreeBSD there are segmentation faults on app exit, due to the alarm interrupt trying to access invalid pointers. Add checks for null to fix these crashes. Fixes: cd3b124955d4 ("net/iavf: enable interrupt polling") Signed-off-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- drivers/net/iavf/iavf_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 9767f1d372..2ea84cef6d 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2699,4 +2699,7 @@ iavf_dev_alarm_handler(void *param) { struct rte_eth_dev *dev = (struct rte_eth_dev *)param; + if (dev == NULL || dev->data == NULL || dev->data->dev_private == NULL) + return; + struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(dev->data->dev_private); uint32_t icr0; -- 2.48.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-03-24 16:15:15.070291098 +0000 +++ 0007-net-iavf-fix-crash-on-app-exit-on-FreeBSD.patch 2025-03-24 16:15:14.712735345 +0000 @@ -1 +1 @@ -From 44a86bcf2447d7d914d7195448285aa82eaedcba Mon Sep 17 00:00:00 2001 +From eac74e15d918cd528c7d879a6ce39dab80093845 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 44a86bcf2447d7d914d7195448285aa82eaedcba ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +17 @@ - drivers/net/intel/iavf/iavf_ethdev.c | 3 +++ + drivers/net/iavf/iavf_ethdev.c | 3 +++ @@ -19,4 +20,4 @@ -diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c -index 1ab84b0bfc..2335746f04 100644 ---- a/drivers/net/intel/iavf/iavf_ethdev.c -+++ b/drivers/net/intel/iavf/iavf_ethdev.c +diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c +index 9767f1d372..2ea84cef6d 100644 +--- a/drivers/net/iavf/iavf_ethdev.c ++++ b/drivers/net/iavf/iavf_ethdev.c