From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A19C84642F for ; Tue, 8 Apr 2025 09:46:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C0B34027F; Tue, 8 Apr 2025 09:46:24 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2044.outbound.protection.outlook.com [40.107.92.44]) by mails.dpdk.org (Postfix) with ESMTP id E5F6E4027F for ; Tue, 8 Apr 2025 09:46:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cYkdQTInD2DDCHQieY4se2dCjtCMQOXUcmRYI7KB/wRlQvoRB9if6DwkpRKhF4aplToM1aKne9kwzq0mOJRoR5zxhVxp91AdaHWNCFlrmPJKWztylJIknBEsAcJRDiZMHIEZcOc7s14vLzAPowqsBwHJoYyqLH7TORNE5poSDbErBuAASusTvQZZe1ZOl5hJZH0zqTVjKMEYrrx6io+4KxouO6R50nL5i6DxkSLSFpWdlaFxIv2CO2jQkCCKeCvltgSk1qqssHE3kcPcYNqp/Ef4GnOo2FN2yUPFAJ6Fk79F0ACvLPLBE2+79QPnCkOnMJ4ah4c5JBzwxegSSvJJgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qGqfyQj1T6hjPd6jn6P0YFraW+v9/hO0qVk0VDfUcW0=; b=Szb2QZ8M7vFWjLuckVxOmRltbDvdcqbsutomXICGKv9YEN1444dP9D6iGpYwkmNPrYxCf7PS/svgQYON6cUkZG/DEyt8vYNwzJW/c62zYiQAaf8K1Mn72vZneO+A3PHbY6a3rthvluRn8cp+8eYzM99gpRYTHYiWQUa+KcbAJbsPHIB+ZrP6XUak2sdKMGCEAOg0suuZ/c61oKBDBIe/Af/WV1ts8jEUVCKosyUTI538G2NIEytYkcn61sQ1cONxUa/TCpDQR+RiBxYAl3IXuQoDAajbvBcgupTqH4Q0pM3WgWEWyqunL3ra3w6qRe8zPzTIfs2noA3nZoERCzEA7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=microsoft.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qGqfyQj1T6hjPd6jn6P0YFraW+v9/hO0qVk0VDfUcW0=; b=cypJwqRxysL4c1zR2NWjdwsLEZ5dPcwarSL+ZYX9SMu3d63WO2DfCzEg4LKBudfJwq9RquliMcy4/KF43BwWz93DVkp0bECR9R6+CxlNlJg7ORzG5A3pt05q48rRu1aBV9PXXyBMgvHVeDzxKhWSQpp+C+9q0VDal++WfpfKeGvJb+zEB2+lFFQI/ydcyH2zb1YQSigqKbS4njBoXSLkJMqlSJJuEh+LPtMu5FUIEFnEa2LMOQJD+rXnmtLttzFKd4D/MYoFd/5PPux3iOgNlX+cq34+PwS/1/teVW12PyTyodU1dGl0QK6TYm7F9lnSq6x6O6WaGhxFwxaodech3Q== Received: from MW4PR04CA0266.namprd04.prod.outlook.com (2603:10b6:303:88::31) by SN7PR12MB8171.namprd12.prod.outlook.com (2603:10b6:806:322::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.44; Tue, 8 Apr 2025 07:46:20 +0000 Received: from SJ1PEPF000023CC.namprd02.prod.outlook.com (2603:10b6:303:88:cafe::65) by MW4PR04CA0266.outlook.office365.com (2603:10b6:303:88::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8606.34 via Frontend Transport; Tue, 8 Apr 2025 07:46:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF000023CC.mail.protection.outlook.com (10.167.244.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.22 via Frontend Transport; Tue, 8 Apr 2025 07:46:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Apr 2025 00:46:06 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Apr 2025 00:46:01 -0700 From: Xueming Li To: Long Li CC: Xueming Li , dpdk stable Subject: patch 'net/netvsc: remove device if its net devices removed' has been queued to stable release 23.11.4 Date: Tue, 8 Apr 2025 15:44:28 +0800 Message-ID: <20250408074515.361046-4-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250408074515.361046-1-xuemingl@nvidia.com> References: <20250218123523.36836-1-xuemingl@nvidia.com> <20250408074515.361046-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023CC:EE_|SN7PR12MB8171:EE_ X-MS-Office365-Filtering-Correlation-Id: 97325a79-bd57-4f33-5194-08dd767173af X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YRBlp8mTKImwRx0D1NLvZF3ISMIzDIDOwNQ2JgruDwtvyksjkR9Bb/uuxxCH?= =?us-ascii?Q?dvkOaG6Gydg+MxBegGiDOYUTqJ0IAq8gr2/9lhhwdbCOZMEbrgfeyE2rMeZ2?= =?us-ascii?Q?+u3PPiQ31nDdc+BFY09DEj3+rTEmh567N1BogLymxVj9LqS/pOypGTcH17P9?= =?us-ascii?Q?tNFxqCuWMYrPNRwDL+ErHi80dz64Y4XdKcS6EJIIaSlWE2L+axCKtd8jTXsc?= =?us-ascii?Q?8UAupajBUBAVh0tNwPpCiAuO4cvzuGKq90dc8jxEOW3vVNVPQC+LgbOHddve?= =?us-ascii?Q?7N+y/2pirkszTPrf32Zv5fhSX2dbekaIgoIbM1y2R4YImReEsnVx0LJArbL6?= =?us-ascii?Q?Tjl4gCPPHkOPMHgsY5C057Me8b/HJTl/9jLT30N3oaOO274Bq5+9RpdMVbA0?= =?us-ascii?Q?D3ZTFIMb+r9VK4iZq3QwYvt7MHEhxmTta5gkv+eKkt1E9tIT/oHCTiPeOcDR?= =?us-ascii?Q?xpK6vrdk50XhGmr3kM/0fsM+QsWjQJaIYs8Osq5kz1jYxMTK9Jm3p4FQ62vp?= =?us-ascii?Q?B5LR9YdjAx0JEBREp+z1oqD6tp+tl/v7qHIqp6TwKRXSOt9KGE0ttowdLu7c?= =?us-ascii?Q?XZCYbK4R0r+/Kisu4l1bq6dQHfCbz7Ipq1PAoa2mIsnLyukK8pNOwOwR/d1o?= =?us-ascii?Q?AUjdB5+vIg3w5ZESh7J2FUSJfudVM7Jz9PWaZ+wz8FQE4CHXLyirTzXOqN/x?= =?us-ascii?Q?+cCWqESQcTJ1nrnidfG9FVUi1KwfYDXFZBV3GJLOdwdhrdOJ9p1MD4PfAIIW?= =?us-ascii?Q?BpRQNdos8Q/CEwMjKCamAYJ47yTIBKJR7tHydz42I0N6DhlP12kWUCaVq5I2?= =?us-ascii?Q?8mK6dPk1svKezwmndUNZs8Nqz1LiN22piG3w8jsew+VP9G0yxeqBjs8wsoSm?= =?us-ascii?Q?hmMItk6dvBURHw9EFWbcZVHsjp6SoM/mjWEMILDzJ06L3FbmmeJl9FZhSHD3?= =?us-ascii?Q?qHmWNz8tc/8je3lkaFrYv5Cz5flUifS8o6+fxzUtY90o7ttT3O9eXfIFGG+P?= =?us-ascii?Q?4swjf/kVu5di9BVGs1l3g2N/S/x53W0f6Lb/9qYYYBdCg1S2kLWaO81qWpLF?= =?us-ascii?Q?DMc+jIOqUsaG6FeU39NxWxuFzxBtEo54SWHQs7C2hQXu7CdPW97JU/ozXpFs?= =?us-ascii?Q?rPnXiEQVlGr3uqzIwAAigYKcg7ATc/EpIfXRDamZkEOQQbD7R0fpfISXPf70?= =?us-ascii?Q?XIqkcHb6Jw8tSNDr7/Rvk9b2ebpWwWc36WSDrSSfRwcVQta4BZVLH5Ga+zjY?= =?us-ascii?Q?PfXgzoaH4M3DAjkTBOM3utKpKloWpv8K4n64SPRz7CqNLO5FWG487ByjCBac?= =?us-ascii?Q?5iQyfO6Ols55SZxAExkLvcBfTbb2i8s/DjrUyoSwPOu3lgZhvqCPKe8QZna3?= =?us-ascii?Q?34IlWtJt603EqBAgUHVuXRjP1vCoRYm0VLTQBqw+1XtG9Zw2tpjjmzRFbpJy?= =?us-ascii?Q?SkFb5ljBp39UvRykHASwD6XmmsKwcN5l1CX+GrGeRjOtLSIUR99T0pkKQKNb?= =?us-ascii?Q?JIit4FKJHomrXD8=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 07:46:20.0573 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97325a79-bd57-4f33-5194-08dd767173af X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023CC.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8171 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/10/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=8848621c74fa30b4ebe3566438bd2ac25b555def Thanks. Xueming Li --- >From 8848621c74fa30b4ebe3566438bd2ac25b555def Mon Sep 17 00:00:00 2001 From: Long Li Date: Thu, 13 Feb 2025 10:58:24 -0800 Subject: [PATCH] net/netvsc: remove device if its net devices removed Cc: Xueming Li [ upstream commit 1ec0995e173da14f2871ee19326f275f94f412c4 ] An RTE device can have multiple Ethernet devices. On hot plug events, it can't be removed until all its Ethernet devices have been removed. Fixes: a2a23a794b3a ("net/netvsc: support VF device hot add/remove") Signed-off-by: Long Li --- drivers/net/netvsc/hn_vf.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c index a4e958419d..7d61376e63 100644 --- a/drivers/net/netvsc/hn_vf.c +++ b/drivers/net/netvsc/hn_vf.c @@ -102,6 +102,7 @@ static void hn_remove_delayed(void *args) uint16_t port_id = hv->vf_ctx.vf_port; struct rte_device *dev = rte_eth_devices[port_id].device; int ret; + bool all_eth_removed; /* Tell VSP to switch data path to synthetic */ hn_vf_remove(hv); @@ -138,7 +139,17 @@ static void hn_remove_delayed(void *args) PMD_DRV_LOG(ERR, "rte_eth_dev_close failed port_id=%u ret=%d", port_id, ret); - ret = rte_dev_remove(dev); + /* Remove the rte device when all its eth devices are removed */ + all_eth_removed = true; + RTE_ETH_FOREACH_DEV_OF(port_id, dev) { + if (rte_eth_devices[port_id].state != RTE_ETH_DEV_UNUSED) { + all_eth_removed = false; + break; + } + } + if (all_eth_removed) + ret = rte_dev_remove(dev); + hv->vf_ctx.vf_state = vf_removed; rte_rwlock_write_unlock(&hv->vf_lock); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-04-08 15:39:06.160262106 +0800 +++ 0003-net-netvsc-remove-device-if-its-net-devices-removed.patch 2025-04-08 15:39:05.856436604 +0800 @@ -1 +1 @@ -From 1ec0995e173da14f2871ee19326f275f94f412c4 Mon Sep 17 00:00:00 2001 +From 8848621c74fa30b4ebe3566438bd2ac25b555def Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 1ec0995e173da14f2871ee19326f275f94f412c4 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -18 +20 @@ -index b664beaa5d..5d8058774d 100644 +index a4e958419d..7d61376e63 100644